Recover lens for types implementing the Recursive trait. (#132)

* Remove lens

* Remove lens

* Apply suggestion from @Nashtare

Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>

* Remove commented derive

* Fmt

---------

Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>

Author: 4l0n50

recursion/src/circuit_verifier.rs

@@ -418,41 +418,24 @@ mod tests {
     impl<F: Field, EF: ExtensionField<F>> Recursive<EF> for DummyCom<F> {
         type Input = Vec<Vec<F>>;
 
-        fn new(
-            _circuit: &mut CircuitBuilder<EF>,
-            _lens: &mut impl Iterator<Item = usize>,
-            _degree_bits: usize,
-        ) -> Self {
+        fn new(_circuit: &mut CircuitBuilder<EF>, _input: &Self::Input) -> Self {
             vec![]
         }
 
         fn get_values(input: &Self::Input) -> Vec<EF> {
             input.iter().flatten().map(|v| EF::from(*v)).collect()
         }
-
-        fn lens(_input: &Self::Input) -> impl Iterator<Item = usize> {
-            core::iter::empty()
-        }
     }
 
     type EmptyTarget = ();
     impl<F: Field> Recursive<F> for EmptyTarget {
         type Input = ();
 
-        fn new(
-            _circuit: &mut p3_circuit::CircuitBuilder<F>,
-            _lens: &mut impl Iterator<Item = usize>,
-            _degree_bits: usize,
-        ) -> Self {
-        }
+        fn new(_circuit: &mut p3_circuit::CircuitBuilder<F>, _input: &Self::Input) -> Self {}
 
         fn get_values(_input: &Self::Input) -> vec::Vec<F> {
             vec![]
         }
-
-        fn lens(_input: &Self::Input) -> impl Iterator<Item = usize> {
-            core::iter::empty()
-        }
     }
 
     impl<SC: StarkGenericConfig, Comm: Recursive<SC::Challenge>, Dft>
@@ -717,19 +700,13 @@ mod tests {
         proof.commitments.quotient_chunks = vec![];
         proof.commitments.trace = vec![];
 
-        let mut all_lens = ProofTargets::<
-            StarkConfig<TrivialPcs<Val, Dft>, Challenge, Challenger>,
-            DummyCom<Val>,
-            EmptyTarget,
-        >::lens(&proof);
-
         // Initialize the circuit builder.
         let mut circuit_builder = CircuitBuilder::new();
         let proof_targets = ProofTargets::<
             StarkConfig<TrivialPcs<Val, Dft>, Challenge, Challenger>,
             DummyCom<Val>,
             EmptyTarget,
-        >::new(&mut circuit_builder, &mut all_lens, proof.degree_bits);
+        >::new(&mut circuit_builder, &proof);
 
         let proof_values = ProofTargets::<
             StarkConfig<TrivialPcs<Val, Dft>, Challenge, Challenger>,

recursion/src/public_inputs.rs

@@ -305,9 +305,7 @@ where
             .collect();
 
         // Allocate proof targets
-        let mut lens = crate::recursive_traits::ProofTargets::<SC, Comm, OpeningProof>::lens(proof);
-        let proof_targets =
-            crate::recursive_traits::ProofTargets::new(circuit, &mut lens, proof.degree_bits);
+        let proof_targets = crate::recursive_traits::ProofTargets::new(circuit, proof);
 
         Self {
             air_public_targets,