Address reviews

Author: 4l0n50

circuit-prover/examples/mmcs_verify.rs

@@ -47,7 +47,7 @@ fn main() -> Result<(), ProverError> {
     // we're proving the opening of an Mmcs to matrices of height 2^depth, 2^(depth -1), ...
     let leaves: Vec<Vec<ExprId>> = (0..depth)
         .map(|i| {
-            (0..if (i as usize).is_multiple_of(2) && i != depth - 1 {
+            (0..if i % 2 == 0 && i != depth - 1 {
                 mmcs_config.ext_field_digest_elems
             } else {
                 0
@@ -57,7 +57,7 @@ fn main() -> Result<(), ProverError> {
         })
         .collect();
     let directions: Vec<ExprId> = (0..depth)
-        .map(|_| builder.alloc_public_input("index"))
+        .map(|_| builder.alloc_public_input("directions"))
         .collect();
     let expected_root = (0..mmcs_config.ext_field_digest_elems)
         .map(|_| builder.alloc_public_input("expected_root"))
@@ -76,7 +76,7 @@ fn main() -> Result<(), ProverError> {
     //
     let leaves_value: Vec<Vec<F>> = (0..depth)
         .map(|i| {
-            if (i as usize).is_multiple_of(2) && i != depth - 1 {
+            if i % 2 == 0 && i != depth - 1 {
                 vec![
                     F::ZERO,
                     F::ZERO,

circuit/src/builder/circuit_builder.rs

@@ -30,7 +30,7 @@ pub struct CircuitBuilder<F> {
     config: BuilderConfig,
 }
 
-/// The non-primitive operation id, type, and the vecotors of the expressions representing its inputs
+/// The non-primitive operation id, type, and the vectors of the expressions representing its inputs
 pub type NonPrimitiveOperationData = (NonPrimitiveOpId, NonPrimitiveOpType, Vec<Vec<ExprId>>);
 
 impl<F> Default for CircuitBuilder<F>

circuit/src/builder/compiler/non_primitive_lowerer.rs

@@ -74,7 +74,7 @@ impl<'a> NonPrimitiveLowerer<'a> {
                         return Err(CircuitBuilderError::NonPrimitiveOpArity {
                             op: "MmcsVerify",
                             expected: format!("{:?}", config.directions_size()),
-                            got: witness_exprs[1].len(),
+                            got: directions_len,
                         });
                     }