Skip to content

Force more engaging test on data clean #404

@chrisdanek

Description

@chrisdanek

Right now when running data clean I am asked to type in CLEAN DATA regardless of which environment I am targeting. My particular workflow is just typing a few letters in the console like pos-cli data and then browsing the history of previous commands. It may result in picking an invalid environment due to oversight. I try to double-check that each time, but sooner or later I’ll mess up and erase production :(

Actual behavior

[16:05:36]
[16:05:36] WARNING!!! You are going to REMOVE your data from instance: https://qa-golfstix.staging.oregon.platform-os.com/
[16:05:36] There is no coming back.
[16:05:36]
✔ If you still want to continue please type: 'CLEAN DATA'  … CLEAN DATA

Expected behavior

A more meaningful test would ask you to enter the name of the environment you want to clean so

[16:05:36]
[16:05:36] WARNING!!! You are going to REMOVE your data from instance: https://qa-golfstix.staging.oregon.platform-os.com/
[16:05:36] There is no coming back.
[16:05:36]
✔ If you still want to continue please type name of the environment: 'qa'  … qa

This way you make running data clean on the wrong instance harder.

Version

  • pos-cli: 4.4.11
  • node: v13.6.0
  • os: osx

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions