Skip to content

Recent commits broke Apple Metal (M1) GPU support #63

@cbrunnkvist

Description

@cbrunnkvist

This utility seemed to work quite okay in the past. Really cool PoC and very handy utility to have around! Today however, after I did a git pull it started crashing when the gpu feature is enabled with an error related to'NAMESPACE_QUALIFIER'\n#define NAMESPACE_QUALIFIER __generic // TODO: how to make __private on apple?.

I ran a git bisect to pinpoint it, and yes it seems like commit ed772eb broke it:

ed772eb0cb54c687df48fcf5dc9cb498973d6585 is the first bad commit
commit ed772eb0cb54c687df48fcf5dc9cb498973d6585
Author: Brandon Ros <brandonros1@gmail.com>
Date:   Fri Apr 19 12:09:21 2024 -0400

    namespace concept

 src/gpu_impl.rs          |  1 +
 src/opencl/blake2b.cl    |  4 +--
 src/opencl/curve25519.cl | 63 ++++++++++++++++++++++++------------------------
 src/opencl/util.cl       |  1 +
 4 files changed, 35 insertions(+), 34 deletions(-)
 create mode 100644 src/opencl/util.cl
bisect found first bad commit%                                                                                                                                                                       [SeabeeEmbyEy20 ~/Developer/nano/nano-vanity] [:ed772eb|BISECT 1; 0 steps L|…1]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions