Skip to content

[ACTION] Improve Apify actions #16305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dannyroosevelt opened this issue Apr 15, 2025 · 3 comments · Fixed by #16384
Closed

[ACTION] Improve Apify actions #16305

dannyroosevelt opened this issue Apr 15, 2025 · 3 comments · Fixed by #16384
Assignees
@michelle0927
Labels
action New Action Request enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@dannyroosevelt
Copy link
Collaborator

In the Apify Run Action action, there are a couple issues:

  1. The action isn't returning the results you would expect (they probably kick off an async job that requires we wait for the results, or potentially give them a webhook to post results to — we should potentially use $.flow.suspend() here)
  2. Some of the additionalProps are flagged as optional: false, but it seems like they actually are optional
@dannyroosevelt dannyroosevelt added action New Action Request enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 15, 2025
@vunguyenhung vunguyenhung added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Apr 17, 2025
@michelle0927 michelle0927 self-assigned this Apr 21, 2025
@michelle0927 michelle0927 moved this from Prioritized to Doing in Component (Source and Action) Backlog Apr 21, 2025
@michelle0927 michelle0927 mentioned this issue Apr 21, 2025
Merged
@michelle0927 michelle0927 moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Apr 21, 2025
@luancazarine luancazarine moved this from Ready for PR Review to In Review in Component (Source and Action) Backlog Apr 21, 2025
@luancazarine luancazarine moved this from In Review to Ready for QA in Component (Source and Action) Backlog Apr 21, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Apr 22, 2025
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog Apr 22, 2025
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/ACTION-Improve-Apify-actions-1ddbf548bb5e81b78a00cd4e594d4d87

@michelle0927 michelle0927 moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Apr 22, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Apr 23, 2025
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog Apr 23, 2025
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/ACTION-Improve-Apify-actions-1ddbf548bb5e81b78a00cd4e594d4d87

@michelle0927 michelle0927 moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Apr 23, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Apr 24, 2025
@vunguyenhung vunguyenhung moved this from In QA to Ready for Release in Component (Source and Action) Backlog Apr 24, 2025
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/ACTION-Improve-Apify-actions-1ddbf548bb5e81b78a00cd4e594d4d87

@github-project-automation github-project-automation bot moved this from Ready for Release to Done in Component (Source and Action) Backlog Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michelle0927 michelle0927

Labels
action New Action Request enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Component (Source and Action) Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Apify actions PipedreamHQ/pipedream
3 participants
@michelle0927 @vunguyenhung @dannyroosevelt