Porting/bisect-runner.pl: Refers to no longer existent file ext/DB_File/DB_File.xs

[jkeenan]

While attempting to Porting/bisect.pl and its companion, Porting/bisect-runner.pl, working with Perl 7 semantics this evening, I encountered this error:

$ thisperl -Ilib Porting/bisect.pl --start=9468ee108092defa7d579c11eeb629480e2de99d --end=0de0733590e040ab21393deb629531cfa76c5f5c --target=t/comp/induce.t
We are not bisecting.
Previous HEAD position was 9468ee1080 Comment certain tests as PROBLEM
HEAD is now at 0de0733590 Valid commit but syntax error still present
Can't open ext/DB_File/DB_File.xs: No such file or directory at /tmp/2CkhLBe8BW line 1157

The tempfile in question, /tmp/2CkhLBe8BW, turns out to be a copy of Porting/bisect_runner.pl.

I then grepped Porting/bisect* in Perl 5 blead and got this:

$ ack DB_File Porting/bisect*
Porting/bisect-runner.pl
262:L<DB_File> for commits earlier than ccb44e3bf3be2c30, as it's not practical
263:to patch DB_File 1.70 and earlier to build with current Berkeley DB headers.
1507:    && !extract_from_file('ext/DB_File/DB_File.xs',
1509:    # This DB_File.xs is really too old to patch up.
1510:    # Skip DB_File, unless we're invoked with an explicit -Unoextensions
1512:        $defines{noextensions} = 'DB_File';
1514:        $defines{noextensions} .= ' DB_File';
3749:        } elsif (!extract_from_file('ext/DB_File/DB_File.xs',
3752:            my $line = extract_from_file('ext/DB_File/DB_File.xs',
3755:diff --git a/ext/DB_File/DB_File.xs b/ext/DB_File/DB_File.xs
3757:--- a/ext/DB_File/DB_File.xs
3758:+++ b/ext/DB_File/DB_File.xs

For some reason my draft revision of Porting/bisect-runner.pl was hitting some condition that drove it in a previously unseen (to me, at least) direction. It went looking for ext/DB_File/DB_File.xs. But that file was moved to cpan/ many years ago.

commit 1299eb144ab48940fecb7865750908c77577bfd5
Author:     Nicholas Clark <nick@ccl4.org>
AuthorDate: Thu Sep 24 10:51:41 2009 +0100
Commit:     Nicholas Clark <nick@ccl4.org>
CommitDate: Thu Sep 24 10:51:41 2009 +0100

    Move DB_File from ext/ to cpan/

So Porting/bisect-runner.pl (and probably its companion) need to have a whole lot of old code tossed out.

Thank you very much.
Jim Keenan

[Leont]

Right above that extract_from_file line there's an if ($major < 10), with major being PERL_VERSION as extracted from patchlevel.h.

So it's really the same bug as XS code has with the bump to 7.0, with the same solution.

[jkeenan]

Right above that extract_from_file line there's an if ($major < 10), with major being PERL_VERSION as extracted from patchlevel.h.

So it's really the same bug as XS code has with the bump to 7.0, with the same solution.

So, is that to say that the code in Porting/bisect-runner.pl that refers to ext/DB_File/DB_File.xs should remain in place (because it's needed when the bisection is running through very old commit)?

[jkeenan]

Right above that extract_from_file line there's an if ($major < 10), with major being PERL_VERSION as extracted from patchlevel.h.
So it's really the same bug as XS code has with the bump to 7.0, with the same solution.

So, is that to say that the code in Porting/bisect-runner.pl that refers to ext/DB_File/DB_File.xs should remain in place (because it's needed when the bisection is running through very old commit)?

@Leont or @nwc10, could you take a look at my question above?

Thanks.
jimk