Skip to content

Commit d58f204

Browse files
committed
PathTools: check Config values early before chdir
In a perl core build, the @inc paths will be relative. If you change directories before loading all of the files needed, they won't be able to be found. Config.pm loads some of its values at runtime, so if they are accessed after a chdir, it may fail. One of the PathTools tests was relying on the fact that Config_heavy.pl would be loaded by Test::More, before it did a chdir. Newer Test::More won't do that, so the test would fail. Accessing the required Config values early will prevent this failure. This same issue is unlikely to impact anything outside core, as it requires the perl core paths in @inc to be relative paths, which is normally not the case.
1 parent 801e9c3 commit d58f204

File tree

12 files changed

+15
-13
lines changed

12 files changed

+15
-13
lines changed

dist/PathTools/Cwd.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use strict;
33
use Exporter;
44

55

6-
our $VERSION = '3.92';
6+
our $VERSION = '3.94';
77
my $xs_version = $VERSION;
88
$VERSION =~ tr/_//d;
99

dist/PathTools/lib/File/Spec.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use strict;
44

55
# Keep $VERSION consistent in all *.pm files in this distribution, including
66
# Cwd.pm.
7-
our $VERSION = '3.93';
7+
our $VERSION = '3.94';
88
$VERSION =~ tr/_//d;
99

1010
my %module = (

dist/PathTools/lib/File/Spec/AmigaOS.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package File::Spec::AmigaOS;
33
use strict;
44
require File::Spec::Unix;
55

6-
our $VERSION = '3.93';
6+
our $VERSION = '3.94';
77
$VERSION =~ tr/_//d;
88

99
our @ISA = qw(File::Spec::Unix);

dist/PathTools/lib/File/Spec/Cygwin.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package File::Spec::Cygwin;
33
use strict;
44
require File::Spec::Unix;
55

6-
our $VERSION = '3.93';
6+
our $VERSION = '3.94';
77
$VERSION =~ tr/_//d;
88

99
our @ISA = qw(File::Spec::Unix);

dist/PathTools/lib/File/Spec/Epoc.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package File::Spec::Epoc;
22

33
use strict;
44

5-
our $VERSION = '3.93';
5+
our $VERSION = '3.94';
66
$VERSION =~ tr/_//d;
77

88
require File::Spec::Unix;

dist/PathTools/lib/File/Spec/Functions.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package File::Spec::Functions;
33
use File::Spec;
44
use strict;
55

6-
our $VERSION = '3.93';
6+
our $VERSION = '3.94';
77
$VERSION =~ tr/_//d;
88

99
require Exporter;

dist/PathTools/lib/File/Spec/Mac.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use strict;
44
use Cwd ();
55
require File::Spec::Unix;
66

7-
our $VERSION = '3.93';
7+
our $VERSION = '3.94';
88
$VERSION =~ tr/_//d;
99

1010
our @ISA = qw(File::Spec::Unix);

dist/PathTools/lib/File/Spec/OS2.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use strict;
44
use Cwd ();
55
require File::Spec::Unix;
66

7-
our $VERSION = '3.93';
7+
our $VERSION = '3.94';
88
$VERSION =~ tr/_//d;
99

1010
our @ISA = qw(File::Spec::Unix);

dist/PathTools/lib/File/Spec/Unix.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package File::Spec::Unix;
33
use strict;
44
use Cwd ();
55

6-
our $VERSION = '3.93';
6+
our $VERSION = '3.94';
77
$VERSION =~ tr/_//d;
88

99
=head1 NAME

dist/PathTools/lib/File/Spec/VMS.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use strict;
44
use Cwd ();
55
require File::Spec::Unix;
66

7-
our $VERSION = '3.93';
7+
our $VERSION = '3.94';
88
$VERSION =~ tr/_//d;
99

1010
our @ISA = qw(File::Spec::Unix);

0 commit comments

Comments
 (0)