ExtUtils::ParseXS: remove XsubAlias field

This was a typo: the code should have been checking if the
XsubAlias*es* field was defined, in order to remove a duplicate copy of
the XSUB function name from an alias warning message.

Author: iabyn

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm

@@ -331,8 +331,6 @@ BEGIN {
   'XsubAliasValues',     # Hash of hash of bools: indicates which alias
                          # names have been used for each value.
   'XsubAliasValueClashHinted', # Bool: an ALIAS warning-hint has been emitted.
-  'XsubAlias',           # XXX this field is almost certainly a typo
-                         # for XsubAliases.
 
 
   # Per-XSUB INPUT section parsing state:
@@ -2573,10 +2571,10 @@ sub get_aliases {
     # it is NOT a mistake.
     unless ($is_symbolic) {
       my @keys= sort keys %{$self->{XsubAliasValues}->{$value}||{}};
-      # deal with an alias of 0, which might not be in the XsubAlias dataset
-      # yet as 0 is the default for the base function ($fname)
+      # deal with an alias of 0, which might not be in the XsubAliases
+      # dataset yet as 0 is the default for the base function ($fname)
       push @keys, $fname
-        if $value eq "0" and !defined $self->{XsubAlias}{$fname};
+        if $value eq "0" and !defined $self->{XsubAliases}{$fname};
       if (@keys and $self->{author_warnings}) {
         # We do not warn about value collisions unless author_warnings
         # are enabled. They aren't helpful to a module consumer, only

dist/ExtUtils-ParseXS/t/001-basic.t

@@ -266,7 +266,7 @@ like $stderr, '/No INPUT definition/', "Exercise typemap error";
     . " of 0 - the base function in XSAlias.xs, line 13\n"
     . "Warning: Aliases 'do' and 'xunx', 'do' have identical values"
     . " of 0 - the base function in XSAlias.xs, line 14\n"
-    . "Warning: Aliases 'xunx2' and 'do', 'xunx', 'do' have"
+    . "Warning: Aliases 'xunx2' and 'do', 'xunx' have"
     . " identical values of 0 - the base function in XSAlias.xs, line 15\n"
     ,
     "Saw expected warnings from XSAlias.xs in AUTHOR_WARNINGS mode";