Skip to content

Commit 3caa23e

Browse files
committed
Data-Dumper: fix bugs.t for non-XS testing
This is a follow-up to 7d3a730, which fixed an out-of-bounds write in Dumpxs when passed invalid UTF-8. This test does not apply to the pure Perl implementation (which detects the invalid input and cleanly throws an error instead). Previously, testing without XS available would result in: t/bugs.t ...................... 1/24 Malformed UTF-8 character (fatal) at .../dist/Data-Dumper/blib/lib/Data/Dumper.pm line 587. # Looks like your test exited with 2 just after 6. t/bugs.t ...................... Dubious, test returned 2 (wstat 512, 0x200) Failed 18/24 subtests ... t/bugs.t (Wstat: 512 (exited 2) Tests: 6 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 24 tests but ran 6.
1 parent c135673 commit 3caa23e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

dist/Data-Dumper/t/bugs.t

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ SKIP: {
8383

8484
# writing out of bounds with malformed utf8
8585
SKIP: {
86+
skip("No XS available", 1) if !defined &Data::Dumper::Dumpxs;
8687
eval { require Encode };
8788
skip("Encode not available", 1) if $@;
8889
local $^W=1;

0 commit comments

Comments
 (0)