Skip to content

Commit b4210bb

Browse files
committed
Remove app insights aad auth
1 parent 6b23711 commit b4210bb

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

code/function/fastapp/utils.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import logging
22
from logging import Logger
33

4-
from azure.identity import ManagedIdentityCredential
4+
# from azure.identity import ManagedIdentityCredential
55
from azure.monitor.opentelemetry.exporter import AzureMonitorTraceExporter
66
from fastapi import FastAPI
77
from fastapp.core.config import settings
@@ -36,9 +36,10 @@ def setup_tracer(app: FastAPI):
3636
RETURNS (None): Nothing is being returned.
3737
"""
3838
if settings.APPLICATIONINSIGHTS_CONNECTION_STRING:
39-
credential = ManagedIdentityCredential()
39+
# credential = ManagedIdentityCredential()
4040
exporter = AzureMonitorTraceExporter.from_connection_string(
41-
settings.APPLICATIONINSIGHTS_CONNECTION_STRING, credential=credential
41+
settings.APPLICATIONINSIGHTS_CONNECTION_STRING,
42+
# credential=credential
4243
)
4344
tracer = TracerProvider(resource=Resource({SERVICE_NAME: "api"}))
4445
tracer.add_span_processor(BatchSpanProcessor(exporter))

code/function/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# The Python Worker is managed by Azure Functions platform
33
# Manually managing azure-functions-worker may cause unexpected issues
44

5-
azure-identity~=1.13.0
5+
# azure-identity~=1.13.0
66
azure-functions~=1.14.0
77
fastapi~=0.96.1
88
aiohttp~=3.8.4

code/infra/logging.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ resource "azurerm_application_insights" "application_insights" {
1010
force_customer_storage_for_profiler = false
1111
internet_ingestion_enabled = true
1212
internet_query_enabled = true
13-
local_authentication_disabled = true
13+
local_authentication_disabled = false
1414
retention_in_days = 90
1515
sampling_percentage = 100
1616
workspace_id = azurerm_log_analytics_workspace.log_analytics_workspace.id

code/infra/roleassignments.tf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ resource "azurerm_role_assignment" "function_role_assignment_key_vault" {
1010
principal_id = azapi_resource.function.identity[0].principal_id
1111
}
1212

13-
resource "azurerm_role_assignment" "function_role_assignment_application_insights" {
14-
scope = azurerm_application_insights.application_insights.id
15-
role_definition_name = "Monitoring Metrics Publisher"
16-
principal_id = azapi_resource.function.identity[0].principal_id
17-
}
13+
# resource "azurerm_role_assignment" "function_role_assignment_application_insights" {
14+
# scope = azurerm_application_insights.application_insights.id
15+
# role_definition_name = "Monitoring Metrics Publisher"
16+
# principal_id = azapi_resource.function.identity[0].principal_id
17+
# }

0 commit comments

Comments
 (0)