Skip to content

Commit 95527ba

Browse files
Various V2 updates and fixes (#1421)
This pull request updates the deployment workflow configuration in `.github/workflows/v2-deploy-pr.yml`. The changes focus on improving the logic for determining pull request identifiers and updating the deployment environment. Workflow logic updates: * Replaced the condition for checking `updated_demos` with a condition for checking `pr_id` to ensure accurate identification of pull requests. (`[.github/workflows/v2-deploy-pr.ymlL83-R88](diffhunk://#diff-bb1f887f50cfc7839e56ce823ccf5b9b7a4a07bfd475c5646b28105610511bf3L83-R88)`) Environment configuration changes: * Updated the deployment environment from `'swc-dev'` to `'swc-staging'` to align with staging requirements. (`[.github/workflows/v2-deploy-pr.ymlL83-R88](diffhunk://#diff-bb1f887f50cfc7839e56ce823ccf5b9b7a4a07bfd475c5646b28105610511bf3L83-R88)`) --------- Co-authored-by: Paul Finlay <50180049+doctorperceptron@users.noreply.github.com>
1 parent 74ea55b commit 95527ba

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/v2-deploy-pr.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,13 @@ jobs:
8080
github.event.workflow_run.event == 'pull_request' &&
8181
needs.prepare-build-context.result == 'success' &&
8282
needs.prepare-build-context.outputs.pr_ref != '' &&
83+
needs.prepare-build-context.outputs.pr_id != '' &&
8384
needs.prepare-build-context.outputs.updated_demos != '[]'
8485
uses: ./.github/workflows/v2-deploy-demos.yml
8586
needs: prepare-build-context
8687
with:
8788
# TODO: Update SWC environment to "swc-prod"
88-
environment: 'swc-dev'
89+
environment: 'swc-staging'
8990
artifact-name: demo-build-${{ needs.prepare-build-context.outputs.pr_ref }}
9091
workflow-run-id: ${{ github.event.workflow_run.id }}
9192
pr_number: ${{ fromJson(needs.prepare-build-context.outputs.pr_id) }}

0 commit comments

Comments
 (0)