Skip to content

Commit f4a78b3

Browse files
committed
Added compiler warnings when key member has a comparer and no equality comparer and vice versa.
1 parent e03e765 commit f4a78b3

File tree

38 files changed

+770
-157
lines changed

38 files changed

+770
-157
lines changed

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<Copyright>(c) $([System.DateTime]::Now.Year), Pawel Gerr. All rights reserved.</Copyright>
5-
<VersionPrefix>8.4.0</VersionPrefix>
5+
<VersionPrefix>8.4.1</VersionPrefix>
66
<Authors>Pawel Gerr</Authors>
77
<GenerateDocumentationFile>true</GenerateDocumentationFile>
88
<PackageProjectUrl>https://github.com/PawelGerr/Thinktecture.Runtime.Extensions</PackageProjectUrl>

samples/Thinktecture.Runtime.Extensions.Benchmarking/Database/Description.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ namespace Thinktecture.Database;
44

55
[ValueObject<string>]
66
[ValueObjectKeyMemberEqualityComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
7+
[ValueObjectKeyMemberComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
78
public partial class Description
89
{
910
static partial void ValidateFactoryArguments(ref ValidationError? validationError, ref string value)

samples/Thinktecture.Runtime.Extensions.Benchmarking/Database/DescriptionStruct.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ namespace Thinktecture.Database;
44

55
[ValueObject<string>]
66
[ValueObjectKeyMemberEqualityComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
7+
[ValueObjectKeyMemberComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
78
public partial struct DescriptionStruct
89
{
910
static partial void ValidateFactoryArguments(ref ValidationError? validationError, ref string value)

samples/Thinktecture.Runtime.Extensions.Benchmarking/Database/Name.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ namespace Thinktecture.Database;
44

55
[ValueObject<string>]
66
[ValueObjectKeyMemberEqualityComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
7+
[ValueObjectKeyMemberComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
78
public partial class Name
89
{
910
static partial void ValidateFactoryArguments(ref ValidationError? validationError, ref string value)

samples/Thinktecture.Runtime.Extensions.Benchmarking/Database/NameStruct.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ namespace Thinktecture.Database;
44

55
[ValueObject<string>]
66
[ValueObjectKeyMemberEqualityComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
7+
[ValueObjectKeyMemberComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
78
public partial struct NameStruct
89
{
910
static partial void ValidateFactoryArguments(ref ValidationError? validationError, ref string value)

samples/Thinktecture.Runtime.Extensions.MessagePack.Samples/ProductNameWithMessagePackFormatter.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ namespace Thinktecture;
44

55
[ValueObject<string>(NullInFactoryMethodsYieldsNull = true)]
66
[ValueObjectKeyMemberEqualityComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
7+
[ValueObjectKeyMemberComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
78
public partial class ProductNameWithMessagePackFormatter
89
{
910
static partial void ValidateFactoryArguments(ref ValidationError? validationError, ref string value)

samples/Thinktecture.Runtime.Extensions.Samples/Unions/Animal.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ public override string ToString()
2020

2121
[ValueObject<string>]
2222
[ValueObjectKeyMemberEqualityComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
23+
[ValueObjectKeyMemberComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
2324
public partial class Dog : Animal;
2425

2526
public sealed class Cat : Animal

samples/Thinktecture.Runtime.Extensions.Samples/ValueObjects/OtherProductName.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ namespace Thinktecture.ValueObjects;
44

55
[ValueObject<string>(EmptyStringInFactoryMethodsYieldsNull = true)]
66
[ValueObjectKeyMemberEqualityComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
7+
[ValueObjectKeyMemberComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
78
public partial class OtherProductName
89
{
910
static partial void ValidateFactoryArguments(ref ValidationError? validationError, ref string value)

samples/Thinktecture.Runtime.Extensions.Samples/ValueObjects/ProductName.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ namespace Thinktecture.ValueObjects;
44

55
[ValueObject<string>(NullInFactoryMethodsYieldsNull = true)]
66
[ValueObjectKeyMemberEqualityComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
7+
[ValueObjectKeyMemberComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
78
public partial class ProductName
89
{
910
static partial void ValidateFactoryArguments(ref ValidationError? validationError, ref string value)

samples/Thinktecture.Runtime.Extensions.Samples/ValueObjects/ProductNameStruct.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ namespace Thinktecture.ValueObjects;
44

55
[ValueObject<string>(DefaultInstancePropertyName = "None")]
66
[ValueObjectKeyMemberEqualityComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
7+
[ValueObjectKeyMemberComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
78
public partial struct ProductNameStruct
89
{
910
static partial void ValidateFactoryArguments(ref ValidationError? validationError, ref string value)

0 commit comments

Comments
 (0)