Skip to content

Commit d9f30d1

Browse files
committed
Removed EqualityComparisonOperators from ComplexValueObjectAttribute because it has no effect
1 parent 9ca71a6 commit d9f30d1

File tree

3 files changed

+1
-18
lines changed

3 files changed

+1
-18
lines changed
Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
using System.Numerics;
2-
31
namespace Thinktecture;
42

53
/// <summary>
@@ -8,12 +6,4 @@ namespace Thinktecture;
86
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Struct, Inherited = false)]
97
public sealed class ComplexValueObjectAttribute : ValueObjectAttributeBase
108
{
11-
/// <summary>
12-
/// Indication whether and how the generator should generate the implementation of <see cref="IEqualityOperators{TSelf,TOther,TResult}"/>.
13-
///
14-
/// This setting has no effect:
15-
/// - on non-keyed value objects (i.e. has more than 1 field/property)
16-
/// - if key-member is not an <see cref="IEqualityOperators{TSelf,TOther,TResult}"/> itself and has no corresponding operators (<c>op_Equality</c>, <c>op_Inequality</c>).
17-
/// </summary>
18-
public override OperatorsGeneration EqualityComparisonOperators { get; set; }
199
}

src/Thinktecture.Runtime.Extensions/ValueObjectAttribute.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public bool NullInFactoryMethodsYieldsNull
147147
/// This setting has no effect:
148148
/// - if key-member is not an <see cref="IEqualityOperators{TSelf,TOther,TResult}"/> itself and has no corresponding operators (<c>op_Equality</c>, <c>op_Inequality</c>).
149149
/// </summary>
150-
public override OperatorsGeneration EqualityComparisonOperators
150+
public OperatorsGeneration EqualityComparisonOperators
151151
{
152152
get => ComparisonOperators > _equalityComparisonOperators ? ComparisonOperators : _equalityComparisonOperators;
153153
set => _equalityComparisonOperators = value;

src/Thinktecture.Runtime.Extensions/ValueObjectAttributeBase.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
using System.Numerics;
2-
31
namespace Thinktecture;
42

53
/// <summary>
@@ -40,11 +38,6 @@ public string TryCreateFactoryMethodName
4038
set => _tryCreateFactoryMethodName = String.IsNullOrWhiteSpace(value) ? null : value.Trim();
4139
}
4240

43-
/// <summary>
44-
/// Indication whether and how the generator should generate the implementation of <see cref="IEqualityOperators{TSelf,TOther,TResult}"/>.
45-
/// </summary>
46-
public abstract OperatorsGeneration EqualityComparisonOperators { get; set; }
47-
4841
/// <summary>
4942
/// Indication whether the generator should skip the implementation of the method <see cref="object.ToString"/> or not.
5043
/// </summary>

0 commit comments

Comments
 (0)