Improved compiler warning message.

Author: PawelGerr

src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/Diagnostics/ThinktectureRuntimeExtensionsAnalyzer.cs

@@ -127,8 +127,7 @@ private static void MemberDisallowingDefaultValuesMustBeRequired(
       context.ReportDiagnostic(Diagnostic.Create(
                                   DiagnosticsDescriptors.MembersDisallowingDefaultValuesMustBeRequired,
                                   context.Node.GetLocation(),
-                                  memberKind,
-                                  memberName));
+                                  memberKind, memberName, BuildTypeName(memberType)));
    }
 
    private static void AnalyzeMethodWithUseDelegateFromConstructor(OperationAnalysisContext context)

src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/DiagnosticsDescriptors.cs

@@ -48,5 +48,5 @@ internal static class DiagnosticsDescriptors
    public static readonly DiagnosticDescriptor StaticPropertiesAreNotConsideredItems = new("TTRESG101", "Static properties are not considered enumeration items, use a field instead", "The static property '{0}' is not considered a enumeration item, use a field instead", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);
    public static readonly DiagnosticDescriptor ExplicitComparerWithoutEqualityComparer = new("TTRESG102", "The type has a comparer defined but no equality comparer", "The type '{0}' has a comparer defined but no equality comparer", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);
    public static readonly DiagnosticDescriptor ExplicitEqualityComparerWithoutComparer = new("TTRESG103", "The type has an equality comparer defined but no comparer", "The type '{0}' has an equality comparer defined but no comparer", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);
-   public static readonly DiagnosticDescriptor MembersDisallowingDefaultValuesMustBeRequired = new("TTRESG104", "The member must be marked as 'required' to ensure proper initialization", "The {0} '{1}' must be marked as 'required' to ensure proper initialization", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);
+   public static readonly DiagnosticDescriptor MembersDisallowingDefaultValuesMustBeRequired = new("TTRESG104", "The member must be marked as 'required' to ensure proper initialization", "The {0} '{1}' of type '{2}' must be marked as 'required' to ensure proper initialization", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);
 }

test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/AnalyzerAndCodeFixTests/TTRESG104_MembersDisallowingDefaultValuesMustBeRequired.cs

@@ -10,16 +10,19 @@ public class TTRESG104_MembersDisallowingDefaultValuesMustBeRequired
    private const string _DIAGNOSTIC_ID = "TTRESG104";
 
    [Theory]
-   [InlineData("field", "IntBasedStructValueObjectDoesNotAllowDefaultStructs Member;")]                          // field: non-readonly VO
-   [InlineData("field", "StructStringEnum Member;")]                                                             // field: non-readonly SE
-   [InlineData("field", "TestUnion_struct_string_int Member;")]                                                  // field: non-readonly DU
-   [InlineData("property", "StructStringEnum Member { get; set; }")]                                             // property: non-readonly SE
-   [InlineData("property", "IntBasedStructValueObjectDoesNotAllowDefaultStructs Member { get; set; }")]          // property: non-readonly VO
-   [InlineData("property", "TestUnion_struct_string_int Member { get; set; }")]                                  // property: non-readonly VO
-   [InlineData("property", "IntBasedStructValueObjectDoesNotAllowDefaultStructs Member { get; init; }")]         // property: non-readonly with init
-   [InlineData("property", "IntBasedStructValueObjectDoesNotAllowDefaultStructs Member { set { } }")]            // property: setter only
-   [InlineData("property", "abstract IntBasedStructValueObjectDoesNotAllowDefaultStructs Member { get; set; }")] // property: setter only
-   public async Task Should_trigger_on_members(string memberKind, string member)
+   [InlineData("field", "IntBasedStructValueObjectDoesNotAllowDefaultStructs", "IntBasedStructValueObjectDoesNotAllowDefaultStructs Member;")]                          // field: non-readonly VO
+   [InlineData("field", "StructStringEnum", "StructStringEnum Member;")]                                                                                                // field: non-readonly SE
+   [InlineData("field", "TestUnion_struct_string_int", "TestUnion_struct_string_int Member;")]                                                                          // field: non-readonly DU
+   [InlineData("property", "StructStringEnum", "StructStringEnum Member { get; set; }")]                                                                                // property: non-readonly SE
+   [InlineData("property", "IntBasedStructValueObjectDoesNotAllowDefaultStructs", "IntBasedStructValueObjectDoesNotAllowDefaultStructs Member { get; set; }")]          // property: non-readonly VO
+   [InlineData("property", "TestUnion_struct_string_int", "TestUnion_struct_string_int Member { get; set; }")]                                                          // property: non-readonly VO
+   [InlineData("property", "IntBasedStructValueObjectDoesNotAllowDefaultStructs", "IntBasedStructValueObjectDoesNotAllowDefaultStructs Member { get; init; }")]         // property: non-readonly with init
+   [InlineData("property", "IntBasedStructValueObjectDoesNotAllowDefaultStructs", "IntBasedStructValueObjectDoesNotAllowDefaultStructs Member { set { } }")]            // property: setter only
+   [InlineData("property", "IntBasedStructValueObjectDoesNotAllowDefaultStructs", "abstract IntBasedStructValueObjectDoesNotAllowDefaultStructs Member { get; set; }")] // property: abstract
+   public async Task Should_trigger_on_members(
+      string memberKind,
+      string memberType,
+      string member)
    {
       var typeModifer = member.Contains("abstract") ? "abstract " : null;
 
@@ -61,7 +64,7 @@ namespace TestNamespace
          }
          """;
 
-      var expected = Verifier.Diagnostic(_DIAGNOSTIC_ID).WithLocation(0).WithArguments(memberKind, "Member");
+      var expected = Verifier.Diagnostic(_DIAGNOSTIC_ID).WithLocation(0).WithArguments(memberKind, "Member", memberType);
       await Verifier.VerifyCodeFixAsync(code, expectedCode, [typeof(ValueObjectAttribute<>).Assembly, typeof(IntBasedStructValueObjectDoesNotAllowDefaultStructs).Assembly], expected);
    }