Fixed analysis of Switch/Map with context.

Author: PawelGerr

src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/Diagnostics/ThinktectureRuntimeExtensionsAnalyzer.cs

@@ -60,7 +60,6 @@ private static void AnalyzeMethodCall(OperationAnalysisContext context)
 
       if (operation.Instance is null
           || operation.Arguments.IsDefaultOrEmpty
-          || operation.Arguments.Length % 2 != 0
           || operation.TargetMethod.IsStatic
           || (operation.TargetMethod.Name != "Switch" && operation.TargetMethod.Name != "Map"))
       {
@@ -74,18 +73,19 @@ private static void AnalyzeMethodCall(OperationAnalysisContext context)
 
       var nonIgnoredMembers = operation.Instance.Type.GetNonIgnoredMembers();
       var items = operation.Instance.Type.GetEnumItems(nonIgnoredMembers);
+      var argsIndex = operation.TargetMethod.Parameters.Length % 2;
+      var args = operation.Arguments;
 
       for (var itemIndex = 0; itemIndex < items.Length; itemIndex++)
       {
          var item = items[itemIndex];
-         var args = operation.Arguments;
 
          if (args.IsDefaultOrEmpty)
             continue;
 
          var found = false;
 
-         for (var argIndex = 0; argIndex < args.Length; argIndex += 2)
+         for (var argIndex = argsIndex; argIndex < args.Length; argIndex += 2)
          {
             var argument = args[argIndex];
 

test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/AnalyzerAndCodeFixTests/TTRESG039_SwitchMustCoverAllItems.cs

@@ -37,6 +37,35 @@ public void Do()
       await Verifier.VerifyAnalyzerAsync(code, new[] { typeof(ComplexValueObjectAttribute).Assembly, typeof(TestEnum).Assembly }, expected);
    }
 
+   [Fact]
+   public async Task Should_trigger_on_Switch_missing_items_having_action_with_context()
+   {
+      var code = """
+
+                 using System;
+                 using Thinktecture;
+                 using Thinktecture.Runtime.Tests.TestEnums;
+
+                 namespace TestNamespace
+                 {
+                    public class Test
+                    {
+                       public void Do()
+                       {
+                          var testEnum = TestEnum.Item1;
+
+                          {|#0:testEnum.Switch(42,
+                                             TestEnum.Item1, value => {},
+                                             TestEnum.Item1, value => {})|};
+                       }
+                    }
+                 }
+                 """;
+
+      var expected = Verifier.Diagnostic(_DIAGNOSTIC_ID).WithLocation(0).WithArguments("TestEnum", "Item2");
+      await Verifier.VerifyAnalyzerAsync(code, new[] { typeof(ComplexValueObjectAttribute).Assembly, typeof(TestEnum).Assembly }, expected);
+   }
+
    [Fact]
    public async Task Should_not_trigger_on_Switch_when_all_items_are_covered_having_action()
    {