"Lookups" can be readonly

PawelGerr · PawelGerr · commit 2a7f54bbc263 · 2024-12-18T20:00:11.000+01:00
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/SmartEnumCodeGenerator.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/SmartEnumCodeGenerator.cs
@@ -1219,7 +1219,7 @@ void AddItem(").AppendTypeFullyQualified(_state).Append(@" item, string itemName
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<").AppendTypeFullyQualified(keyMember).Append(", ").AppendTypeFullyQualified(_state).Append("> Lookup,");
 
       if (keyMember.IsString())
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_advanced_string_based_validatable_class_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_advanced_string_based_validatable_class_0.verified.cs
@@ -738,7 +738,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_class_with_abstract_property_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_class_with_abstract_property_0.verified.cs
@@ -385,7 +385,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_int_based_class_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_int_based_class_0.verified.cs
@@ -310,7 +310,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<int, global::Thinktecture.Tests.TestEnum> Lookup,
          global::System.Collections.Generic.IReadOnlyList<global::Thinktecture.Tests.TestEnum> List);
    }
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_int_based_class_with_ComparisonOperators_DefaultWithKeyTypeOverloads_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_int_based_class_with_ComparisonOperators_DefaultWithKeyTypeOverloads_0.verified.cs
@@ -310,7 +310,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<int, global::Thinktecture.Tests.TestEnum> Lookup,
          global::System.Collections.Generic.IReadOnlyList<global::Thinktecture.Tests.TestEnum> List);
    }
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_int_based_class_with_ValueObjectFactoryAttribute_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_int_based_class_with_ValueObjectFactoryAttribute_0.verified.cs
@@ -482,7 +482,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<int, global::Thinktecture.Tests.TestEnum> Lookup,
          global::System.Collections.Generic.IReadOnlyList<global::Thinktecture.Tests.TestEnum> List);
    }
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_int_based_class_with_ValueObjectFactoryAttribute_and_UseForSerialization_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_int_based_class_with_ValueObjectFactoryAttribute_and_UseForSerialization_0.verified.cs
@@ -483,7 +483,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<int, global::Thinktecture.Tests.TestEnum> Lookup,
          global::System.Collections.Generic.IReadOnlyList<global::Thinktecture.Tests.TestEnum> List);
    }
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_0.verified.cs
@@ -385,7 +385,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_having_ValueObjectValidationErrorAttribute_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_having_ValueObjectValidationErrorAttribute_0.verified.cs
@@ -556,7 +556,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_with_base_class_and_non_default_constructors_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_with_base_class_and_non_default_constructors_0.verified.cs
@@ -590,7 +590,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_with_inner_derived_type_which_is_generic_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_with_inner_derived_type_which_is_generic_0.verified.cs
@@ -856,7 +856,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_without_Map_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_without_Map_0.verified.cs
@@ -500,7 +500,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_without_Switch_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_without_Switch_0.verified.cs
@@ -320,7 +320,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_without_namespace_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_class_without_namespace_0.verified.cs
@@ -554,7 +554,7 @@ void AddItem(global::TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_validatable_class_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_validatable_class_0.verified.cs
@@ -710,7 +710,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_validatable_struct_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_generate_string_based_validatable_struct_0.verified.cs
@@ -695,7 +695,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_take_over_nullability_of_generic_members_0.verified.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/Snapshots/EnumSourceGeneratorTests.Should_take_over_nullability_of_generic_members_0.verified.cs
@@ -389,7 +389,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)
 #endif
       }
 
-      private record struct Lookups(
+      private readonly record struct Lookups(
          global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,
 #if NET9_0_OR_GREATER
          global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,

Original file line number	Diff line number	Diff line change
`@@ -1219,7 +1219,7 @@ void AddItem(").AppendTypeFullyQualified(_state).Append(@" item, string itemName`
`1219`	`1219`	`#endif`
`1220`	`1220`	`}`
`1221`	`1221`
`1222`		`- private record struct Lookups(`
	`1222`	`+ private readonly record struct Lookups(`
`1223`	`1223`	`global::System.Collections.Generic.IReadOnlyDictionary<").AppendTypeFullyQualified(keyMember).Append(", ").AppendTypeFullyQualified(_state).Append("> Lookup,");`
`1224`	`1224`
`1225`	`1225`	`if (keyMember.IsString())`
Original file line number	Diff line number	Diff line change
`@@ -738,7 +738,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)`
`738`	`738`	`#endif`
`739`	`739`	`}`
`740`	`740`
`741`		`- private record struct Lookups(`
	`741`	`+ private readonly record struct Lookups(`
`742`	`742`	`global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,`
`743`	`743`	`#if NET9_0_OR_GREATER`
`744`	`744`	`global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,`
Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)`
`385`	`385`	`#endif`
`386`	`386`	`}`
`387`	`387`
`388`		`- private record struct Lookups(`
	`388`	`+ private readonly record struct Lookups(`
`389`	`389`	`global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,`
`390`	`390`	`#if NET9_0_OR_GREATER`
`391`	`391`	`global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,`
Original file line number	Diff line number	Diff line change
`@@ -310,7 +310,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)`
`310`	`310`	`#endif`
`311`	`311`	`}`
`312`	`312`
`313`		`- private record struct Lookups(`
	`313`	`+ private readonly record struct Lookups(`
`314`	`314`	`global::System.Collections.Generic.IReadOnlyDictionary<int, global::Thinktecture.Tests.TestEnum> Lookup,`
`315`	`315`	`global::System.Collections.Generic.IReadOnlyList<global::Thinktecture.Tests.TestEnum> List);`
`316`	`316`	`}`
Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)`
`482`	`482`	`#endif`
`483`	`483`	`}`
`484`	`484`
`485`		`- private record struct Lookups(`
	`485`	`+ private readonly record struct Lookups(`
`486`	`486`	`global::System.Collections.Generic.IReadOnlyDictionary<int, global::Thinktecture.Tests.TestEnum> Lookup,`
`487`	`487`	`global::System.Collections.Generic.IReadOnlyList<global::Thinktecture.Tests.TestEnum> List);`
`488`	`488`	`}`
Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)`
`483`	`483`	`#endif`
`484`	`484`	`}`
`485`	`485`
`486`		`- private record struct Lookups(`
	`486`	`+ private readonly record struct Lookups(`
`487`	`487`	`global::System.Collections.Generic.IReadOnlyDictionary<int, global::Thinktecture.Tests.TestEnum> Lookup,`
`488`	`488`	`global::System.Collections.Generic.IReadOnlyList<global::Thinktecture.Tests.TestEnum> List);`
`489`	`489`	`}`
Original file line number	Diff line number	Diff line change
`@@ -556,7 +556,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)`
`556`	`556`	`#endif`
`557`	`557`	`}`
`558`	`558`
`559`		`- private record struct Lookups(`
	`559`	`+ private readonly record struct Lookups(`
`560`	`560`	`global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,`
`561`	`561`	`#if NET9_0_OR_GREATER`
`562`	`562`	`global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,`
Original file line number	Diff line number	Diff line change
`@@ -590,7 +590,7 @@ void AddItem(global::Thinktecture.Tests.TestEnum item, string itemName)`
`590`	`590`	`#endif`
`591`	`591`	`}`
`592`	`592`
`593`		`- private record struct Lookups(`
	`593`	`+ private readonly record struct Lookups(`
`594`	`594`	`global::System.Collections.Generic.IReadOnlyDictionary<string, global::Thinktecture.Tests.TestEnum> Lookup,`
`595`	`595`	`#if NET9_0_OR_GREATER`
`596`	`596`	`global::System.Collections.Frozen.FrozenDictionary<string, global::Thinktecture.Tests.TestEnum>.AlternateLookup<global::System.ReadOnlySpan<char>> AlternateLookup,`