Renamed GenerateDelegateAttribute to UseDelegateFromConstructorAttributes

Author: PawelGerr

docs

@@ -12,7 +12,7 @@ public partial class SalesCsvImporterType
    public int ArticleIdIndex { get; }
    public int VolumeIndex { get; }
 
-   [GenerateDelegate]
+   [UseDelegateFromConstructor]
    public partial DateTime GetDateTime(CsvReader csvReader);
 
    private static DateTime GetDateTimeForDaily(CsvReader csvReader)

samples/Thinktecture.Runtime.Extensions.Samples/SmartEnums/SalesCsvImporterType.cs

@@ -218,7 +218,7 @@ public override int GetHashCode()
       if (_state.KeyMember is not null && !_state.Settings.SkipToString)
          GenerateToString(_state.KeyMember);
 
-      GenerateDelegateMethods();
+      GenerateDelegatedMethods();
 
       var hasSaneNumberOfItems = _state.Items.Count < 1000;
 
@@ -266,7 +266,7 @@ public override int GetHashCode()
    }");
    }
 
-   private void GenerateDelegateMethods()
+   private void GenerateDelegatedMethods()
    {
       foreach (var method in _state.DelegateMethods)
       {

src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/SmartEnumCodeGenerator.cs

@@ -141,12 +141,12 @@ public static bool IsValueObjectMemberIgnoreAttribute(this ITypeSymbol? attribut
       return attributeType is { Name: "ValueObjectMemberIgnoreAttribute", ContainingNamespace: { Name: "Thinktecture", ContainingNamespace.IsGlobalNamespace: true } };
    }
 
-   public static bool IsGenerateDelegateAttribute(this ITypeSymbol? attributeType)
+   public static bool IsUseDelegateFromConstructorAttribute(this ITypeSymbol? attributeType)
    {
       if (attributeType is null || attributeType.TypeKind == TypeKind.Error)
          return false;
 
-      return attributeType is { Name: "GenerateDelegateAttribute", ContainingNamespace: { Name: "Thinktecture", ContainingNamespace.IsGlobalNamespace: true } };
+      return attributeType is { Name: "UseDelegateFromConstructorAttribute", ContainingNamespace: { Name: "Thinktecture", ContainingNamespace.IsGlobalNamespace: true } };
    }
 
    public static bool IsEnum(
@@ -690,10 +690,9 @@ public static IReadOnlyList<DelegateMethodState> GetDelegateMethods(
          if (!methodSymbol.IsPartialDefinition)
             continue;
 
-         var generateDelegateAttribute = methodSymbol.FindAttribute(a => a.IsGenerateDelegateAttribute());
-         ;
+         var useDelegateFromConstructorAttribute = methodSymbol.FindAttribute(a => a.IsUseDelegateFromConstructorAttribute());
 
-         if (generateDelegateAttribute == null)
+         if (useDelegateFromConstructorAttribute == null)
             continue;
 
          var methodName = methodSymbol.Name;

src/Thinktecture.Runtime.Extensions.SourceGenerator/Extensions/TypeSymbolExtensions.cs

@@ -1,7 +1,7 @@
 namespace Thinktecture;
 
 /// <summary>
-/// Marks a partial method in of a Smart Enum or keyed Value Object to be implemented through a delegate.
+/// Marks a partial method of a Smart Enum to be implemented through a delegate.
 /// The source generator will automatically generate a private delegate field and wire it up through the constructor.
 /// </summary>
 /// <example>
@@ -11,12 +11,12 @@ namespace Thinktecture;
 /// {
 ///     public static readonly ImporterType Default = new(ProcessDefault);
 ///
-///     [GenerateDelegate]
-///     public partial string Process(object input);
+///     [UseDelegateFromConstructor]
+///     public partial string Process(int input);
 ///
-///     private static string ProcessDefault(object input) => input.ToString();
+///     private static string ProcessDefault(int input) => input.ToString();
 /// }
 /// </code>
 /// </example>
 [AttributeUsage(AttributeTargets.Method, Inherited = false)]
-public sealed class GenerateDelegateAttribute : Attribute;
+public sealed class UseDelegateFromConstructorAttribute : Attribute;

src/Thinktecture.Runtime.Extensions/GenerateDelegateAttribute.cs renamed to src/Thinktecture.Runtime.Extensions/UseDelegateFromConstructorAttribute.cs

@@ -740,7 +740,7 @@ public abstract partial class TestEnum
                public static readonly TestEnum Item1 = null!;
                public static readonly TestEnum Item2 = null!;
 
-               [GenerateDelegate]
+               [UseDelegateFromConstructor]
                public partial Task<string?>? Method1(string? arg1);
             }
          }
@@ -769,7 +769,7 @@ public abstract partial class TestEnum
                public static readonly TestEnum Item1 = null!;
                public static readonly TestEnum Item2 = null!;
 
-               [GenerateDelegate]
+               [UseDelegateFromConstructor]
                protected partial int Method1();
             }
          }
@@ -798,7 +798,7 @@ public abstract partial class TestEnum
                public static readonly TestEnum Item1 = null!;
                public static readonly TestEnum Item2 = null!;
 
-               [GenerateDelegate]
+               [UseDelegateFromConstructor]
                partial void Method1(string arg1, int arg2);
             }
          }
@@ -827,7 +827,7 @@ public abstract partial class TestEnum
                public static readonly TestEnum Item1 = null!;
                public static readonly TestEnum Item2 = null!;
 
-               [GenerateDelegate]
+               [UseDelegateFromConstructor]
                internal partial void Method1();
             }
          }

test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/EnumSourceGeneratorTests.cs

@@ -6,6 +6,6 @@ public partial class TestEnumWithDelegateGeneration
    public static readonly TestEnumWithDelegateGeneration Item1 = new(1, s => $"{s} + 1");
    public static readonly TestEnumWithDelegateGeneration Item2 = new(2, s => $"{s} + 2");
 
-   [GenerateDelegate]
+   [UseDelegateFromConstructor]
    public partial string Foo(int bar);
 }