pure git package

[luctius]

I have a package which is not crates.io or any other index.
If I add it to liner.toml, I get the following error:

Error:
   0: Failed to fetch the latest versions of the configured packages.
   1: Failed to finish search for "dmodman".
   2: Not at least one line in search output for "dmodman".

Am I doing something wrong, or is a package like this not supported?

For reverence, I added this to liner.toml:

[packages.dmodman]
version = "0.3.0"
git = "https://github.com/dandels/dmodman.git"
branch="main"
rev = "54a02745a0a7e27488bd834c0885410036d64087"

[PaulDance]

Hi!

I haven't tested this exactly, but it seems very much like #27: git and path dependencies are still version checked while it has no chance of ever succeeding. This limitation was only there because things were kept dumb and simple. It has been changed since and should be available as part of 0.10.0 some time soon.

In the meantime however, you should be able to simply add skip-check = true to any such package, which will always pass the package onto cargo install that now performs a more complete version check. Does that work for you?

[luctius]

I added that to the config in liner.toml.
Edit: Just saw the update to 0.10.0, tried it to with the same results as below.

I now get a cargo error. It seems to me, --git <url> is not added to the cargo command.

 INFO  cargo_liner::cargo > Updating `dmodman`...
 INFO resolve: Resolving package: 'dmodman@^0.3.0'
 INFO Cloning with worktree::receiving pack: Enumerating objects → 321.0 objects
 INFO Cloning with worktree::receiving pack::read pack → 360.4kB
 INFO ℹCloning with worktree::receiving pack::create index file::indexing → done 321.0 objects in 0.05s (6.0K objects/s)
 INFO ℹCloning with worktree::receiving pack::create index file::decompressing → done 833.6kB in 0.05s (15.6MB/s)
 INFO ℹCloning with worktree::receiving pack::create index file::Resolving → done 321.0 objects in 0.05s (6.4K objects/s)
 INFO ℹCloning with worktree::receiving pack::create index file::Decoding → done 1.4MB in 0.05s (27.8MB/s)
 INFO ✓Cloning with worktree::receiving pack::create index file::writing index file → done 10.1kB in 0.00s (123.0MB/s)
 INFO ✓Cloning with worktree::receiving pack::create index file → done 321.0 objects in 0.10s (3.1K objects/s)
 INFO ℹCloning with worktree::receiving pack::read pack → done 480.4kB in 0.13s (3.7MB/s)
 INFO ℹCloning with worktree::receiving pack::checkout → done 94.0 files in 0.00s (74.8K files/s)
 INFO ℹCloning with worktree::receiving pack::writing → done 548.4kB in 0.00s (432.9MB/s)
 WARN Package does not specify repository, cargo-binstall cannot provide default pkg_url for it.
Please ask the upstream to provide it for target x86_64-unknown-linux-gnu.
 WARN Package does not specify repository, cargo-binstall cannot provide default pkg_url for it.
Please ask the upstream to provide it for target x86_64-unknown-linux-musl.
 WARN The package dmodman v0.3.0 will be installed from source (with cargo)
    Updating crates.io index
error: could not find `dmodman` in registry `crates-io` with version `=0.3.0`
ERROR Cargo errored! ExitStatus(unix_wait_status(25856))
ERROR Fatal error:
  × For crate dmodman: subprocess /home/cor/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/cargo install dmodman --version 0.3.0 errored with exit status: 101
  ╰─▶ subprocess /home/cor/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/cargo install dmodman --version 0.3.0 errored with exit status: 101

 INFO  cargo_liner        > Installation report:
┌─────────┬─────────────┬─────────────┬────────┐
│ Name    │ Old version │ New version │ Status │
├─────────┼─────────────┼─────────────┼────────┤
│ dmodman │ 0.3.0       │ ?           │ ✘      │
└─────────┴─────────────┴─────────────┴────────┘
Error: 
   0: Failed to install or update some of the configured packages.
   1: Failed to update "dmodman".
   2: Cargo process finished unsuccessfully: exit status: 70

Location:
   /home/cor/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/cargo-liner-0.9.0/src/cargo.rs:408

Note: This can happen for many reasons.
Suggestion: Read Cargo's output.

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

[PaulDance]

What is displayed if you add -vv (or more) to the command? This should help confirm what exactly is run. From what you show here however, it really looks like --git is already passed: there is a Git clone in there.

From the shown logs as well, it seems like you are using cargo-binstall. It is used by default whenever it is available. Can you try explicitly disabling it? You can do that either globally by setting [defaults.ship] binstall = "never" or locally by adding binstall = "never" to the concerned package's configuration entry.

What I suspect for now is that:

• --git is actually passed to cargo-binstall that starts performing as expected: INFO Cloning with worktree::receiving pack;
• but the package does not fully satisfy it: WARN Package does not specify repository, cargo-binstall cannot provide default pkg_url for it.;
• so it then defers to a regular cargo install: WARN The package dmodman v0.3.0 will be installed from source (with cargo);
• but it does not pass --git through: /home/cor/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/cargo install dmodman --version 0.3.0;
• so that fails because the package is not available there at the requested version: error: could not find dmodman in registry crates-io with version =0.3.0;

I don't know the tool very well, but it could simply be one of its bugs or limitations?

[luctius]

Bininstall was indeed the problem, that fixed it. Thanks!

[PaulDance]

Good, glad I could help!