Elemental Overload disables ailments from crits entirely

[jwfiredragon]

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

As of 3.25, as per the wiki, there's the following undocumented change:

Elemental Overload now also causes your Critical Strikes to not inherently inflict Ailments.

What is the behaviour in Path of Building?

PoB is incorrectly implementing this change as "critical strikes cannot inflict ailments". E.g. if you have 100% chance to ignite from supports/passives/etc, and then allocate EO, your chance to ignite from crits is still 0%.

The identically worded fire mastery "Critical Strikes do not inherently Ignite / 100% increased Damage with Hits against Ignited Enemies" is implemented correctly and does not disable ignites from crits.

How to reproduce the issue

1. Equip a fire skill
2. Add 100% ignite chance to custom modifiers
3. Allocate EO
4. Check calcs tab and click skill ignite chance breakdown
5. Chance to ignite from crits is 0%, instead of 100% as expected
6. (Incidentally, the combined ignite chance breakdown is incorrect, even though the final number in the main calcs panel is correct.)

PoB for PoE1 build code

https://pobb.in/a1YPCrpEH15O

Screenshots