Skip to content

Commit baa231a

Browse files
LocalIdentityLocalIdentity
andauthored
Fix calculation when using both Autoexertion and Echoes of Creation (#8006)
The More mods were being summed together before being multiplier. This also fixes the terrible breakdown names I previously used Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent a7c3b2f commit baa231a

File tree

5 files changed

+12
-9
lines changed

5 files changed

+12
-9
lines changed

src/Data/ModCache.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10484,8 +10484,8 @@ c["Skills Supported by Nightblade have 40% increased Effect of Elusive"]={{[1]={
1048410484
c["Skills Supported by Unleash have 30% increased Seal gain frequency"]={{[1]={flags=0,keywordFlags=0,name="SealGainFrequency",type="INC",value=30}},nil}
1048510485
c["Skills Supported by Unleash have 40% increased Seal gain frequency"]={{[1]={flags=0,keywordFlags=0,name="SealGainFrequency",type="INC",value=40}},nil}
1048610486
c["Skills Supported by Unleash have 50% increased Seal gain frequency"]={{[1]={flags=0,keywordFlags=0,name="SealGainFrequency",type="INC",value=50}},nil}
10487-
c["Skills deal 13% more Damage for each Warcry Exerting them"]={{[1]={flags=0,keywordFlags=0,name="ExertAverageIncrease",type="MORE",value=13}},nil}
10488-
c["Skills deal 15% more Damage for each Warcry Exerting them"]={{[1]={flags=0,keywordFlags=0,name="ExertAverageIncrease",type="MORE",value=15}},nil}
10487+
c["Skills deal 13% more Damage for each Warcry Exerting them"]={{[1]={flags=0,keywordFlags=0,name="EchoesExertAverageIncrease",type="MORE",value=13}},nil}
10488+
c["Skills deal 15% more Damage for each Warcry Exerting them"]={{[1]={flags=0,keywordFlags=0,name="EchoesExertAverageIncrease",type="MORE",value=15}},nil}
1048910489
c["Skills fire 2 additional Projectiles"]={{[1]={flags=0,keywordFlags=0,name="ProjectileCount",type="BASE",value=2}},nil}
1049010490
c["Skills fire 2 additional Projectiles during Effect"]={{[1]={[1]={type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="ProjectileCount",type="BASE",value=2}},nil}
1049110491
c["Skills fire 2 additional Projectiles if you've been Hit Recently"]={{[1]={[1]={type="Condition",var="BeenHitRecently"},flags=0,keywordFlags=0,name="ProjectileCount",type="BASE",value=2}},nil}

src/Data/Skills/sup_str.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4496,7 +4496,7 @@ skills["SupportOverexertion"] = {
44964496
mod("ExertIncrease", "INC", nil)
44974497
},
44984498
["support_overexertion_damage_+%_final_per_warcry_exerting_action"] = {
4499-
mod("ExertAverageIncrease", "MORE", nil)
4499+
mod("AutoexertionExertAverageIncrease", "MORE", nil)
45004500
},
45014501
},
45024502
qualityStats = {

src/Export/Skills/sup_str.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ local skills, mod, flag, skill = ...
632632
mod("ExertIncrease", "INC", nil)
633633
},
634634
["support_overexertion_damage_+%_final_per_warcry_exerting_action"] = {
635-
mod("ExertAverageIncrease", "MORE", nil)
635+
mod("AutoexertionExertAverageIncrease", "MORE", nil)
636636
},
637637
},
638638
#mods

src/Modules/CalcOffence.lua

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2585,20 +2585,23 @@ function calcs.offence(env, actor, activeSkill)
25852585
local incExertedAttacks = skillModList:Sum("INC", cfg, "ExertIncrease")
25862586
local moreExertedAttacks = skillModList:Sum("MORE", cfg, "ExertIncrease")
25872587
local moreExertedAttackDamage = skillModList:Sum("MORE", cfg, "ExertAttackIncrease")
2588-
local moreAverageExertedDamage = skillModList:Sum("MORE", cfg, "ExertAverageIncrease")
2588+
local autoExertionExertedDamage = skillModList:Sum("MORE", cfg, "AutoexertionExertAverageIncrease")
2589+
local echoesOfCreationExertedDamage = skillModList:Sum("MORE", cfg, "EchoesExertAverageIncrease")
25892590
if activeSkill.skillModList:Flag(nil, "Condition:WarcryMaxHit") then
25902591
skillModList:NewMod("Damage", "INC", incExertedAttacks, "Exerted Attacks")
25912592
skillModList:NewMod("Damage", "MORE", moreExertedAttacks, "Exerted Attacks")
25922593
skillModList:NewMod("Damage", "MORE", moreExertedAttackDamage, "Exerted Attack Damage", ModFlag.Attack)
2593-
skillModList:NewMod("Damage", "MORE", moreAverageExertedDamage * warcryCount, "# Warcry Exerting Damage")
2594+
skillModList:NewMod("Damage", "MORE", autoExertionExertedDamage * warcryCount, "Max Autoexertion Support")
2595+
skillModList:NewMod("Damage", "MORE", echoesOfCreationExertedDamage * warcryCount, "Max Echoes of Creation")
25942596
else
25952597
skillModList:NewMod("Damage", "INC", incExertedAttacks * globalOutput.ExertedAttackUptimeRatio / 100, "Uptime Scaled Exerted Attacks")
25962598
skillModList:NewMod("Damage", "MORE", moreExertedAttacks * globalOutput.ExertedAttackUptimeRatio / 100, "Uptime Scaled Exerted Attacks")
25972599
skillModList:NewMod("Damage", "MORE", moreExertedAttackDamage * globalOutput.ExertedAttackUptimeRatio / 100, "Uptime Scaled Exerted Attack Damage", ModFlag.Attack)
2598-
skillModList:NewMod("Damage", "MORE", moreAverageExertedDamage * globalOutput.GlobalWarcryUptimeRatio / 100, "Uptime Scaled # Warcry Exerting Damage")
2600+
skillModList:NewMod("Damage", "MORE", autoExertionExertedDamage * globalOutput.GlobalWarcryUptimeRatio / 100, "Uptime Scaled Autoexertion Support")
2601+
skillModList:NewMod("Damage", "MORE", echoesOfCreationExertedDamage * globalOutput.GlobalWarcryUptimeRatio / 100, "Uptime Scaled Echoes of Creation")
25992602
end
26002603
globalOutput.ExertedAttackAvgDmg = calcLib.mod(skillModList, skillCfg, "ExertIncrease")
2601-
globalOutput.ExertedAttackAvgDmg = globalOutput.ExertedAttackAvgDmg * calcLib.mod(skillModList, skillCfg, "ExertAttackIncrease", "ExertAverageIncrease")
2604+
globalOutput.ExertedAttackAvgDmg = globalOutput.ExertedAttackAvgDmg * calcLib.mod(skillModList, skillCfg, "ExertAttackIncrease", "AutoexertionExertAverageIncrease", "EchoesExertAverageIncrease")
26022605
globalOutput.ExertedAttackHitEffect = globalOutput.ExertedAttackAvgDmg * globalOutput.ExertedAttackUptimeRatio / 100
26032606
globalOutput.ExertedAttackMaxHitEffect = globalOutput.ExertedAttackAvgDmg
26042607
if globalBreakdown then

src/Modules/ModParser.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4569,7 +4569,7 @@ local specialModList = {
45694569
["cannot recover energy shield to above evasion rating"] = { flag("EvasionESRecoveryCap") },
45704570
["warcries exert (%d+) additional attacks?"] = function(num) return { mod("ExtraExertedAttacks", "BASE", num) } end,
45714571
["warcries have (%d+)%% chance to exert (%d+) additional attacks?"] = function(num, _, var) return { mod("ExtraExertedAttacks", "BASE", (num*var/100)) } end,
4572-
["skills deal (%d+)%% more damage for each warcry exerting them"] = function(num) return { mod("ExertAverageIncrease", "MORE", num, nil) } end,
4572+
["skills deal (%d+)%% more damage for each warcry exerting them"] = function(num) return { mod("EchoesExertAverageIncrease", "MORE", num, nil) } end,
45734573
["iron will"] = { flag("IronWill") },
45744574
["iron reflexes while stationary"] = { mod("Keystone", "LIST", "Iron Reflexes", { type = "Condition", var = "Stationary" }) },
45754575
["you have iron reflexes while at maximum frenzy charges"] = { mod("Keystone", "LIST", "Iron Reflexes", { type = "StatThreshold", stat = "FrenzyCharges", thresholdStat = "FrenzyChargesMax" }) },

0 commit comments

Comments
 (0)