Skip to content

Commit a831fb7

Browse files
authored
FIX: add a toggle for dom blow base skill count (#8574)
The Dominating Blow skill has a simillar issue to the Absolution skill where increasing count increases not only the "minion count" but also applies a multiplier on the base skill damage. This commit essentially copies #4653 and applies it to Dominating Blow.
1 parent f0a1ce2 commit a831fb7

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/Modules/Calcs.lua

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,9 @@ function calcs.calcFullDPS(build, mode, override, specEnv)
236236
if usedEnv.minion.output.CullMultiplier and usedEnv.minion.output.CullMultiplier > 1 and usedEnv.minion.output.CullMultiplier > fullDPS.cullingMulti then
237237
fullDPS.cullingMulti = usedEnv.minion.output.CullMultiplier
238238
end
239-
-- This is a fix to prevent Absolution spell hit from being counted multiple times when increasing minions count
240-
if activeSkill.activeEffect.grantedEffect.name == "Absolution" and fullEnv.modDB:Flag(false, "Condition:AbsolutionSkillDamageCountedOnce") then
239+
-- This is a fix to prevent skills such as Absolution or Dominating Blow from being counted multiple times when increasing minions count
240+
if (activeSkill.activeEffect.grantedEffect.name == "Absolution" and fullEnv.modDB:Flag(false, "Condition:AbsolutionSkillDamageCountedOnce"))
241+
or (activeSkill.activeEffect.grantedEffect.name == "Dominating Blow" and fullEnv.modDB:Flag(false, "Condition:DominatingBlowSkillDamageCountedOnce")) then
241242
activeSkillCount = 1
242243
activeSkill.infoMessage2 = "Skill Damage"
243244
end

src/Modules/ConfigOptions.lua

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -662,6 +662,9 @@ return {
662662
{ var = "absolutionSkillDamageCountedOnce", type = "check", label = "Absolution: Count skill damage once", ifSkill = "Absolution", includeTransfigured = true, tooltip = "Your Absolution Skill Damage will not be scaled with Count setting.\nBy default it multiplies both minion count and skill hit count which leads to incorrect\nTotal DPS calculation since Absolution cannot inherently shotgun.\nDo not enable if you use Spell Totem support, Spell Cascade support or similar supports", apply = function(val, modList, enemyModList)
663663
modList:NewMod("Condition:AbsolutionSkillDamageCountedOnce", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
664664
end },
665+
{ var = "dominatingBlowSkillDamageCountedOnce", type = "check", label = "Dom. Blow: Count skill damage once", ifSkill = "Dominating Blow", tooltip = "Your Dominating Blow Skill Damage will not be scaled with Count setting.\nBy default it multiplies both minion count and skill hit count which leads to incorrect\nTotal DPS calculation since Dominating Blow cannot inherently shotgun.\nDo not enable if you use Spell Totem support, Spell Cascade support or similar supports", apply = function(val, modList, enemyModList)
666+
modList:NewMod("Condition:DominatingBlowSkillDamageCountedOnce", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
667+
end },
665668
{ label = "Molten Shell:", ifSkill = "Molten Shell" },
666669
{ var = "MoltenShellDamageMitigated", type = "count", label = "Damage mitigated:", tooltip = "Molten Shell reflects damage to the enemy,\nbased on the amount of damage it has mitigated.", ifSkill = "Molten Shell", apply = function(val, modList, enemyModList)
667670
modList:NewMod("SkillData", "LIST", { key = "MoltenShellDamageMitigated", value = val }, "Config", { type = "SkillName", skillName = "Molten Shell" })

0 commit comments

Comments
 (0)