Skip to content

Commit 7cc3339

Browse files
Fix minion data getting in xml of non minion skills (#5571)
* Fix minion data getting in xml * More general solution * Revert "Fix minion data getting in xml" This reverts commit 68a0f15.
1 parent 718abae commit 7cc3339

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

src/Modules/CalcActiveSkill.lua

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,9 @@ function calcs.buildActiveSkillModList(env, activeSkill)
234234
end
235235
activeSkill.skillPartName = part.name
236236
skillFlags.multiPart = #activeGemParts > 1
237+
elseif activeEffect.srcInstance then
238+
activeEffect.srcInstance.skillPart = nil
239+
activeEffect.srcInstance.skillPartCalcs = nil
237240
end
238241

239242
if (skillTypes[SkillType.RequiresShield] or skillFlags.shieldAttack) and not activeSkill.summonSkill and (not activeSkill.actor.itemList["Weapon 2"] or activeSkill.actor.itemList["Weapon 2"].type ~= "Shield") then
@@ -504,6 +507,9 @@ function calcs.buildActiveSkillModList(env, activeSkill)
504507
skillModList:NewMod("Multiplier:ActiveMineCount", "BASE", activeSkill.activeMineCount, "Base")
505508
env.enemy.modDB.multipliers["ActiveMineCount"] = m_max(activeSkill.activeMineCount or 0, env.enemy.modDB.multipliers["ActiveMineCount"] or 0)
506509
end
510+
elseif activeEffect.srcInstance then
511+
activeEffect.srcInstance.skillMineCountCalcs = nil
512+
activeEffect.srcInstance.skillMineCount = nil
507513
end
508514

509515
if skillModList:Sum("BASE", activeSkill.skillCfg, "Multiplier:"..activeGrantedEffect.name:gsub("%s+", "").."MaxStages") > 0 then
@@ -517,6 +523,9 @@ function calcs.buildActiveSkillModList(env, activeSkill)
517523
skillModList:NewMod("Multiplier:"..activeGrantedEffect.name:gsub("%s+", "").."StageAfterFirst", "BASE", m_min(limit - 1, activeSkill.activeStageCount), "Base")
518524
end
519525
end
526+
elseif activeEffect.srcInstance then
527+
activeEffect.srcInstance.skillStageCountCalcs = nil
528+
activeEffect.srcInstance.skillStageCount = nil
520529
end
521530

522531
-- Extract skill data
@@ -586,6 +595,9 @@ function calcs.buildActiveSkillModList(env, activeSkill)
586595
end
587596
minion.itemSet = env.build.itemsTab.itemSets[activeEffect.srcInstance.skillMinionItemSet]
588597
end
598+
elseif activeEffect.srcInstance then
599+
activeEffect.srcInstance.skillMinionItemSetCalcs = nil
600+
activeEffect.srcInstance.skillMinionItemSet = nil
589601
end
590602
if activeSkill.skillData.minionUseBowAndQuiver and env.player.weaponData1.type == "Bow" then
591603
minion.weaponData1 = env.player.weaponData1
@@ -625,6 +637,13 @@ function calcs.buildActiveSkillModList(env, activeSkill)
625637
end
626638
end
627639
end
640+
elseif activeEffect.srcInstance then
641+
activeEffect.srcInstance.skillMinionCalcs = nil
642+
activeEffect.srcInstance.skillMinion = nil
643+
activeEffect.srcInstance.skillMinionItemSetCalcs = nil
644+
activeEffect.srcInstance.skillMinionItemSet = nil
645+
activeEffect.srcInstance.skillMinionSkill = nil
646+
activeEffect.srcInstance.skillMinionSkillCalcs = nil
628647
end
629648

630649
-- Separate global effect modifiers (mods that can affect defensive stats or other skills)

0 commit comments

Comments
 (0)