Fixed a variety of incorrect catalyst scaling (#4467)

* Fixed a variety of incorrect catalyst scaling

The changes are based off some testing and work I did in 17/4/2021
So any recently changed mods or new uniques will not be guaranteed to be correct.
#2521 (comment)
https://docs.google.com/spreadsheets/d/11mOp3VLPXgbhJq562DdFmP34nx4tNqoF47LbrM-R93g/edit#gid=0

I have verified all of these either using trade or through in game but I haven't collated documentation due to the large number of changes.

* Update amulet.lua

fix accidently removing jewellery res from Tavukai

* Update Noxious to damage

* Couple minor fixes to legacy voidheart and forgeting to readd chaos to Lori lantern

* fix missing updating physical damage on unique belts.

* fix typo

* Just make the resistances a bit cleaner

^(\{variant:.+?\})?(\{tags:.+?\})?([^{}]+?)% to (.+?) Resistance
$1{tags:jewellery_resistance}$3% to $4 Resistance

* Cleanup and fix leech

* Fix typo

* Fixup missing speed tags

* Variants Before Tags

\{tags:(.+)\}\{variant:(.+)\}
{variant:$2}{tags:$1}

* Rotblood

* Update ring.lua

Author: QuickStick123

src/Classes/Item.lua

@@ -18,7 +18,7 @@ local catalystTags = {
 	{ "life", "mana", "resource" },
 	{ "caster" },
 	{ "jewellery_attribute", "attribute" },
-	{ "physical", "chaos" },
+	{ "physical_damage", "chaos_damage" },
 	{ "jewellery_resistance", "resistance" },
 	{ "jewellery_defense", "defences" },
 	{ "jewellery_elemental" ,"elemental_damage" },

src/Classes/ItemsTab.lua

@@ -538,8 +538,8 @@ holding Shift will put it in the second.]])
 	self.controls.displayItemSectionCatalyst = new("Control", {"TOPLEFT",self.controls.displayItemSectionInfluence,"BOTTOMLEFT"}, 0, 0, 0, function()
 		return (self.controls.displayItemCatalyst:IsShown() or self.controls.displayItemCatalystQualitySlider:IsShown()) and 28 or 0
 	end)
-	self.controls.displayItemCatalyst = new("DropDownControl", {"TOPLEFT",self.controls.displayItemSectionCatalyst,"TOPRIGHT"}, 0, 0, 180, 20,
-		{"Catalyst","Abrasive (Attack)","Accelerating (Speed)","Fertile (Life & Mana)","Imbued (Caster)","Intrinsic (Attribute)","Noxious (Physical & Chaos)",
+	self.controls.displayItemCatalyst = new("DropDownControl", {"TOPLEFT",self.controls.displayItemSectionCatalyst,"TOPRIGHT"}, 0, 0, 250, 20,
+		{"Catalyst","Abrasive (Attack)","Accelerating (Speed)","Fertile (Life & Mana)","Imbued (Caster)","Intrinsic (Attribute)","Noxious (Physical & Chaos Damage)",
 		 "Prismatic (Resistance)","Tempering (Defense)","Turbulent (Elemental)","Unstable (Critical)"},
 		function(index, value)
 			self.displayItem.catalyst = index - 1