Update Culling Strike to PoE 2 Implementation

[QuickStick123]

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

https://www.poe2wiki.net/wiki/Culling_strike

In PoB currently it is treated as a flat 10%.

Describe the solution you'd like

Pinnacle boss should set it Unique which is 5% the other settings Normal, Magic and Rare aren't as important but would be nice to be implemented maybe as a controlled drop down by is the enemy a Boss dropdown?.

Describe alternatives you've considered

No response

Additional context

No response

[pauloday]

I'm working on this. Would it be a good idea to change the "Enemy is a boss?" dropdown to "Enemy rarity"? This would keep the current options but remove "No" and add options for normal/magic/rare/unique (non boss). The other option would be to add a new dropdown for rarity that only appears when "No" is selected in the current one.

[pauloday]

I just made it a separate dropdown, I think that makes the code in ConfigOptions easier to read.

[deathbeam]

1 important thing is that between poe1 and poe2 culling behaviour changed and now cull is checked before hit damage is applied, so for accurate "culling dps", i think average hit should be substracted from the culling damage increase otherwise the damage increase is mostly fake.

EDIT: Thinking about it more maybe its even more complicated than that

[pauloday]

The change to being on hit instead of for all damage did occur to me but it didn't seem like something that'd make sense to include. But I didn't think about how cull being checked before the damage would change things, that's a good point. Not sure what the best way to handle that would be.

[deathbeam]

I think at least supporting current % thresholds is good start, it just do not solves this issue completely so even when thats changed this should probs stay open imo (also good first issue is probably wrong tag too)

[pauloday]

Maybe something like "average hits to kill" or "avg hits saved with culling strike" would be more informative. I don't know if HP is calculated/included though. IIRC there was a way to set monster HP for detonate dead in POB1 but I'm not seeing it so IDK if that's the case.