Skip to content

Banner calculation does not calculate past 50 stacks of valour or factor banner magnitude passives #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
JinsuPOE opened this issue Apr 20, 2025 · 1 comment · Fixed by #1048
Closed
3 tasks done

Comments

@JinsuPOE
Copy link

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

DPS calculation is the same at 50 stacks to 75. You can have 75 stacks of valour but once it hits 50 it does not increase past that.

Image

Also selecting the banner aura effect does not appear to affect calculation

Image

What is the value from the calculation in Path of Building?

The valour calculation appears to be capped at 50 even though you can have over 50 stacks. Banner magnitude passives not be calculating as well.

How to reproduce the issue

  1. Select Symbol of defiance and banner maximum valour to have 75.

  2. Select war banner as an active skill

  3. Go to configuration and search for banner and ensure it is marked as planted

  4. Put in 50 stacks. See dps calculation

  5. Change to 75 stacks.
    Result: DPS calc stays the same as 50 stacks.

  6. Select banner aura effect on the tree
    Result: calculation numbers does not change at all for DPS

PoB for PoE2 build code

eNrtPWtz2ziSn0e_gqWqu7qrKDbBN3P2bsmvxBk78Vi2M5MvKUiELI4pUsOHbWVr__t1A3yAMklJ9syuZ3enphwJ6G4A3Y1-4KW9vz7OA-WexYkfhft9sqP2FRZOIs8Pb_f711cnb53-X__S27ug6ezz9CDzA6zR_tL7YY9_UQJ2z4L9vkv6yiSgSfKJztl-_5zFExbSeNlXaAKfvMOq7opOUn_i07CvpDS-ZelN0br6DanMaAwQLD5DysMsjc4jD9DSOGN9ZU79cBRN7lj6Po6yxX5f7yv3PnsQMKfnF58vr_rQux_2LgK6ZPEopamSwJ_9_hBGSW_ZBz8FFBpkAK9pzo6l93c7EQ6yOEmP6Bw-bog4WjDmlbBkh1htkBcxO55OGTDknh3Gfno4o-GkakZtw9sW9jwLUn8R-CyuhrCjtWF8eEKcqK3kr6KUBkcXo4qwZe5oRHW6EaJ0fc-_-OnsIABebkMekU5vQz9l22JdRH4Shc8ZiozTLocsCGDubAR7yRIW39PUr_ennXY0H_vhdow6pyE9jJJKDsQmXbAXfE6nNRR1DcKITSKY_LVWXGdHtzZoqBm9tcUzf8o2h9xqMDnCtr153jiOR5vCbU34eR26BMO3GeQoyoINIdNYUju7fRr8VoMkrSbriD1KGmZ1EKxBWkYb5GlYDcM02pu9j3CSrh8xNxXHHy5KSMPRrR3TcFTTdXTS6ksuZsvEn9DgnD7682wOpvmK3rGqQU3XjHYlvJ2lIdicNmRovJVVJ37MnoN3GAXes_BmNEraEHXLahc9je9CliSbWlWwkhtj4DSuWK0So8PlT94h9Gk4qfSmi-x1GOfd2agBRLmEWYsxyThgG-NUzeSzfxOfLhq7ZWHe4lJqbod0YZ0xNpm9hyDtkqZsMzdRQlmu3cleBJbZ20m1gb0d9OsYW3AKEZs5Zdg7RhfWlpwaLfxYilyJtQayYfxE1TbFWeWApe_Yrdp8HLL4djma-SzwNnBDEnTBtEO62IQDoAMy9ka6UG-uSVAboW4prUs5WeiEaplmrX26p4nsb0zdsboZJhBkXhGnXTEZhNuA4rGVBMCy21OY6FdMYIIt8YbxPMoq366bjts5EAFfG4furvOaIm27ZF42qblpvTUqLtOxgwDSzE1zrBILuhoEW6EO05RO7o4i75ZtisIb2Qqj3r9RtljATEe92JQARgPgPn0puGs3CBXwZ9BqeXJrXVHDxvQr4FX6xF0bC23cygrGk6Y6A5mVVgxzA-jVFtZL8xysxhzsNF9wOI_kNQddbY_sIBGVE0UCYbDt7piaRVSrfcJytOZcN6c4uvODQEnw7wWNAaWvJDBnJ4x_4kS0R2UYg7EIwNopo5m0CmA5tunsWI5mlOH75mRHPphR5ZAmEzBBkgs2THPH0jUHBmZrW1M9i6inNJNeSa43p3npLx5geigHUbBBnnQRPYBOzHCZLNkOGiLpytq1ijRm4fflxvRr4Bs1cBx6WYwWZuM2VjE2ambIZwOkWGx-5s-lMKnAOMim00SZRPMxTc9gqqE8xlAmPlcaeUCDAIroAAQehv6Ywrc5fAkohEfLgXIRs4mPdnOglIIsUXj7ShMxUdOG8YXGUBZCtDFQbnxIE3lTcukXP_SUI-QKOMxJFicsH4QY3ZU_B7-dJEc0pYqXp6Q30GUaphpaKiVhNJ7MEOkEGh-Dw-EaWZYKTcVl1RM_SFl8hP0LJ1xQqxRJYfv2dvkSMH46nS-iOFUCmqSXjAZz1MVjrc8LDosF3Q80mWEU6mkuJaoLua9u0KkxNpnLpg5zDeY5ukcNz5xSfdpX2CMSxYm03O9PaZAw0SwvgV4lqR_yJTKQYBD00Zw8DL177PdVFAVJgaTQxYKFXo3GVcyYQguXOMEhcVbiF2UOvQYBCjObIG-kRexTj3M0jKADEH8RRzMHhqHbZGA6DjEGmmPYA8sghjoAS2baA800iT7QXGJpA910VTLQLc3UBoatW_rANB11QEzVMAZE03VA1cEQD0yDaPYA_hB1oBPiuAPTVo2BoZu2M9CIbUKjNqANdNVVzYFpuQComRZxB7pjAF2IpxDSUi1nQHTVIQDvmNbA1l3omGVq2sB0Lei0rls24Ng2YFqWOrA0wzJgAJZlDixV1aFRB_oEJQaOkeDw4KMBfdRcKDY1B8boQJeg6zqMRXUAGsapQfMGVsLIjYHuOsgnAyAs09BdQNFtgCY6gXId-qobOrDG1mGsjupqgOxCezZxodMq8I5wVmvQiDswNMMErmkqdN2AFBioqTAY4roussexkZJjwxh18G0DQLEN-AzyGJiq4-Bn4JpmqKo7IMAXGLBqQ7d1QyVYDuwFEYHYCGeygYs1A1RYB_6qLkhDI9AZ0yEEJKYRywIuAd-BBY7jwGfQhYFjuDqgWtAScTUNZG1YwCUC43YGrgYfwUmDggBdHK6pExik4brATkHFMJEuCA-UxXLgL2gZgKuuYwEVB_iA2gODJCBEFBC0ZEABdJWAKsA4bIR0Ua1M14WR6agiA8vinXGRDyAhaNvVYUwadExDq4BrgzReDutKH_owx1KYN9J-jZbv-mC9zmfQD3vXl2f8ww-zNF0k73Z3Hx4edhY0nUVT9ghpwg6Y4d0FIMHce8t95VukujuE_w5uzw9YsniMby6C-9tk-jb6fvD2y-fFhP12fjG-OzqZPFiPR8PHt4fjq7F1ZDHv-svox8i6uciMs9A39Tvz7tj85duvh18DcnT-NbsfTvT4i3Wihj95pmcf3X1XhxfLr1b0o_v22_3Py4hly9no_tuDlx09-taPwcU8OLGnp87DxR3VPn8z3Uz1H74fX0afvpqnnz6YDx8z103em79k51_Gvx5_vLa_Gl--jr-Szx-Cm_u7b0eXvxojTU30948HI_PnSXByn6nfZp-cj4H20f3p3rr_-OkX0NiLs5Cdnzgpffv9fv7T_eRhdkYNd_Q4vbn7_uX841GqP3hfk1-yoRXckJ9iiBJH8cQ_iq61Ize0lqe_2sE4o8svwa16l320btNv55fhlCS_Xh-GZz___PEX4Ob-PhfIbiGRPbFzlgjx5N-4JUP54XzrKz54JGHidpvBuGWq4PQ2OD6hKji7DY5rdgWXR2nQa7mzexgbxz6Y3JwIZE2xP85SVlSAP3j8lNtkbodzc4HmSswDYXvFBBXzRhg2YU2FqRJGKZ_cfIJwiwDdC9OcOp_VwsYKkygMUG4WcDphqBfn0MIF5DadT0ox57nBLIdaGx2MHJwQ96_opfDDJ4gTeB0WFl_2eLSZgN-O0_dsnhwsIQI9wcWKlf2g3M0h9IilIh6QcYq9VY9NaRZg-U8ZD0Jy71-Unomt3jCK5-V6NJACr4sJpaB4tVzgsIdnZ7k_zVtVfK_wsXkh38odVl07pMEk4Z3zw0mQgXKEeVRd-vGAjrEDuEONa6CevCksUSob-mEPesRDROjBaQgaklsxgf8-iCDA0woq-U42pJC1elLU34vwB5VUBKBHgjOHcZQk4-ihLwJ_rOfLKEW5AO4rv0lMvRXKfs5S6kHQtnsK2p_sQm93-QjgQ0sTIZ3nAUtRlmdRKyyZRFmYi1oafs5j5EE5y7C9f5BYtJeIxVkvlvc0gOjPn4wg4vQSSR71iuF8Hj0RiraRVFZbqMRR1ChF1bYCEawBKUjVyi2kQinzRCS6Oo5iDL5goVZaWOzyCzi9ntEnUXyXz3mJy3kJVm6l88luZT8QWWar-P485f6jRi_WzK4imHiTdjbUoJ7Nj0MIxYq1S2nuS6X_jImfc-y1mGO-RFOu0FSCkIpfMOfr1CshrCwMvS4d_cLoIgqPA748WKyDt-pqI_SzdfYi9iFAGEKUMOd7SBXLRI1SVb0upg09j3nlsu8anjUBP5tlJZ3TcJolK7O9rFSq2tfFuLKHx4-LKMnidq49gXw5ywpKzSyral-ZE4lC3GGNaene2z3JE9CXuJMVUitupaxViuo_gX_5o-PKckm3WLmVZPSkbjsvk5RupqGRSjJPF5XbBKO9KMB8Oppyd_efGG3y5VixT9oedUpAz54e5xTGT4MrNl9EMvvzciWveF2WBA-TnGAX8Gh0G3tkoBcE52EaTcWZHTlED1Mlmiqi_M-Qh74oHrU3CL5gjhS7NaUgqsLnLQjIRCvm13aGXpdelntlrUpZQrwg1Mwp1KPMsvCV-Xyxjdju6EX98727wK-59KLodXGi2OZsZUUB8GxeFARkZlRl__JWytrAStFY7C_LRqooky4gPDNtlshL5qrc1H5tGnkaTmJGE-YN4Z_P0zUheSP0C8KO29Cf-k0heVn1wnj8Dws-opgdZTFXlKfcaqh9vqnHXUeI8fhxNcnYy8WvzNxXR0jaTX4F83yzX9GomX65-F98lVBT14sjP37TkMOt1GwriNzgPaFfiWL15E-bPNR_1sIXP1t7ALasPcGSYJ6tqaNF4EO6WXMJVdnrmr14OHttWiUDvTCtEkfGn6ZVonxb3oienvshP6gxyubzKGQe0PLD2_wqwR8c_ft4haA99OfVz3cGHL3mB_KSVxXZ5RX_cFN3xKY-5oRP4rt6RVeQt1GMt9pOJY6i5oXRniSX_COA8qMR4vADfuRIHOI0XGQp78R-f-4nk294xBNvhvMTGfxG-_HJyfHh1enNcX50UkbhXPoWZvMxHwv_d79f3JUYMb7hpiTZOBEfMaFgD7wjR8AjP0hwXEFAF4kkfDz4kPc8wACunRqH-uCXd82baVUA7ZSOH1mcwngh3J7EPmvtV1m_plOiQbyigkdN26jhne52QmJp7hBPiPIrNC2c4lfn26ngZfbW4RyWZq0R93S-oEFry3ntGk6keL4FNBxi8gkupHaLHE_DCKgOvkwmECFPlh3yzi9ptNPgl-TbCIjKdmRx7b0NO6_t4Cq_a9_KVVHbjn7EJrR17KKyHbm8lRWF_FmHZiolVAelT1HIlRwmzdAPcHOyVbLHAStB2gl-Tmcszk8Qt1E6BxtVgHROHHHUrZWOBNHBK36VtYVDWNeOKlZ2W8aAdR2TJr-22Dbb_e4pW79a2CIPGaadlLhj08rD_MJOhxjy-2otIhC1HSMpLu61DCKv7pgo3AYP7yPfE1e2WqbMCliX0Ygmdy8nw--hvZzM6sW0l1M8CWhy1yrvvLYd_Tr1MRJqoCIimI2I4MR6GQW-cfMiCnj_Yv5s7MvVUKTCvewOQsorP43IRW3X3M9vAj2bgriv9Gx0fp3q2djcAUAYjCtTnR6ghOmYHGkWFutoLyTFu9VsRarRbUVL-MLGkW5NUczu_O2HLgMgQNYQAmf-oSNc3IxSednyA6MBPhIUBS8j-OSNi5cQw5vj2YKGXkHuc1OQXslhQ-5FaQI0-fWuI7yg_lIehmy-bCDU3q-93SKt41e1MNHKr6uN0hhz7O9RNP9lv_-WOJa-Q2zXIppm2q6oyE-qEz0_ng4h-JEPcoy5_hXtIuTP-31dNXdsR9OJ4doOETc693ium5-cx8_lwfl2clnCxLM64jQdxxCcEpkmXvXjp-Btkf1f8p25d8rl8PK4934WZYHyPqOxB3lz75DyhdtU-cCCeU8EF-8UzSS9PFCAL5rb4zT5YN8pttvLj-1DndrLb0-8U0a9yyxk7xSIcFmPw16y394pptmDjCfwJz4Ckd7fYCyQZqR__1sM4H93_gvXOcQeR3mGKt-D6AGBzAc__U60rZjuAOgpIBn-7xF77DmaTEAMQAGVUvL-994QmyhppMzFbFDQU_ZIrVnBIFwDE9KYRlno9d7oOuJBIynDeigALCjBW-eKCOPQtPXeaDovx9vicjkuK5xH3iUNb5kS49_9vrpj9vMrCvnCQyuEvhbCWAthroWw1kLYayGKy8l84WZFB0mDDh4hAw9pTBcU2DSaxVHmgRjOqR-UKmgakgoarlZTQUdtUcG6Ejbqo63K-qit6uMbg8syJ486QYNAEYtApaRXNWBVT211oDiW0FP4l-upsVZPTfuJnr4xHCwT6QsooNmsgIQ0KqAJbcb4JAW0KPJjpXDuCvy_jLKX6qj2Z9PRDgi3Q4v1Bi0eLqIJDZbgYIDxMesdh7cxvQdWFxdmtlTZ0xhkgh-ffJeUV-s0pqYqK1nxNokifN5TLdUGClFzNcUPqKdEJ100hp6XKFxPifGkkqh6zZoXx7zzeuXBT2eKWJ7DuaQKpQWWSkSUgyjMoNbAOtHPfA5WJwTL6Ui4ZYf-s_A2nf3H4PIuNvh8Cjw78MGnnfkhC5UDFqQ9nq0poyBCTVLrHt6ua5lWEysmikrxkJAyjaO5IpK7p-7aAhE53IsKg9fTXJkSR1uhh2eCQTfsmmALz7tq4ACOl1ensGXrx2nYkppezaI4TBRPaOt_tAXJ17Tl-tPpT9fHvRsa0LvovyG4TP4vUW58YOZFAHJR3tMsTAOwW6WbJkSv3DRRjc1sXm7hRmkEKrhi4ozuePENMdpFvqqAhjlQDFUYOPgX7Ztrr_HDNQ0VxkrhmwWgbWZdKzVtJUA0nPa-ERXsHZgy7ryFCoI-h6D0eAi-hvUfBS0V1GkwZ-dRPPbBDkQJjZe9Ie6eKcN5BnpZt2KmpFVOS9A3DALw4ilLlJG_mPEwrO5TGmyaUfOQRbwmVocVsTwMZFTnSTSnaRtkHYSbLXR41Wo7Bp4rqkZEKMhfdfodk45_k4DObfKSEcQrKHjfY70DmvAweQT5cRqFlcHTVU1Kje2643S0NQYPc28MFlHqV-CTxlTOlN1Oy4crTAq9pX4I6TrE7soMok0F9aCI8ZtDqcYkOo_6TBH06bW4sXjsqzB7JpE8-BuDR2Y5C0CJcfu3Z1vrspsuT_2GaM3KbEgJDL_eqni_b_6i_5vkL2pd38-H708Pe6NsjHzmF06ug9Sfo4tHQ5UHZqCj6QxSRpAGv6tTU3XLllRdl7TYquXXai-P7BKFOOAvOXn8ruiKWMRKeuAFk2zOMK-AJm1Tyde8UcZZwnqHWQzGOA2WoPGJVP9Es6Fpq2abh3M8_VEEl6DLmqRQRSsL6AxvJorjbAHO-HcSd6MgjCZB1K7DlZLgcXFNEqMl3sqvi8GsWZwNxGARR5BukwJRfwcxWJ1iwD3yRFF3NLMmBdGVP5D9ZlMaH6Ot9DwY5QdILyCeYCkkDNBdNGw1604k_mpq3Vi_cZpN2BPrq8k5tLqaQ3NLm2fIHI5YHNCtxY0S0BudUyoOdxQG-Y2urmRQWmMGxY8sKOaOZfLgtOxNHvjmnQJ5o8r88cHFv8aaZ5Oa3YAcGD-odrxkveM5iylKYlXH7JqOWSs6RnSzSdjFYuX_8HkNXcaD_HHyv-8UXGR5qoJmrlrcr2ukTbUEUL7Ws5qd1HSQuKYc7HJdeaOR5sVKXe3URAyS_3BN_Hfx-w2KeBbRdKYUh6ELTawpoabVfQeprV1L63DFul8tr5EX-2oxK3SD8aDwOvR_yxhmTHMf_EfNV1QL1NN8zXqQh36IeTjDE7NQW-DWmy6fKrpkAX9SlQewr8dqNclIa9ogoXPx4KQyCvz7NikZK1KqL77WA3S9dVUDE4hm4YFZiUFFYH7eA6e1NgoCuGB98srZ3bSSfxBHESoLje8gURsvV71-jc2aWZ8MLMHNWQXvZ6HO5juXda7WbFhPnFTOF7FFFldfGSjmwD-MlU2Mato8PmAzNo_QfOC7UI1a6azEnVq74q2xKjWzQEUImd_-VrizQBpqm_L-WfSRaE0ZwUkQxXzBmj6gyxVr9XkWcIGP3PqoHyspmWlVuYCcCpCVTaNr5NXDjPEMWhlD0D2HlC-OvrOwd0YTsNgNWYGuYfuG2p0VVPW99_jgQ6KczudZiMEJhgIxY9-fhsTQvzw1gKiYJ4i8c9jNHnHbE7ZneEV8ILD9-ET97cAgSvljkRfj68szPAkiDu-_D6CnSfWOZOnk2xBEM4r85KW-IY70XKW6DgVDSUXfAuEgilJpHG4Jz1etTj0AXn2LUyB-ZA8YRVbPcxaEOwjkj2_KBKT3ODcgkL_yKROQHv5cJbBGFMroAZ-_35hVYnW5QnA2EoYkPWKuwxBTfBv5CQxtawxZEbUulot3WmWOVy-3bsdwbVuG4w5lBW6sAxerJPLA1raA551kkRJ7I5lKbZjrJ5i3VIrT3GU7ZLPByMpTcx_iXhKeVqMeGDI8qfaFYXKWiONsfDOBX1eKwql_mx8tE1_yw2UcvyxRwJkEjN-kwidA61ZQvrYEMXuSDiepdhhnLLihQcCWhVO68iGLS6rrT_X4hxv1pi3jghdyM2MeHgF5zrfidlT1iK0Mi2acu0J-8O_CB0yvr4yjKIBcOz8v14D2UD5xMuIZbNWM3gReDvwTf5F2m5G3bpZ3taOLdq6A-g0LAeUwXi5SqY16DIqHdiFUAI86i4qbCXXCDLlzmhxEiUQEz0V18vQ6ATje2w1YWpfEQYCvN3lb451Tf74R2rz8ndH8Omsuv2riN0N_ggkzXg6DYPnk4l1XvyCKicZ-4CfPGFPD-3FrKZSawKdauyK8IWrjsmP7vLoI-DtcW49C5OLb4_HcvRUPejNhqLUQ0kmqmv-ubTn3VXUNgvwztQWW2Y4jHlRdmfqkHb7SH_z5VlzC5siHmJOMWDCViJhrepr_UFQUBDxulQe5DrOQbYmirUOp_zqVxBrb2WSwaFjwMjeb8Ah_W1bhnc8lRvFbESjliR2H-IH_gOKqrLpGPppE_PT2xtItW1xlk76Ov4VzLxAs3eyQf-Lf-sHnKb_tAd3jV1Y27V55q6tUF81oR-HLZC0c2NstPb84_s6__aW3t_vkp7f_H5MyZOc=

Screenshots

50 stacks

Image

75 stacks

Image

@auspex92
Copy link

"I've checked that the calculation is supposed to be supported"

It's clearly red and not supported yet. This is the wrong place for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants