Make stack potential more understandable (#609)

Change the note for stack potential to explain what it is, and display
it as a percent instead of a float.

Move the note about using a weighted formula to the roll average
breakdown, since that's where it's calculated. Also
clarify when the weighted average is used.

Author: pauloday

src/Modules/CalcOffence.lua

@@ -4122,9 +4122,10 @@ function calcs.offence(env, actor, activeSkill)
 
 			-- Ratio of ailments applied : max effective ailments
 			globalOutput[ailment .. "StackPotential"] = ailmentStacks / maxStacks
+			globalOutput[ailment .. "StackPotentialPercent"] = globalOutput[ailment .. "StackPotential"] * 100
 			if globalBreakdown then
 				globalBreakdown[ailment .. "StackPotential"] = {
-					s_format(colorCodes.CUSTOM.."NOTE: Calculation uses a Weighted Avg formula"),
+					s_format(colorCodes.CUSTOM.."The percentage of your max stacks that are applied on average if you are attacking constantly"),
 					s_format(""),
 				}
 				if configStacks > 0 then
@@ -4161,6 +4162,7 @@ function calcs.offence(env, actor, activeSkill)
 			if globalBreakdown then
 				globalBreakdown[ailment .. "RollAverage"] = {
 					s_format(colorCodes.CUSTOM.."This is the average roll of an ailment affecting the enemy if you are constantly attacking"),
+					s_format(colorCodes.CUSTOM.."Uses a weighted average formula when stack potential is over 100%%"),
 					s_format(colorCodes.CUSTOM.."If hitting constantly, your average strongest ailment currently achieves ^7%.2f%%"..colorCodes.CUSTOM.." of its max damage", ailmentRollAverage),
 					s_format(""),
 					s_format("Average Roll:"),

src/Modules/CalcSections.lua

@@ -886,7 +886,7 @@ return {
 	extra = "{0:output:BleedChance}% {1:output:BleedDPS} {2:output:BleedDuration}s",
 	flag = "bleed",
 	{ label = "Max Bleed Stacks", { format = "{0:output:BleedStacksMax}", { modName = "BleedStacksMax" } }, },
-	{ label = "Stack Potential", { format = "{2:output:BleedStackPotential}", { breakdown = "BleedStackPotential" } }},
+	{ label = "Stack Potential", { format = "{2:output:BleedStackPotentialPercent}%", { breakdown = "BleedStackPotential" } }},
 	{ label = "Average Bleed Roll", { format = "{2:output:BleedRollAverage}%", { breakdown = "BleedRollAverage" } }},
 	{ label = "Chance to Bleed", { format = "{0:output:BleedChance}%", 
 		{ breakdown = "MainHand.BleedChance" },
@@ -935,7 +935,7 @@ return {
 	extra = "{0:output:PoisonChance}% {1:output:PoisonDPS} {2:output:PoisonDuration}s",
 	flag = "poison",
 	{ label = "Max Poison Stacks", { format = "{1:output:PoisonStacksMax}", { modName = "PoisonStacks" }, }, },
-	{ label = "Stack Potential", { format = "{2:output:PoisonStackPotential}", { breakdown = "PoisonStackPotential" } }},
+	{ label = "Stack Potential", { format = "{2:output:PoisonStackPotentialPercent}%", { breakdown = "PoisonStackPotential" } }},
 	{ label = "Average Poison Roll", { format = "{2:output:PoisonRollAverage}%", { breakdown = "PoisonRollAverage" } }},
 	{ label = "Chance to Poison", { format = "{0:output:PoisonChance}%", 
 		{ breakdown = "MainHand.PoisonChance" }, 
@@ -988,7 +988,7 @@ return {
 	extra = "{0:output:IgniteChancePerHit}% {1:output:IgniteDPS} {2:output:IgniteDuration}s",
 	flag = "ignite",
 	{ label = "Max Ignite Stacks", { format = "{1:output:IgniteStacksMax}", { modName = "IgniteStacks" }, }, },
-	{ label = "Stack Potential", { format = "{2:output:IgniteStackPotential}", { breakdown = "IgniteStackPotential" } }},
+	{ label = "Stack Potential", { format = "{2:output:IgniteStackPotentialPercent}%", { breakdown = "IgniteStackPotential" } }},
 	{ label = "Average Ignite Roll", { format = "{2:output:IgniteRollAverage}%", { breakdown = "IgniteRollAverage" } }},
 	{ label = "Chance to Ignite", { format = "{0:output:IgniteChancePerHit}%", 
 		{ breakdown = "MainHand.IgniteChance" },