Skip to content

Commit 74056c0

Browse files
author
LocalIdentity
committed
Merge branch 'dev'
2 parents f98a983 + 34ec4b1 commit 74056c0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+17146
-16854
lines changed

‎CHANGELOG.md

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,47 @@
11
# Changelog
22

3+
## [v0.5.0](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v0.5.0) (2025/02/12)
4+
5+
[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/compare/v0.4.1...v0.5.0)
6+
7+
## What's Changed
8+
### New to Path of Building
9+
- Add Support for Ailment chance calculations [\#628](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/628) ([LocalIdentity](https://github.com/LocalIdentity), [OrderedSet86](https://github.com/OrderedSet86))
10+
- Scale base Shock calculation by shock effect mods on tree and gear [\#628](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/628) ([LocalIdentity](https://github.com/LocalIdentity))
11+
- Use count to set number of active Minions for Reservation calculations [\#761](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/761) ([mauriliogenovese](https://github.com/mauriliogenovese))
12+
- Add support for Armour Break [\#731](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/731) ([majochem](https://github.com/majochem))
13+
- Add support for Blasphemy reserving Spirit [\#736](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/736) ([Paliak](https://github.com/Paliak))
14+
- Add support for Vulnerability" ignore x Armour" mod [\#733](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/733) ([majochem](https://github.com/majochem))
15+
- Add support for War Banner and Defiance Banner [\#752](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/752), [\#753](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/753) ([Blitz54](https://github.com/Blitz54))
16+
- Add support for Rolling Slam "more damage against heavy stunned enemies" [\#750](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/750) ([Blitz54](https://github.com/Blitz54))
17+
- Add support for Acolyte of Chayula Darkness Ascendancy [\#715](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/715) ([MrHB212](https://github.com/MrHB212))
18+
- Add support for "I Am The Thunder..." and "I Am The Blizzard..." [\#768](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/768) ([madxmike](https://github.com/madxmike))
19+
- Add support for Pinned recently [\#723](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/723) ([Blitz54](https://github.com/Blitz54))
20+
- Add Support for extra Exposure [\#720](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/720) ([MrHB212](https://github.com/MrHB212))
21+
- Add parsing for "Your speed is unaffected by Slows" [\#700](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/700) ([RealWhimsy](https://github.com/RealWhimsy))
22+
- Add Support for "Slam skills have +% increased Area of Effect" [\#705](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/705) ([MrHB212](https://github.com/MrHB212))
23+
- Add support for "against enemies within/further than" [\#734](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/734) ([Blitz54](https://github.com/Blitz54))
24+
- Add support for ignore Warcry Cooldown [\#741](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/741) ([MrHB212](https://github.com/MrHB212))
25+
- Add support for "Electrocution" tree mods [\#758](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/758), [\#757](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/757) ([Blitz54](https://github.com/Blitz54))
26+
- Add support for Break Armour on Critical Hit with Spells [\#755](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/755) ([majochem](https://github.com/majochem))
27+
- Add support for Gamblesprint movement speed [\#728](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/728) ([Blitz54](https://github.com/Blitz54))
28+
- Add support for Dustbloom Life regen [\#727](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/727) ([Blitz54](https://github.com/Blitz54))
29+
- Add support for Vile Knight enemy in presence Duration mod [\#706](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/706) ([Blitz54](https://github.com/Blitz54))
30+
### Fixed Crashes
31+
- Fix crash from importing item with Mana leech mods [\#735](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/735) ([nessgor](https://github.com/nessgor))
32+
### User Interface
33+
- Fix the highlight node circle being too small [\#729](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/729) ([LocalIdentity](https://github.com/LocalIdentity))
34+
### Fixed Calculations
35+
- Incorrect rounding for Reservation calculations [\#725](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/725) ([nessgor](https://github.com/nessgor))
36+
- Fix calculation of Leech passive nodes [\#708](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/708) ([MrHB212](https://github.com/MrHB212))
37+
- Fix comparison tooltips for builds with Time-Lost Jewels [\#709](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/709) ([Peechey](https://github.com/Peechey))
38+
### Fixed Behaviours
39+
- Fix "Critical strike in last 8 seconds" mods always applying instead of using a config [\#711](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/711) ([MrHB212](https://github.com/MrHB212))
40+
### Accuracy Improvements
41+
- Update Time-Lost Jewel affixes with proper wording [\#767](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/767) ([Peechey](https://github.com/Peechey))
42+
- Fix duplicate skill for Greater Lightning Bolt and Decompose [\#763](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/763) ([mauriliogenovese](https://github.com/mauriliogenovese))
43+
44+
345
## [v0.4.1](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v0.4.1) (2025/02/04)
446

547
[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/compare/v0.4.0...v0.4.1)

‎changelog.txt

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,46 @@
1+
VERSION[0.5.0][12/02/2025]
2+
3+
--- New to Path of Building ---
4+
* Add Support for Ailment chance calculations (LocalIdentity, OrderedSet86)
5+
* Scale base Shock calculation by shock effect mods on tree and gear (LocalIdentity)
6+
* Use count to set number of active Minions for Reservation calculations (mauriliogenovese)
7+
* Add support for Armour Break (majochem)
8+
* Add support for Blasphemy reserving Spirit (Paliak)
9+
* Add support for Vulnerability" ignore x Armour" mod (majochem)
10+
* Add support for War Banner and Defiance Banner (Blitz54)
11+
* Add support for Rolling Slam "more damage against heavy stunned enemies" (Blitz54)
12+
* Add support for Acolyte of Chayula Darkness Ascendancy (MrHB212)
13+
* Add support for "I Am The Thunder..." and "I Am The Blizzard..." (madxmike)
14+
* Add support for Pinned recently (Blitz54)
15+
* Add Support for extra Exposure (MrHB212)
16+
* Add parsing for "Your speed is unaffected by Slows" (RealWhimsy)
17+
* Add Support for "Slam skills have +% increased Area of Effect" (MrHB212)
18+
* Add support for "against enemies within/further than" (Blitz54)
19+
* Add support for ignore Warcry Cooldown (MrHB212)
20+
* Add support for "Electrocution" tree mods (Blitz54)
21+
* Add support for Break Armour on Critical Hit with Spells (majochem)
22+
* Add support for Gamblesprint movement speed (Blitz54)
23+
* Add support for Dustbloom Life regen (Blitz54)
24+
* Add support for Vile Knight enemy in presence Duration mod (Blitz54)
25+
26+
--- Fixed Crashes ---
27+
* Fix crash from importing item with Mana leech mods (nessgor)
28+
29+
--- User Interface ---
30+
* Fix the highlight node circle being too small (LocalIdentity)
31+
32+
--- Fixed Calculations ---
33+
* Incorrect rounding for Reservation calculations (nessgor)
34+
* Fix calculation of Leech passive nodes (MrHB212)
35+
* Fix comparison tooltips for builds with Time-Lost Jewels (Peechey)
36+
37+
--- Fixed Behaviours ---
38+
* Fix "Critical strike in last 8 seconds" mods always applying instead of using a config (MrHB212)
39+
40+
--- Accuracy Improvements ---
41+
* Update Time-Lost Jewel affixes with proper wording (Peechey)
42+
* Fix duplicate skill for Greater Lightning Bolt and Decompose (mauriliogenovese)
43+
144
VERSION[0.4.1][2025/02/04]
245
--- Fixed Crashes ---
346
* Fix crash due to missing DLL (Wires77)

‎manifest.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ exclude-directories = src/Export,src/TreeData,src/Builds,src/luacov.stats.out,sr
1515

1616
[tree]
1717
path = src
18-
exclude-files = export_lines.bat,extract_lines.scm,log_lines_extract.txt,script_lines_extract_orbitactive.scm,script_lines_extract_orbitintemediate.scm,script_lines_extract_orbitnormal.scm,missingStats.txt
18+
exclude-files = export_lines.bat,extract_lines.scm,log_lines_extract.txt,script_lines_extract_orbit_active.scm,script_lines_extract_orbit_intermediate.scm,script_lines_extract_orbit_normal.scm,missingStats.txt
1919
include-directories = src/TreeData

‎manifest.xml

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version='1.0' encoding='UTF-8'?>
22
<PoBVersion>
3-
<Version number="0.4.0" />
3+
<Version number="0.5.0" />
44
<Source part="default" url="https://raw.githubusercontent.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/{branch}/" />
55
<Source part="runtime" platform="win32" url="https://raw.githubusercontent.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/{branch}/runtime/" />
66
<Source part="program" url="https://raw.githubusercontent.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/{branch}/src/" />
@@ -546,8 +546,8 @@
546546
<File name="TreeData/0_1/group-background_756_756_BC7.dds.zst" part="tree" sha1="4693658151e36cdeadfefa1624ac3377a6dfaab7" />
547547
<File name="TreeData/0_1/group-background_952_988_BC7.dds.zst" part="tree" sha1="de711bc6fbcbd383a0b7c436d22afd0caca72d6e" />
548548
<File name="TreeData/0_1/group-background_1000_508_BC7.dds.zst" part="tree" sha1="c243630f8caae501447f772addd2e46c454fd912" />
549-
<File name="TreeData/0_1/jewelsockets_152_156_BC7.dds.zst" part="tree" sha1="14cbee1366257f9f29c90f439dab8b3bd9844718" />
550-
<File name="TreeData/0_1/jewelsockets_208_208_BC7.dds.zst" part="tree" sha1="ec025e1e282d6382637d869ea2ad61903f8a385f" />
549+
<File name="TreeData/0_1/jewel-sockets_152_156_BC7.dds.zst" part="tree" sha1="14cbee1366257f9f29c90f439dab8b3bd9844718" />
550+
<File name="TreeData/0_1/jewel-sockets_208_208_BC7.dds.zst" part="tree" sha1="ec025e1e282d6382637d869ea2ad61903f8a385f" />
551551
<File name="TreeData/0_1/legion_64_64_BC1.dds.zst" part="tree" sha1="57780219eb8c0f839ff1954d511983c7c7cae656" />
552552
<File name="TreeData/0_1/legion_128_128_BC1.dds.zst" part="tree" sha1="a8e4aa7b6fbc7e9d1666bd91c9113c804d0d6fa8" />
553553
<File name="TreeData/0_1/legion_564_564_BC7.dds.zst" part="tree" sha1="bb68096499abd163de7727034be292ba4d5d61aa" />
@@ -557,36 +557,36 @@
557557
<File name="TreeData/0_1/lines_1940_1940_BC7.dds.zst" part="tree" sha1="8b8d6cf89ca4bda8c0b785f706962d9ab39b9e2b" />
558558
<File name="TreeData/0_1/mastery-active-effect_776_768_BC7.dds.zst" part="tree" sha1="8b9f986fb49df4bbeec38269997e30eaaaef562d" />
559559
<File name="TreeData/0_1/oils_108_108_RGBA.dds.zst" part="tree" sha1="abf58ace0c8b9987d7b2d9b79dc047226c970a50" />
560-
<File name="TreeData/0_1/orbitactive0.png" part="tree" sha1="c17c7c0682240494614ccc3dd183a0ca9aca2cc4" />
561-
<File name="TreeData/0_1/orbitactive1.png" part="tree" sha1="182cf3b511e0c3351c6893008b284fd9cd3b82f8" />
562-
<File name="TreeData/0_1/orbitactive2.png" part="tree" sha1="5fce3cc77cfc325eb495d72529f080941cf0036c" />
563-
<File name="TreeData/0_1/orbitactive3.png" part="tree" sha1="23fa36975a975295f699f4fe69cba286e39f7b1d" />
564-
<File name="TreeData/0_1/orbitactive4.png" part="tree" sha1="efb316bce82e32f1bfc5962557d60a1aa51593bb" />
565-
<File name="TreeData/0_1/orbitactive5.png" part="tree" sha1="2355ac517d5d16dc7fac4be67efc69471f06ff85" />
566-
<File name="TreeData/0_1/orbitactive6.png" part="tree" sha1="2021dde3435b3b9187b4c5384bc6b9af45201c8d" />
567-
<File name="TreeData/0_1/orbitactive7.png" part="tree" sha1="d3bf38c8a19ccf53eaab61201ee7f9cdfde288ed" />
568-
<File name="TreeData/0_1/orbitactive8.png" part="tree" sha1="cf0a2d180dc561a0c514bde64f173728209ee141" />
569-
<File name="TreeData/0_1/orbitactive9.png" part="tree" sha1="25374c4ea9ddef7af2671d85a762242d22763060" />
570-
<File name="TreeData/0_1/orbitintemediate0.png" part="tree" sha1="e4d2aba19e88a6a70d76248fd3a8dcc31563795d" />
571-
<File name="TreeData/0_1/orbitintemediate1.png" part="tree" sha1="25cc1b849c7462f346885c56c309ba8c470f5c3b" />
572-
<File name="TreeData/0_1/orbitintemediate2.png" part="tree" sha1="be81b097e0aac09868d67bba6101dc7a463b65f2" />
573-
<File name="TreeData/0_1/orbitintemediate3.png" part="tree" sha1="f4fc716133d741c6fd81fa6831a9caf37ace4f3b" />
574-
<File name="TreeData/0_1/orbitintemediate4.png" part="tree" sha1="b397dd785899c1f4b7083fc33a37c7071037836e" />
575-
<File name="TreeData/0_1/orbitintemediate5.png" part="tree" sha1="31809aafddec8ef88eaf33b48e564cc8e300ed05" />
576-
<File name="TreeData/0_1/orbitintemediate6.png" part="tree" sha1="0b41329c5ee3e73756a05c01be7bc6c8c21ecf02" />
577-
<File name="TreeData/0_1/orbitintemediate7.png" part="tree" sha1="b6d94b7824fa65cd06df24548b49cd4884ec9e51" />
578-
<File name="TreeData/0_1/orbitintemediate8.png" part="tree" sha1="e56ea575cbffda91aa8f1309edab0a0828a8a3ae" />
579-
<File name="TreeData/0_1/orbitintemediate9.png" part="tree" sha1="d1eb7291dcc5a1fd6126a19ec07451d45764c6ba" />
580-
<File name="TreeData/0_1/orbitnormal0.png" part="tree" sha1="d4508db82db53063d50750d3ba9d97dad27bd13b" />
581-
<File name="TreeData/0_1/orbitnormal1.png" part="tree" sha1="bca7b52d00475e9e64812caeb8066072c64dd601" />
582-
<File name="TreeData/0_1/orbitnormal2.png" part="tree" sha1="691057a335256406ac324d836ba6a09b05ec00f2" />
583-
<File name="TreeData/0_1/orbitnormal3.png" part="tree" sha1="c45792c111142135c18dcc9d58d3654c88c70687" />
584-
<File name="TreeData/0_1/orbitnormal4.png" part="tree" sha1="64bff9325467cf8266af8112758c64ec4f4ed0fb" />
585-
<File name="TreeData/0_1/orbitnormal5.png" part="tree" sha1="44bd2eafbbeea02171e5e6888aa12cdb34522b53" />
586-
<File name="TreeData/0_1/orbitnormal6.png" part="tree" sha1="e4f3c73cfe00f1c61d7e321c9f1ccb03149bf3d5" />
587-
<File name="TreeData/0_1/orbitnormal7.png" part="tree" sha1="8f9bdd89396d66eb098ac6fa5554d051674dbd41" />
588-
<File name="TreeData/0_1/orbitnormal8.png" part="tree" sha1="88611a0daf1fb9618f022ab651bb44a82232aab6" />
589-
<File name="TreeData/0_1/orbitnormal9.png" part="tree" sha1="a689c028ab279085c65a6d291a124442492dab92" />
560+
<File name="TreeData/0_1/orbit_active0.png" part="tree" sha1="c17c7c0682240494614ccc3dd183a0ca9aca2cc4" />
561+
<File name="TreeData/0_1/orbit_active1.png" part="tree" sha1="182cf3b511e0c3351c6893008b284fd9cd3b82f8" />
562+
<File name="TreeData/0_1/orbit_active2.png" part="tree" sha1="5fce3cc77cfc325eb495d72529f080941cf0036c" />
563+
<File name="TreeData/0_1/orbit_active3.png" part="tree" sha1="23fa36975a975295f699f4fe69cba286e39f7b1d" />
564+
<File name="TreeData/0_1/orbit_active4.png" part="tree" sha1="efb316bce82e32f1bfc5962557d60a1aa51593bb" />
565+
<File name="TreeData/0_1/orbit_active5.png" part="tree" sha1="2355ac517d5d16dc7fac4be67efc69471f06ff85" />
566+
<File name="TreeData/0_1/orbit_active6.png" part="tree" sha1="2021dde3435b3b9187b4c5384bc6b9af45201c8d" />
567+
<File name="TreeData/0_1/orbit_active7.png" part="tree" sha1="d3bf38c8a19ccf53eaab61201ee7f9cdfde288ed" />
568+
<File name="TreeData/0_1/orbit_active8.png" part="tree" sha1="cf0a2d180dc561a0c514bde64f173728209ee141" />
569+
<File name="TreeData/0_1/orbit_active9.png" part="tree" sha1="25374c4ea9ddef7af2671d85a762242d22763060" />
570+
<File name="TreeData/0_1/orbit_intermediate0.png" part="tree" sha1="e4d2aba19e88a6a70d76248fd3a8dcc31563795d" />
571+
<File name="TreeData/0_1/orbit_intermediate1.png" part="tree" sha1="25cc1b849c7462f346885c56c309ba8c470f5c3b" />
572+
<File name="TreeData/0_1/orbit_intermediate2.png" part="tree" sha1="be81b097e0aac09868d67bba6101dc7a463b65f2" />
573+
<File name="TreeData/0_1/orbit_intermediate3.png" part="tree" sha1="f4fc716133d741c6fd81fa6831a9caf37ace4f3b" />
574+
<File name="TreeData/0_1/orbit_intermediate4.png" part="tree" sha1="b397dd785899c1f4b7083fc33a37c7071037836e" />
575+
<File name="TreeData/0_1/orbit_intermediate5.png" part="tree" sha1="31809aafddec8ef88eaf33b48e564cc8e300ed05" />
576+
<File name="TreeData/0_1/orbit_intermediate6.png" part="tree" sha1="0b41329c5ee3e73756a05c01be7bc6c8c21ecf02" />
577+
<File name="TreeData/0_1/orbit_intermediate7.png" part="tree" sha1="b6d94b7824fa65cd06df24548b49cd4884ec9e51" />
578+
<File name="TreeData/0_1/orbit_intermediate8.png" part="tree" sha1="e56ea575cbffda91aa8f1309edab0a0828a8a3ae" />
579+
<File name="TreeData/0_1/orbit_intermediate9.png" part="tree" sha1="d1eb7291dcc5a1fd6126a19ec07451d45764c6ba" />
580+
<File name="TreeData/0_1/orbit_normal0.png" part="tree" sha1="d4508db82db53063d50750d3ba9d97dad27bd13b" />
581+
<File name="TreeData/0_1/orbit_normal1.png" part="tree" sha1="bca7b52d00475e9e64812caeb8066072c64dd601" />
582+
<File name="TreeData/0_1/orbit_normal2.png" part="tree" sha1="691057a335256406ac324d836ba6a09b05ec00f2" />
583+
<File name="TreeData/0_1/orbit_normal3.png" part="tree" sha1="c45792c111142135c18dcc9d58d3654c88c70687" />
584+
<File name="TreeData/0_1/orbit_normal4.png" part="tree" sha1="64bff9325467cf8266af8112758c64ec4f4ed0fb" />
585+
<File name="TreeData/0_1/orbit_normal5.png" part="tree" sha1="44bd2eafbbeea02171e5e6888aa12cdb34522b53" />
586+
<File name="TreeData/0_1/orbit_normal6.png" part="tree" sha1="e4f3c73cfe00f1c61d7e321c9f1ccb03149bf3d5" />
587+
<File name="TreeData/0_1/orbit_normal7.png" part="tree" sha1="8f9bdd89396d66eb098ac6fa5554d051674dbd41" />
588+
<File name="TreeData/0_1/orbit_normal8.png" part="tree" sha1="88611a0daf1fb9618f022ab651bb44a82232aab6" />
589+
<File name="TreeData/0_1/orbit_normal9.png" part="tree" sha1="a689c028ab279085c65a6d291a124442492dab92" />
590590
<File name="TreeData/0_1/skills-disabled_64_64_BC1.dds.zst" part="tree" sha1="4f638e1dafbfdce991769c72f46ff963561d7c3b" />
591591
<File name="TreeData/0_1/skills-disabled_88_88_BC1.dds.zst" part="tree" sha1="0947e7e4e7c0bd2269e0ba2f2636b6a4fa2ba554" />
592592
<File name="TreeData/0_1/skills-disabled_128_128_BC1.dds.zst" part="tree" sha1="6a2d7005ed1f6db59bcd85a617824910304771aa" />

‎spec/System/TestSkills_spec.lua

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,18 @@ describe("TestSkills", function()
77
-- newBuild() takes care of resetting everything in setup()
88
end)
99

10+
it("Test blasphemy reserving Spirit", function()
11+
build.skillsTab:PasteSocketGroup("Blasphemy 20/0 1\nDespair 20/0 1\n")
12+
runCallback("OnFrame")
13+
14+
local oneCurseReservation = build.calcsTab.mainOutput.SpiritReservedPercent
15+
assert.True(oneCurseReservation > 0)
16+
17+
newBuild()
18+
19+
build.skillsTab:PasteSocketGroup("Blasphemy 20/0 1\nDespair 20/0 1\nFlammability 20/0 1\n")
20+
runCallback("OnFrame")
21+
22+
assert.True(build.calcsTab.mainOutput.SpiritReservedPercent > oneCurseReservation)
23+
end)
1024
end)

‎src/Classes/ItemsTab.lua

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -707,9 +707,7 @@ holding Shift will put it in the second.]])
707707
end
708708

709709
-- Adding Mod
710-
self.build.treeTab.skipTimeLostJewelProcessing = true
711710
self:AddModComparisonTooltip(tooltip, mod)
712-
self.build.treeTab.skipTimeLostJewelProcessing = false
713711
end
714712
end
715713
end
@@ -1649,6 +1647,10 @@ function ItemsTabClass:UpdateAffixControl(control, item, type, outputTable, outp
16491647
if item.type == "Flask" then
16501648
label = mod.affix .. " ^8[" .. modString .. "]"
16511649
end
1650+
-- shorten time-lost jewel affix labels to fit the dropdown
1651+
if label and item.baseName:find("Time%-Lost") ~= nil then
1652+
label = label:gsub(" Passive Skills in Radius also grant", ":")
1653+
end
16521654
control.list[i + 1] = {
16531655
label = label,
16541656
modList = { modId },
@@ -3066,10 +3068,7 @@ function ItemsTabClass:AddItemTooltip(tooltip, item, slot, dbMode)
30663068
for _, compareSlot in pairs(compareSlots) do
30673069
if not main.slotOnlyTooltips or (slot and (slot.nodeId == compareSlot.nodeId or slot.slotName == compareSlot.slotName)) or not slot or slot == compareSlot then
30683070
local selItem = self.items[compareSlot.selItemId]
3069-
-- short term fix for Time-Lost jewel processing
3070-
self.build.treeTab.skipTimeLostJewelProcessing = true
30713071
local output = calcFunc({ repSlotName = compareSlot.slotName, repItem = item ~= selItem and item or nil})
3072-
self.build.treeTab.skipTimeLostJewelProcessing = false
30733072
local header
30743073
if item == selItem then
30753074
header = "^7Removing this item from "..compareSlot.label.." will give you:"

0 commit comments

Comments
 (0)