Skip to content

Commit 29b5a3c

Browse files
authored
Make Ice Bite work as intended (#508)
This commit also makes Innervate work similarly to Ice Bite in terms of how the stat map is written.
1 parent 051e051 commit 29b5a3c

File tree

5 files changed

+17
-12
lines changed

5 files changed

+17
-12
lines changed

src/Data/SkillStatMap.lua

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -947,9 +947,6 @@ return {
947947
["non_skill_base_all_damage_%_to_gain_as_fire_with_attacks_vs_burning_enemies"] = {
948948
mod("DamageGainAsFire", "BASE", nil, 0, 0, { type = "ActorCondition", actor = "enemy", var = "Burning" }),
949949
},
950-
["support_innervate_buff_grant_%_added_lightning_attack_damage"] = {
951-
mod("DamageGainAsLightning", "BASE", nil, ModFlag.Attack, 0, { type = "Condition", var = "KilledShockedLast3Seconds" }, { type = "GlobalEffect", effectType = "Buff", effectName = "Innervate" } ),
952-
},
953950
["base_physical_damage_%_to_convert_to_lightning"] = {
954951
mod("PhysicalDamageConvertToLightning", "BASE", nil),
955952
},
@@ -2293,7 +2290,7 @@ return {
22932290
mod("AdditionalCooldownUses", "BASE", nil)
22942291
},
22952292
["kill_enemy_on_hit_if_under_10%_life"] = {
2296-
mod("CullPercent", "MAX", nil),
2293+
mod("CullPercent", "MAX", nil),
22972294
value = 10
22982295
},
22992296
["spell_cast_time_added_to_cooldown_if_triggered"] = {

src/Data/Skills/sup_dex.lua

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -851,8 +851,12 @@ skills["SupportInnervatePlayer"] = {
851851
incrementalEffectiveness = 0.054999999701977,
852852
statDescriptionScope = "gem_stat_descriptions",
853853
statMap = {
854-
["support_innervate_buff_base_duration_ms"] = {
855-
-- Display only
854+
["support_innervate_buff_grant_%_added_lightning_attack_damage"] = {
855+
mod("DamageGainAsLightning", "BASE", nil, ModFlag.Attack, 0, { type = "Condition", var = "KilledShockedLast3Seconds" }, { type = "GlobalEffect", effectType = "Buff", effectName = "Innervate" }),
856+
},
857+
["support_innervate_base_buff_duration"] = {
858+
mod("Duration", "BASE", nil, 0, 0, { type = "Condition", var = "KilledShockedLast3Seconds" }, { type = "GlobalEffect", effectType = "Buff" }),
859+
div = 1000,
856860
},
857861
},
858862
baseFlags = {

src/Data/Skills/sup_int.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1892,10 +1892,10 @@ skills["SupportIceBitePlayer"] = {
18921892
statDescriptionScope = "gem_stat_descriptions",
18931893
statMap = {
18941894
["support_ice_bite_buff_grant_%_added_cold_attack_damage"] = {
1895-
mod("DamageGainAsCold", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Buff" }),
1895+
mod("DamageGainAsCold", "BASE", nil, ModFlag.Attack, 0, { type = "Condition", var = "FrozenEnemyRecently" }, { type = "GlobalEffect", effectType = "Buff", effectName = "Ice Bite" }),
18961896
},
18971897
["support_ice_bite_base_buff_duration"] = {
1898-
mod("Duration", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Buff" }),
1898+
mod("Duration", "BASE", nil, 0, 0, { type = "Condition", var = "FrozenEnemyRecently" }, { type = "GlobalEffect", effectType = "Buff" }),
18991899
div = 1000,
19001900
},
19011901
},

src/Export/Skills/sup_dex.txt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,12 @@ statMap = {
230230
#startSets
231231
#set SupportInnervatePlayer
232232
statMap = {
233-
["support_innervate_buff_base_duration_ms"] = {
234-
-- Display only
233+
["support_innervate_buff_grant_%_added_lightning_attack_damage"] = {
234+
mod("DamageGainAsLightning", "BASE", nil, ModFlag.Attack, 0, { type = "Condition", var = "KilledShockedLast3Seconds" }, { type = "GlobalEffect", effectType = "Buff", effectName = "Innervate" }),
235+
},
236+
["support_innervate_base_buff_duration"] = {
237+
mod("Duration", "BASE", nil, 0, 0, { type = "Condition", var = "KilledShockedLast3Seconds" }, { type = "GlobalEffect", effectType = "Buff" }),
238+
div = 1000,
235239
},
236240
},
237241
#mods

src/Export/Skills/sup_int.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -498,10 +498,10 @@ statMap = {
498498
#set SupportIceBitePlayer
499499
statMap = {
500500
["support_ice_bite_buff_grant_%_added_cold_attack_damage"] = {
501-
mod("DamageGainAsCold", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Buff" }),
501+
mod("DamageGainAsCold", "BASE", nil, ModFlag.Attack, 0, { type = "Condition", var = "FrozenEnemyRecently" }, { type = "GlobalEffect", effectType = "Buff", effectName = "Ice Bite" }),
502502
},
503503
["support_ice_bite_base_buff_duration"] = {
504-
mod("Duration", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Buff" }),
504+
mod("Duration", "BASE", nil, 0, 0, { type = "Condition", var = "FrozenEnemyRecently" }, { type = "GlobalEffect", effectType = "Buff" }),
505505
div = 1000,
506506
},
507507
},

0 commit comments

Comments
 (0)