Fix comparison tooltips for builds with Time-Lost Jewels (#709)

* remove old flag to skip processing time lost jewels on comparison

* spellchecker

Author: Peechey

src/Classes/ItemsTab.lua

@@ -707,9 +707,7 @@ holding Shift will put it in the second.]])
 					end
 
 					-- Adding Mod
-					self.build.treeTab.skipTimeLostJewelProcessing = true
 					self:AddModComparisonTooltip(tooltip, mod)
-					self.build.treeTab.skipTimeLostJewelProcessing = false
 				end
 			end
 		end
@@ -3066,10 +3064,7 @@ function ItemsTabClass:AddItemTooltip(tooltip, item, slot, dbMode)
 		for _, compareSlot in pairs(compareSlots) do
 			if not main.slotOnlyTooltips or (slot and (slot.nodeId == compareSlot.nodeId or slot.slotName == compareSlot.slotName)) or not slot or slot == compareSlot then
 				local selItem = self.items[compareSlot.selItemId]
-				-- short term fix for Time-Lost jewel processing
-				self.build.treeTab.skipTimeLostJewelProcessing = true
 				local output = calcFunc({ repSlotName = compareSlot.slotName, repItem = item ~= selItem and item or nil})
-				self.build.treeTab.skipTimeLostJewelProcessing = false
 				local header
 				if item == selItem then
 					header = "^7Removing this item from "..compareSlot.label.." will give you:"

src/Classes/TreeTab.lua

@@ -32,7 +32,6 @@ local TreeTabClass = newClass("TreeTab", "ControlHost", function(self, build)
 	self.specList[1] = new("PassiveSpec", build, latestTreeVersion)
 	self:SetActiveSpec(1)
 	self:SetCompareSpec(1)
-	self.skipTimeLostJewelProcessing = false
 
 	self.anchorControls = new("Control", nil, {0, 0, 0, 20})
 
@@ -162,7 +161,7 @@ local TreeTabClass = newClass("TreeTab", "ControlHost", function(self, build)
 
 	self.tradeLeaguesList = { }
 	-- Find Timeless Jewel Button
-	-- Add button back if/when we figure out how to serch for them again
+	-- Add button back if/when we figure out how to search for them again
 	--self.controls.findTimelessJewel = new("ButtonControl", { "LEFT", self.controls.treeSearch, "RIGHT" }, { 8, 0, 150, 20 }, "Find Timeless Jewel", function()
 		--self:FindTimelessJewel()
 	--end)

src/Modules/CalcSetup.lua

@@ -126,13 +126,11 @@ function calcs.buildModListForNode(env, node, incSmallPassiveSkill)
 		if rad.type == "Other" and rad.nodes[node.id] and rad.nodes[node.id].type ~= "Mastery" then
 			if rad.item.baseName:find("Time%-Lost") == nil then
 				rad.func(node, modList, rad.data)
-			elseif not node.isAttribute and (node.type == "Normal" or node.type == "Notable") and not env.build.treeTab.skipTimeLostJewelProcessing then
+			elseif not node.isAttribute and (node.type == "Normal" or node.type == "Notable") then
 				local cache = GlobalCache.cachedData[env.mode].radiusJewelData[rad.nodeId]
 				if not cache or (cache.hash ~= rad.jewelHash) then
 					refreshJewelStatCache(env)
 				end
-				-- too aggressive, need to account for scaled values and not just size of lists
-				--and #node.finalModList == #env.build.spec.tree.nodes[node.id].modList then
 				if node.type == "Normal" and cache and #cache.smallModList > 0 then
 					modList:AddList(cache.smallModList)
 				elseif node.type == "Notable" and cache and #cache.notableModList > 0 then