Skip to content

Commit 8c660a0

Browse files
authored
[BugFix] fix RMSNorm rms_norm_esp (#2797)
* fix rms * add vl * fix * add vl * fix * fix
1 parent ce5adec commit 8c660a0

File tree

8 files changed

+18
-17
lines changed

8 files changed

+18
-17
lines changed

fastdeploy/config.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ def __init__(
8484
head_dim: Optional[int] = None,
8585
tie_word_embeddings: bool = False,
8686
is_quantized: bool = False,
87+
rms_norm_eps: float = 1e-5,
8788
**kwargs,
8889
):
8990
super().__init__(**kwargs)
@@ -123,6 +124,7 @@ def __init__(
123124
self.dtype = dtype
124125
self.tie_word_embeddings = tie_word_embeddings
125126
self.is_quantized = is_quantized
127+
self.rms_norm_eps = rms_norm_eps
126128

127129

128130
@dataclass

fastdeploy/model_executor/models/ernie4_5_moe.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -288,14 +288,14 @@ def __init__(
288288
self.input_layernorm = RMSNorm(
289289
fd_config,
290290
hidden_size=fd_config.model_config.hidden_size,
291-
eps=1e-5,
291+
eps=fd_config.model_config.rms_norm_eps,
292292
prefix=f"{prefix}.input_layernorm",
293293
)
294294

295295
self.post_attention_layernorm = RMSNorm(
296296
fd_config,
297297
hidden_size=fd_config.model_config.hidden_size,
298-
eps=1e-5,
298+
eps=fd_config.model_config.rms_norm_eps,
299299
prefix=f"{prefix}.post_attention_layernorm",
300300
)
301301

@@ -366,7 +366,7 @@ def __init__(
366366
self.norm = RMSNorm(
367367
fd_config,
368368
hidden_size=fd_config.model_config.hidden_size,
369-
eps=1e-5,
369+
eps=fd_config.model_config.rms_norm_eps,
370370
prefix=f"{fd_config.model_config.prefix_name}.norm",
371371
)
372372

fastdeploy/model_executor/models/ernie4_5_mtp.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,14 +275,14 @@ def __init__(
275275
self.enorm = RMSNorm(
276276
fd_config,
277277
hidden_size=fd_config.model_config.hidden_size,
278-
eps=1e-5,
278+
eps=fd_config.model_config.rms_norm_eps,
279279
prefix="ernie.mtp_emb_norm.0",
280280
)
281281

282282
self.hnorm = RMSNorm(
283283
fd_config,
284284
hidden_size=fd_config.model_config.hidden_size,
285-
eps=1e-5,
285+
eps=fd_config.model_config.rms_norm_eps,
286286
prefix="ernie.mtp_hidden_norm.0",
287287
)
288288

fastdeploy/model_executor/models/ernie4_5_vl/ernie4_5_vl_moe.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,14 +273,14 @@ def __init__(
273273
self.input_layernorm = RMSNorm(
274274
fd_config,
275275
hidden_size=fd_config.model_config.hidden_size,
276-
eps=1e-5,
276+
eps=fd_config.model_config.rms_norm_eps,
277277
prefix=f"{prefix}.input_layernorm",
278278
)
279279

280280
self.post_attention_layernorm = RMSNorm(
281281
fd_config,
282282
hidden_size=fd_config.model_config.hidden_size,
283-
eps=1e-5,
283+
eps=fd_config.model_config.rms_norm_eps,
284284
prefix=f"{prefix}.post_attention_layernorm",
285285
)
286286

@@ -358,7 +358,7 @@ def __init__(
358358
self.norm = RMSNorm(
359359
fd_config,
360360
hidden_size=fd_config.model_config.hidden_size,
361-
eps=1e-5,
361+
eps=fd_config.model_config.rms_norm_eps,
362362
prefix=f"{fd_config.model_config.prefix_name}.norm",
363363
)
364364

fastdeploy/model_executor/models/qwen2.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,14 +161,14 @@ def __init__(
161161
self.input_layernorm = RMSNorm(
162162
fd_config,
163163
hidden_size=fd_config.model_config.hidden_size,
164-
eps=1e-6,
164+
eps=fd_config.model_config.rms_norm_eps,
165165
prefix=f"{prefix}.input_layernorm",
166166
)
167167

168168
self.post_attention_layernorm = RMSNorm(
169169
fd_config,
170170
hidden_size=fd_config.model_config.hidden_size,
171-
eps=1e-6,
171+
eps=fd_config.model_config.rms_norm_eps,
172172
prefix=f"{prefix}.post_attention_layernorm",
173173
)
174174

@@ -248,7 +248,7 @@ def __init__(
248248
self.norm = RMSNorm(
249249
fd_config,
250250
hidden_size=fd_config.model_config.hidden_size,
251-
eps=1e-5,
251+
eps=fd_config.model_config.rms_norm_eps,
252252
prefix=f"{fd_config.model_config.prefix_name}.norm",
253253
)
254254

fastdeploy/model_executor/models/qwen3.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,12 @@ def __init__(self,
7979

8080
self.q_norm = RMSNorm(fd_config=fd_config,
8181
hidden_size=fd_config.model_config.head_dim,
82-
eps=1e-6,
82+
eps=fd_config.model_config.rms_norm_eps,
8383
prefix=f"{prefix}.q_norm",
8484
begin_norm_axis=2)
8585
self.k_norm = RMSNorm(fd_config=fd_config,
8686
hidden_size=fd_config.model_config.head_dim,
87-
eps=1e-6,
87+
eps=fd_config.model_config.rms_norm_eps,
8888
prefix=f"{prefix}.k_norm",
8989
begin_norm_axis=2)
9090

@@ -183,7 +183,7 @@ def __init__(
183183
self.norm = RMSNorm(
184184
fd_config,
185185
hidden_size=fd_config.model_config.hidden_size,
186-
eps=1e-6,
186+
eps=fd_config.model_config.rms_norm_eps,
187187
prefix=f"{fd_config.model_config.prefix_name}.norm",
188188
)
189189

fastdeploy/model_executor/models/qwen3moe.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,12 @@ def __init__(self,
121121

122122
self.q_norm = RMSNorm(fd_config,
123123
hidden_size=self.head_dim,
124-
eps=1e-6,
124+
eps=fd_config.model_config.rms_norm_eps,
125125
prefix=f"{prefix}.q_norm",
126126
begin_norm_axis=2)
127127
self.k_norm = RMSNorm(fd_config,
128128
hidden_size=self.head_dim,
129-
eps=1e-6,
129+
eps=fd_config.model_config.rms_norm_eps,
130130
prefix=f"{prefix}.k_norm",
131131
begin_norm_axis=2)
132132

fastdeploy/worker/worker_process.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,6 @@ def initialize_fd_config(config_or_args) -> FDConfig:
594594
model_config_dict, _ = ModelConfig.get_config_dict(config_or_args.model_name_or_path)
595595

596596

597-
598597
# Handle MoE related configs
599598
if 'num_experts' in model_config_dict:
600599
model_config_dict['moe_num_experts'] = model_config_dict.pop('num_experts')

0 commit comments

Comments
 (0)