fix the issue that vtables are created twice, fix the debug issue

Author: ghaith

compiler/plc_driver/src/pipelines/participant.rs

@@ -341,7 +341,6 @@ impl PipelineParticipantMut for VTableIndexer {
             let vtable = Self::create_vtable(pou.get_name(), methods, pou.get_location().clone());
             vtables.push(vtable);
         }
-
         project.units.first_mut().unwrap().user_types.extend(vtables);
         project.index(self.id_provider.clone())
     }

src/codegen/debug.rs

@@ -20,7 +20,9 @@ use plc_source::source_location::SourceLocation;
 
 use crate::{
     index::{Index, PouIndexEntry, VariableIndexEntry},
-    typesystem::{DataType, DataTypeInformation, Dimension, StringEncoding, CHAR_TYPE, WCHAR_TYPE},
+    typesystem::{
+        DataType, DataTypeInformation, Dimension, StringEncoding, CHAR_TYPE, VOID_INTERNAL_NAME, WCHAR_TYPE,
+    },
     DebugLevel, OptimizationLevel,
 };
 
@@ -455,7 +457,21 @@ impl<'ink> DebugBuilder<'ink> {
         types_index: &LlvmTypedIndex,
     ) -> Result<(), Diagnostic> {
         let inner_type = index.get_type(inner_type)?;
-        let inner_type = self.get_or_create_debug_type(inner_type, index, types_index)?;
+        //Skip void pointers debug info
+        let inner_type = if inner_type.is_void() {
+            DebugType::Basic(
+                self.debug_info
+                    .create_basic_type(
+                        VOID_INTERNAL_NAME,
+                        0,
+                        DebugEncoding::DW_ATE_unsigned as u32,
+                        DIFlagsConstants::PUBLIC,
+                    )
+                    .map_err(|err| Diagnostic::codegen_error(err, SourceLocation::undefined()))?,
+            )
+        } else {
+            self.get_or_create_debug_type(inner_type, index, types_index)?
+        };
         let llvm_type = types_index.get_associated_type(name)?;
         let align_bits = self.target_data.get_preferred_alignment(&llvm_type) * 8;
         let pointer_type = self.debug_info.create_pointer_type(

src/codegen/generators/data_type_generator.rs

@@ -74,24 +74,14 @@ pub fn generate_data_types<'ink>(
                 types.push((dep.get_name(), datatype))
             }
         }
-
-        if let Some(datatype) = dep.get_vtable(index) {
-            if !datatype.get_type_information().is_generic(index) {
-                types.push((datatype.get_name(), datatype))
-            }
-        }
     }
 
     let mut generator =
         DataTypeGenerator { llvm, debug, index, annotations, types_index: LlvmTypedIndex::default() };
 
-    // dbg!(&types);
     // first create all STUBs for struct types (empty structs)
     // and associate them in the llvm index
     for (name, user_type) in &types {
-        if *name == "__vtable_fb" {
-            eprintln!("hi")
-        }
         if let DataTypeInformation::Struct { name: struct_name, .. } = user_type.get_type_information() {
             generator.types_index.associate_type(name, llvm.create_struct_stub(struct_name).into())?;
         }
@@ -201,7 +191,6 @@ impl<'ink> DataTypeGenerator<'ink, '_> {
             .map(BasicTypeEnum::into_struct_type)?;
 
             struct_type.set_body(members.as_slice(), false);
-            dbg!(&struct_type);
         }
         Ok(())
     }
@@ -318,7 +307,6 @@ impl<'ink> DataTypeGenerator<'ink, '_> {
                 }?
                 .into_struct_type();
 
-                eprintln!("Init for : {}", data_type.get_name());
                 Ok(Some(struct_type.const_named_struct(&member_values).as_basic_value_enum()))
             }
             DataTypeInformation::Array { .. } => self.generate_array_initializer(