fix: (Some) validations for internal types

Author: volsa

src/validation/recursive.rs

@@ -165,7 +165,8 @@ impl CycleDetector for CycleInvestigator<DataType> {
         let mut nodes_visited = FxIndexSet::default();
 
         // Structs (includes arrays defined in structs)
-        nodes_all.extend(index.get_types().values().filter(|x| x.get_type_information().is_struct()));
+        nodes_all
+            .extend(index.get_types().values().filter(|dt| dt.is_struct() && !dt.location.is_internal()));
 
         // Function Blocks
         nodes_all.extend(index.get_pou_types().values().filter(|x| {

src/validation/types.rs

@@ -15,6 +15,10 @@ pub fn visit_data_type_declaration<T: AnnotationMap>(
     declaration: &DataTypeDeclaration,
     context: &ValidationContext<T>,
 ) {
+    if declaration.get_location().is_internal() {
+        return;
+    }
+
     match declaration {
         DataTypeDeclaration::Reference { referenced_type, location } => {
             if context.index.find_effective_type_by_name(referenced_type).is_none() {

tests/integration/snapshots/tests__integration__cfc__ir__conditional_return.snap

@@ -2,8 +2,10 @@
 source: tests/integration/cfc.rs
 expression: output_file_content_without_headers
 ---
+%__vtable_conditional_return = type {}
 %conditional_return = type { i32 }
 
+@____vtable_conditional_return__init = external global %__vtable_conditional_return
 @__conditional_return__init = constant %conditional_return zeroinitializer
 @llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 0, void ()* @__init___plc, i8* null }]
 
@@ -22,6 +24,13 @@ else_block:                                       ; preds = %entry
   ret void
 }
 
+define void @__init___vtable_conditional_return(%__vtable_conditional_return* %0) {
+entry:
+  %self = alloca %__vtable_conditional_return*, align 8
+  store %__vtable_conditional_return* %0, %__vtable_conditional_return** %self, align 8
+  ret void
+}
+
 define void @__init_conditional_return(%conditional_return* %0) {
 entry:
   %self = alloca %conditional_return*, align 8

tests/integration/snapshots/tests__integration__cfc__ir__conditional_return_evaluating_true.snap

@@ -2,8 +2,10 @@
 source: tests/integration/cfc.rs
 expression: output_file_content_without_headers
 ---
+%__vtable_conditional_return = type {}
 %conditional_return = type { i32 }
 
+@____vtable_conditional_return__init = external global %__vtable_conditional_return
 @__conditional_return__init = constant %conditional_return zeroinitializer
 @llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 0, void ()* @__init___plc, i8* null }]
 
@@ -46,6 +48,13 @@ else_block:                                       ; preds = %entry
   ret void
 }
 
+define void @__init___vtable_conditional_return(%__vtable_conditional_return* %0) {
+entry:
+  %self = alloca %__vtable_conditional_return*, align 8
+  store %__vtable_conditional_return* %0, %__vtable_conditional_return** %self, align 8
+  ret void
+}
+
 define void @__init_conditional_return(%conditional_return* %0) {
 entry:
   %self = alloca %conditional_return*, align 8

tests/integration/snapshots/tests__integration__cfc__ir__conditional_return_evaluating_true_negated.snap

@@ -2,8 +2,10 @@
 source: tests/integration/cfc.rs
 expression: output_file_content_without_headers
 ---
+%__vtable_conditional_return = type {}
 %conditional_return = type { i32 }
 
+@____vtable_conditional_return__init = external global %__vtable_conditional_return
 @__conditional_return__init = constant %conditional_return zeroinitializer
 @llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 0, void ()* @__init___plc, i8* null }]
 
@@ -47,6 +49,13 @@ else_block:                                       ; preds = %entry
   ret void
 }
 
+define void @__init___vtable_conditional_return(%__vtable_conditional_return* %0) {
+entry:
+  %self = alloca %__vtable_conditional_return*, align 8
+  store %__vtable_conditional_return* %0, %__vtable_conditional_return** %self, align 8
+  ret void
+}
+
 define void @__init_conditional_return(%conditional_return* %0) {
 entry:
   %self = alloca %conditional_return*, align 8