getDataLabel defends against empty labels

yfinkel · web-flow · commit f3693406ed12 · 2024-06-28T10:49:56.000+04:00
diff --git a/src/PhpSpreadsheet/Chart/Renderer/JpGraphRendererBase.php b/src/PhpSpreadsheet/Chart/Renderer/JpGraphRendererBase.php
@@ -286,9 +286,8 @@ private function getDataLabel(int $groupId, int $index): mixed
         $plotLabel = $this->chart->getPlotArea()->getPlotGroupByIndex($groupId)->getPlotLabelByIndex($index);
         if (!$plotLabel) {
             return '';
-        } else {
-            return $plotLabel->getDataValue();
         }
+        return $plotLabel->getDataValue();
     }
 
     private function renderPlotLine(int $groupID, bool $filled = false, bool $combination = false): void

Original file line number	Diff line number	Diff line change
`@@ -286,9 +286,8 @@ private function getDataLabel(int $groupId, int $index): mixed`
`286`	`286`	`$plotLabel = $this->chart->getPlotArea()->getPlotGroupByIndex($groupId)->getPlotLabelByIndex($index);`
`287`	`287`	`if (!$plotLabel) {`
`288`	`288`	`return '';`
`289`		`- } else {`
`290`		`- return $plotLabel->getDataValue();`
`291`	`289`	`}`
	`290`	`+ return $plotLabel->getDataValue();`
`292`	`291`	`}`
`293`	`292`
`294`	`293`	`private function renderPlotLine(int $groupID, bool $filled = false, bool $combination = false): void`