PHP deprecation resolution

Author: MarkBaker

phpstan-baseline.neon

@@ -155,6 +155,11 @@ parameters:
 			count: 1
 			path: src/PhpSpreadsheet/Calculation/Calculation.php
 
+		-
+			message: "#^Result of && is always false\\.$#"
+			count: 1
+			path: src/PhpSpreadsheet/Calculation/Calculation.php
+
 		-
 			message: "#^Static property PhpOffice\\\\PhpSpreadsheet\\\\Calculation\\\\Calculation\\:\\:\\$instance \\(PhpOffice\\\\PhpSpreadsheet\\\\Calculation\\\\Calculation\\) in isset\\(\\) is not nullable\\.$#"
 			count: 1
@@ -1100,6 +1105,11 @@ parameters:
 			count: 1
 			path: src/PhpSpreadsheet/Cell/Coordinate.php
 
+		-
+			message: "#^Cannot use array destructuring on array\\<string\\>\\|string\\.$#"
+			count: 2
+			path: src/PhpSpreadsheet/Cell/Coordinate.php
+
 		-
 			message: "#^Parameter \\#4 \\$currentRow of static method PhpOffice\\\\PhpSpreadsheet\\\\Cell\\\\Coordinate\\:\\:validateRange\\(\\) expects int, string given\\.$#"
 			count: 1
@@ -2221,7 +2231,7 @@ parameters:
 			path: src/PhpSpreadsheet/Reader/Xls.php
 
 		-
-			message: "#^Parameter \\#1 \\$var of function count expects array\\|Countable, array\\<string\\>\\|string given\\.$#"
+			message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, array\\<string\\>\\|string given\\.$#"
 			count: 1
 			path: src/PhpSpreadsheet/Reader/Xls.php
 
@@ -4052,7 +4062,7 @@ parameters:
 
 		-
 			message: "#^Cannot use array destructuring on array\\<string\\>\\|string\\.$#"
-			count: 1
+			count: 2
 			path: src/PhpSpreadsheet/Worksheet/AutoFilter.php
 
 		-
@@ -4110,6 +4120,16 @@ parameters:
 			count: 1
 			path: src/PhpSpreadsheet/Worksheet/SheetView.php
 
+		-
+			message: "#^Cannot use array destructuring on array\\<string\\>\\|string\\.$#"
+			count: 1
+			path: src/PhpSpreadsheet/Worksheet/Table.php
+
+		-
+			message: "#^Cannot use array destructuring on array\\<string\\>\\|string\\.$#"
+			count: 2
+			path: src/PhpSpreadsheet/Worksheet/Validations.php
+
 		-
 			message: "#^Cannot call method getCalculatedValue\\(\\) on PhpOffice\\\\PhpSpreadsheet\\\\Cell\\\\Cell\\|null\\.$#"
 			count: 1
@@ -4141,18 +4161,18 @@ parameters:
 			path: src/PhpSpreadsheet/Worksheet/Worksheet.php
 
 		-
-			message: "#^Cannot use array destructuring on array\\<string\\>\\|string\\.$#"
+			message: "#^If condition is always true\\.$#"
 			count: 2
 			path: src/PhpSpreadsheet/Worksheet/Worksheet.php
 
 		-
-			message: "#^If condition is always true\\.$#"
+			message: "#^Left side of && is always true\\.$#"
 			count: 2
 			path: src/PhpSpreadsheet/Worksheet/Worksheet.php
 
 		-
-			message: "#^Left side of && is always true\\.$#"
-			count: 2
+			message: "#^Method PhpOffice\\\\PhpSpreadsheet\\\\Worksheet\\\\Worksheet\\:\\:extractSheetTitle\\(\\) should return array\\<string\\>\\|string but returns array\\<int, null\\>\\|null\\.$#"
+			count: 1
 			path: src/PhpSpreadsheet/Worksheet/Worksheet.php
 
 		-

src/PhpSpreadsheet/Writer/Xlsx/Worksheet.php

@@ -1329,7 +1329,7 @@ private function writeCellFormula(XMLWriter $objWriter, string $cellValue, Cell
             $objWriter,
             $this->getParentWriter()->getOffice2003Compatibility() === false,
             'v',
-            ($this->getParentWriter()->getPreCalculateFormulas() && !is_array($calculatedValue) && substr($calculatedValue, 0, 1) !== '#')
+            ($this->getParentWriter()->getPreCalculateFormulas() && !is_array($calculatedValue) && substr($calculatedValue ?? '', 0, 1) !== '#')
                 ? StringHelper::formatNumber($calculatedValue) : '0'
         );
     }