Skip to content

Commit db602bd

Browse files
authored
Merge branch 'master' into issue4001
2 parents d40a1cf + 8485cd1 commit db602bd

File tree

18 files changed

+680
-88
lines changed

18 files changed

+680
-88
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
2222

2323
### Deprecated
2424

25-
- Nothing
25+
- Reader/Xml trySimpleXMLLoadString should not have had public visibility, and will be removed.
2626

2727
### Removed
2828

@@ -42,6 +42,9 @@ and this project adheres to [Semantic Versioning](https://semver.org).
4242
- Invalid Builtin Defined Name in Xls Reader [Issue #3935](https://github.com/PHPOffice/PhpSpreadsheet/issues/3935) [PR #3942](https://github.com/PHPOffice/PhpSpreadsheet/pull/3942)
4343
- Hidden Rows and Columns Tcpdf/Mpdf [PR #3945](https://github.com/PHPOffice/PhpSpreadsheet/pull/3945)
4444
- Protect Sheet But Allow Sort [Issue #3951](https://github.com/PHPOffice/PhpSpreadsheet/issues/3951) [PR #3956](https://github.com/PHPOffice/PhpSpreadsheet/pull/3956)
45+
- Default Value for Conditional::$text [PR #3946](https://github.com/PHPOffice/PhpSpreadsheet/pull/3946)
46+
- Table Filter Buttons [Issue #3988](https://github.com/PHPOffice/PhpSpreadsheet/issues/3988) [PR #3992](https://github.com/PHPOffice/PhpSpreadsheet/pull/3992)
47+
- Improvements to Xml Reader [Issue #3999](https://github.com/PHPOffice/PhpSpreadsheet/issues/3999) [Issue #4000](https://github.com/PHPOffice/PhpSpreadsheet/issues/4000) [Issue #4002](https://github.com/PHPOffice/PhpSpreadsheet/issues/4002) [PR #4003](https://github.com/PHPOffice/PhpSpreadsheet/pull/4003)
4548

4649
## 2.0.0 - 2024-01-04
4750

composer.lock

Lines changed: 51 additions & 55 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/PhpSpreadsheet/Reader/Slk.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ private function addWidth(Spreadsheet $spreadsheet, string $columnWidth, string
404404
$endCol = Coordinate::stringFromColumnIndex((int) $endCol);
405405
$spreadsheet->getActiveSheet()->getColumnDimension($startCol)->setWidth((float) $columnWidth);
406406
do {
407-
$spreadsheet->getActiveSheet()->getColumnDimension(++$startCol)->setWidth((float) $columnWidth);
407+
$spreadsheet->getActiveSheet()->getColumnDimension((string) ++$startCol)->setWidth((float) $columnWidth);
408408
} while ($startCol !== $endCol);
409409
}
410410
}

src/PhpSpreadsheet/Reader/Xlsx/SheetViews.php

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,20 @@ private function zoomScale(): void
7070

7171
$this->worksheet->getSheetView()->setZoomScaleNormal($zoomScaleNormal);
7272
}
73+
74+
if (isset($this->sheetViewAttributes->zoomScalePageLayoutView)) {
75+
$zoomScaleNormal = (int) ($this->sheetViewAttributes->zoomScalePageLayoutView);
76+
if ($zoomScaleNormal > 0) {
77+
$this->worksheet->getSheetView()->setZoomScalePageLayoutView($zoomScaleNormal);
78+
}
79+
}
80+
81+
if (isset($this->sheetViewAttributes->zoomScaleSheetLayoutView)) {
82+
$zoomScaleNormal = (int) ($this->sheetViewAttributes->zoomScaleSheetLayoutView);
83+
if ($zoomScaleNormal > 0) {
84+
$this->worksheet->getSheetView()->setZoomScaleSheetLayoutView($zoomScaleNormal);
85+
}
86+
}
7387
}
7488

7589
private function view(): void

0 commit comments

Comments
 (0)