Skip to content

Commit cc86557

Browse files
committed
Remove Connection: keep-alive
Unacceptable performance.
1 parent 6247643 commit cc86557

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ and this project adheres to [Semantic Versioning](https://semver.org).
2121

2222
### Deprecated
2323

24-
- Nothing yet.
24+
- Drawing::setIsUrl is unneeded. The property is set when setPath determines whether path is a url.
2525

2626
### Fixed
2727

28-
- Nothing yet.
28+
- More context options may be needed for http(s) image. [Php issue 17121](https://github.com/php/php-src/issues/17121) [PR #4276](https://github.com/PHPOffice/PhpSpreadsheet/pull/4276)
2929

3030
## 2024-12-08 - 3.6.0
3131

src/PhpSpreadsheet/Worksheet/Drawing.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public function setPath(string $path, bool $verifyFile = true, ?ZipArchive $zip
117117
'http' => [
118118
'user_agent' => 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36',
119119
'header' => [
120-
'Connection: keep-alive',
120+
//'Connection: keep-alive', // unacceptable performance
121121
// accept header used by chrome without image/webp
122122
'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7',
123123
],

0 commit comments

Comments
 (0)