Skip to content

Commit b1beafb

Browse files
authored
Merge pull request #4398 from oleibman/localesplit2
Move Locale Logic in Calculation to Separate Class
2 parents 5868f89 + c3ea02e commit b1beafb

File tree

6 files changed

+482
-469
lines changed

6 files changed

+482
-469
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
2020

2121
- Phpstan Version 2. [PR #4384](https://github.com/PHPOffice/PhpSpreadsheet/pull/4384)
2222
- Start migration to Phpstan level 9. [PR #4396](https://github.com/PHPOffice/PhpSpreadsheet/pull/4396)
23+
- Calculation locale logic moved to separate class. [PR #4398](https://github.com/PHPOffice/PhpSpreadsheet/pull/4398)
2324
- TREND_POLYNOMIAL_* and TREND_BEST_FIT do not work, and are changed to throw Exceptions if attempted. (TREND_BEST_FIT_NO_POLY works.) An attempt to use an unknown trend type will now also throw an exception. [Issue #4400](https://github.com/PHPOffice/PhpSpreadsheet/issues/4400) [PR #4339](https://github.com/PHPOffice/PhpSpreadsheet/pull/4339)
2425

2526
### Moved

phpstan-baseline.neon

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1608,24 +1608,6 @@ parameters:
16081608
count: 2
16091609
path: src/PhpSpreadsheet/Calculation/TextData/Text.php
16101610

1611-
-
1612-
message: '#^Method PhpOffice\\PhpSpreadsheet\\Calculation\\Token\\Stack\:\:last\(\) should return array\|null but returns mixed\.$#'
1613-
identifier: return.type
1614-
count: 1
1615-
path: src/PhpSpreadsheet/Calculation/Token/Stack.php
1616-
1617-
-
1618-
message: '#^Method PhpOffice\\PhpSpreadsheet\\Calculation\\Token\\Stack\:\:pop\(\) should return array\|null but returns mixed\.$#'
1619-
identifier: return.type
1620-
count: 1
1621-
path: src/PhpSpreadsheet/Calculation/Token/Stack.php
1622-
1623-
-
1624-
message: '#^Parameter \#1 \$function of static method PhpOffice\\PhpSpreadsheet\\Calculation\\Calculation\:\:localeFunc\(\) expects string, mixed given\.$#'
1625-
identifier: argument.type
1626-
count: 1
1627-
path: src/PhpSpreadsheet/Calculation/Token/Stack.php
1628-
16291611
-
16301612
message: '#^Part \$formula \(mixed\) of encapsed string cannot be cast to string\.$#'
16311613
identifier: encapsedStringPart.nonString

0 commit comments

Comments
 (0)