Merge pull request #2652 from PHPOffice/Gnumeric-Selected-Cells-in-Worksheet

Set Selected Cells for Worksheets in Gnumeric Loader

Author: Mark Baker

CHANGELOG.md

@@ -19,11 +19,11 @@ and this project adheres to [Semantic Versioning](https://semver.org).
 ### Changed
 
 - Gnumeric Reader now loads number formatting for cells.
-- Gnumeric Reader now correctly identifies selected worksheet.
+- Gnumeric Reader now correctly identifies selected worksheet and selected cells in a worksheet.
 - Some Refactoring of the Ods Reader, moving all formula and address translation from Ods to Excel into a separate class to eliminate code duplication and ensure consistency.
 - Make Boolean Conversion in Csv Reader locale-aware when using the String Value Binder.
 
-  This is determined b the Calculation Engine locale setting.
+  This is determined by the Calculation Engine locale setting.
 
   (i.e. `"Vrai"` wil be converted to a boolean `true` if the Locale is set to `fr`.)
 

src/PhpSpreadsheet/Reader/Gnumeric.php

@@ -309,6 +309,7 @@ public function loadIntoExisting(string $filename, Spreadsheet $spreadsheet): Sp
             $this->processMergedCells($sheet);
             $this->processAutofilter($sheet);
 
+            $this->setSelectedCells($sheet);
             ++$worksheetID;
         }
 
@@ -329,6 +330,28 @@ private function setSelectedSheet(SimpleXMLElement $gnmXML): void
         }
     }
 
+    private function setSelectedCells(?SimpleXMLElement $sheet): void
+    {
+        if ($sheet !== null && isset($sheet->Selections)) {
+            foreach ($sheet->Selections as $selection) {
+                $startCol = (int) ($selection->StartCol ?? 0);
+                $startRow = (int) ($selection->StartRow ?? 0) + 1;
+                $endCol = (int) ($selection->EndCol ?? $startCol);
+                $endRow = (int) ($selection->endRow ?? 0) + 1;
+
+                $startColumn = Coordinate::stringFromColumnIndex($startCol + 1);
+                $endColumn = Coordinate::stringFromColumnIndex($endCol + 1);
+
+                $startCell = "{$startColumn}{$startRow}";
+                $endCell = "{$endColumn}{$endRow}";
+                $selectedRange = $startCell . (($endCell !== $startCell) ? ':' . $endCell : '');
+                $this->spreadsheet->getActiveSheet()->setSelectedCell($selectedRange);
+
+                break;
+            }
+        }
+    }
+
     private function processMergedCells(?SimpleXMLElement $sheet): void
     {
         //    Handle Merged Cells in this worksheet
@@ -357,15 +380,17 @@ private function processAutofilter(?SimpleXMLElement $sheet): void
 
     private function setColumnWidth(int $whichColumn, float $defaultWidth): void
     {
-        $columnDimension = $this->spreadsheet->getActiveSheet()->getColumnDimension(Coordinate::stringFromColumnIndex($whichColumn + 1));
+        $columnDimension = $this->spreadsheet->getActiveSheet()
+            ->getColumnDimension(Coordinate::stringFromColumnIndex($whichColumn + 1));
         if ($columnDimension !== null) {
             $columnDimension->setWidth($defaultWidth);
         }
     }
 
     private function setColumnInvisible(int $whichColumn): void
     {
-        $columnDimension = $this->spreadsheet->getActiveSheet()->getColumnDimension(Coordinate::stringFromColumnIndex($whichColumn + 1));
+        $columnDimension = $this->spreadsheet->getActiveSheet()
+            ->getColumnDimension(Coordinate::stringFromColumnIndex($whichColumn + 1));
         if ($columnDimension !== null) {
             $columnDimension->setVisible(false);
         }

tests/PhpSpreadsheetTests/Reader/Gnumeric/GnumericLoadTest.php

@@ -125,6 +125,8 @@ public function testLoad(): void
         self::assertTrue($sheet->getCell('B24')->getStyle()->getFont()->getSuperScript());
         $rowDimension = $sheet->getRowDimension(30);
         self::assertFalse($rowDimension->getVisible());
+
+        self::assertSame('B24', $sheet->getSelectedCells());
     }
 
     public function testLoadFilter(): void
@@ -167,5 +169,7 @@ public function testLoadSelectedSheets(): void
         $sheet = $spreadsheet->getSheet(0);
         self::assertEquals('Report Data', $sheet->getTitle());
         self::assertEquals('Third Heading', $sheet->getCell('C2')->getValue());
+
+        self::assertSame('A1', $sheet->getSelectedCells());
     }
 }