Skip to content

Commit 715b50a

Browse files
author
MarkBaker
committed
Minor memory improvement
1 parent 177a362 commit 715b50a

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/PhpSpreadsheet/ReferenceHelper.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,7 @@ protected function adjustColumnDimensions(Worksheet $worksheet): void
316316
$objColumnDimension->setColumnIndex($newReference);
317317
}
318318
}
319+
319320
$worksheet->refreshColumnDimensions();
320321
}
321322
}
@@ -339,6 +340,7 @@ protected function adjustRowDimensions(Worksheet $worksheet, $beforeRow, $number
339340
$objRowDimension->setRowIndex($newRoweference);
340341
}
341342
}
343+
342344
$worksheet->refreshRowDimensions();
343345

344346
$copyDimension = $worksheet->getRowDimension($beforeRow - 1);

src/PhpSpreadsheet/Worksheet/Worksheet.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -658,10 +658,8 @@ public function getChartByName($chartName)
658658
*/
659659
public function refreshColumnDimensions()
660660
{
661-
$currentColumnDimensions = $this->getColumnDimensions();
662661
$newColumnDimensions = [];
663-
664-
foreach ($currentColumnDimensions as $objColumnDimension) {
662+
foreach ($this->getColumnDimensions() as $objColumnDimension) {
665663
$newColumnDimensions[$objColumnDimension->getColumnIndex()] = $objColumnDimension;
666664
}
667665

@@ -677,10 +675,8 @@ public function refreshColumnDimensions()
677675
*/
678676
public function refreshRowDimensions()
679677
{
680-
$currentRowDimensions = $this->getRowDimensions();
681678
$newRowDimensions = [];
682-
683-
foreach ($currentRowDimensions as $objRowDimension) {
679+
foreach ($this->getRowDimensions() as $objRowDimension) {
684680
$newRowDimensions[$objRowDimension->getRowIndex()] = $objRowDimension;
685681
}
686682

0 commit comments

Comments
 (0)