Skip to content

Commit 2a0a53c

Browse files
committed
Drop all Scrutinizer annotations
Because they tend to clutter our code a lot and unfortunately, there are lots of false positives. Instead, it would probably be better to deal with false positives out of band, via the Scrutinizer web UI.
1 parent 07c60ba commit 2a0a53c

File tree

218 files changed

+493
-732
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

218 files changed

+493
-732
lines changed

infra/DocumentGenerator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ private static function getCategories(): array
4141
private static function tableRow(array $lengths, ?array $values = null): string
4242
{
4343
$result = '';
44-
foreach (array_map(/** @scrutinizer ignore-type */ null, $lengths, $values ?? []) as $i => [$length, $value]) {
44+
foreach (array_map(null, $lengths, $values ?? []) as $i => [$length, $value]) {
4545
$pad = $value === null ? '-' : ' ';
4646
if ($i > 0) {
4747
$result .= '|' . $pad;

samples/Basic/25_In_memory_image.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
$drawing = new MemoryDrawing();
4141
$drawing->setName('Sample image');
4242
$drawing->setDescription('Sample image');
43-
$drawing->setImageResource(/** @scrutinizer ignore-type */ $gdImage);
43+
$drawing->setImageResource($gdImage);
4444
$drawing->setRenderingFunction(MemoryDrawing::RENDERING_JPEG);
4545
$drawing->setMimeType(MemoryDrawing::MIMETYPE_DEFAULT);
4646
$drawing->setHeight(36);
@@ -56,7 +56,7 @@
5656
$drawing = new MemoryDrawing();
5757
$drawing->setName('Sample image');
5858
$drawing->setDescription('Sample image');
59-
$drawing->setImageResource(/** @scrutinizer ignore-type */ $gdImage);
59+
$drawing->setImageResource($gdImage);
6060
$drawing->setRenderingFunction(MemoryDrawing::RENDERING_JPEG);
6161
$drawing->setMimeType(MemoryDrawing::MIMETYPE_DEFAULT);
6262
$drawing->setHeight(36);

samples/Calculations/DateTime/DAYS360.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,7 @@
5151
));
5252
$helper->log(sprintf(
5353
'Days: %d (US) %d (European)',
54-
/** @scrutinizer ignore-type */
5554
$worksheet->getCell('G' . $row)->getCalculatedValue(),
56-
/** @scrutinizer ignore-type */
5755
$worksheet->getCell('H' . $row)->getCalculatedValue()
5856
));
5957
}

samples/Calculations/DateTime/EDATE.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
'%s and %d months is %d (%s)',
3838
$worksheet->getCell('B' . $row)->getFormattedValue(),
3939
$worksheet->getCell('C' . $row)->getFormattedValue(),
40-
/** @scrutinizer ignore-type */
4140
$worksheet->getCell('D' . $row)->getCalculatedValue(),
4241
$worksheet->getCell('D' . $row)->getFormattedValue()
4342
));

samples/Calculations/DateTime/EOMONTH.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
'%s and %d months is %d (%s)',
3838
$worksheet->getCell('B' . $row)->getFormattedValue(),
3939
$worksheet->getCell('C' . $row)->getFormattedValue(),
40-
/** @scrutinizer ignore-type */
4140
$worksheet->getCell('D' . $row)->getCalculatedValue(),
4241
$worksheet->getCell('D' . $row)->getFormattedValue()
4342
));

samples/Calculations/DateTime/NETWORKDAYS.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,7 @@
6060
'Between %s and %s is %d working days; %d with public holidays',
6161
$worksheet->getCell('A1')->getFormattedValue(),
6262
$worksheet->getCell('B' . $row)->getFormattedValue(),
63-
/** @scrutinizer ignore-type */
6463
$worksheet->getCell('C' . $row)->getCalculatedValue(),
65-
/** @scrutinizer ignore-type */
6664
$worksheet->getCell('D' . $row)->getCalculatedValue()
6765
));
6866
}

samples/Calculations/DateTime/NOW.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
// Test the formulae
2323
$helper->log(sprintf(
2424
'Today is %f (%s)',
25-
/** @scrutinizer ignore-type */
2625
$worksheet->getCell('A1')->getCalculatedValue(),
2726
$worksheet->getCell('A1')->getFormattedValue()
2827
));

samples/Calculations/DateTime/TODAY.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
// Test the formulae
2323
$helper->log(sprintf(
2424
'Today is %d (%s)',
25-
/** @scrutinizer ignore-type */
2625
$worksheet->getCell('A1')->getCalculatedValue(),
2726
$worksheet->getCell('A1')->getFormattedValue()
2827
));

samples/Calculations/DateTime/WEEKDAY.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,10 @@
4949
$helper->log(sprintf('(E%d): %s', $row, $worksheet->getCell('E' . $row)->getFormattedValue()));
5050
$helper->log(sprintf(
5151
'Weekday is: %d (1-7 = Sun-Sat)',
52-
/** @scrutinizer ignore-type */
5352
$worksheet->getCell('F' . $row)->getCalculatedValue()
5453
));
5554
$helper->log(sprintf(
5655
'Weekday is: %d (1-7 = Mon-Sun)',
57-
/** @scrutinizer ignore-type */
5856
$worksheet->getCell('G' . $row)->getCalculatedValue()
5957
));
6058
}

samples/Calculations/DateTime/YEARFRAC.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,27 +55,22 @@
5555
));
5656
$helper->log(sprintf(
5757
'Days: %f - US (NASD) 30/360',
58-
/** @scrutinizer ignore-type */
5958
$worksheet->getCell('G' . $row)->getCalculatedValue()
6059
));
6160
$helper->log(sprintf(
6261
'Days: %f - Actual',
63-
/** @scrutinizer ignore-type */
6462
$worksheet->getCell('H' . $row)->getCalculatedValue()
6563
));
6664
$helper->log(sprintf(
6765
'Days: %f - Actual/360',
68-
/** @scrutinizer ignore-type */
6966
$worksheet->getCell('I' . $row)->getCalculatedValue()
7067
));
7168
$helper->log(sprintf(
7269
'Days: %f - Actual/365',
73-
/** @scrutinizer ignore-type */
7470
$worksheet->getCell('J' . $row)->getCalculatedValue()
7571
));
7672
$helper->log(sprintf(
7773
'Days: %f - European 30/360',
78-
/** @scrutinizer ignore-type */
7974
$worksheet->getCell('K' . $row)->getCalculatedValue()
8075
));
8176
}

0 commit comments

Comments
 (0)