Indentation Changes

Makes no sense to multiply by 720 when supplied in array to Paragraph, but left unchanged when supplied directly. Skip multiplication.

Author: oleibman

phpstan-baseline.neon

@@ -1760,36 +1760,11 @@ parameters:
 			count: 1
 			path: tests/PhpWordTests/Style/FontTest.php
 
-		-
-			message: "#^Binary operation \"\\*\" between 1\\|120\\|240\\|'atLeast'\\|'auto'\\|'Normal'\\|'numStyle'\\|bool and 720 results in an error\\.$#"
-			count: 1
-			path: tests/PhpWordTests/Style/ParagraphTest.php
-
 		-
 			message: "#^Cannot call method setLineHeight\\(\\) on PhpOffice\\\\PhpWord\\\\Style\\\\Paragraph\\|string\\.$#"
 			count: 1
 			path: tests/PhpWordTests/Style/ParagraphTest.php
 
-		-
-			message: "#^Method PhpOffice\\\\PhpWordTests\\\\Style\\\\ParagraphTest\\:\\:findGetter\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: tests/PhpWordTests/Style/ParagraphTest.php
-
-		-
-			message: "#^Method PhpOffice\\\\PhpWordTests\\\\Style\\\\ParagraphTest\\:\\:findGetter\\(\\) has parameter \\$key with no type specified\\.$#"
-			count: 1
-			path: tests/PhpWordTests/Style/ParagraphTest.php
-
-		-
-			message: "#^Method PhpOffice\\\\PhpWordTests\\\\Style\\\\ParagraphTest\\:\\:findGetter\\(\\) has parameter \\$object with no type specified\\.$#"
-			count: 1
-			path: tests/PhpWordTests/Style/ParagraphTest.php
-
-		-
-			message: "#^Method PhpOffice\\\\PhpWordTests\\\\Style\\\\ParagraphTest\\:\\:findGetter\\(\\) has parameter \\$value with no type specified\\.$#"
-			count: 1
-			path: tests/PhpWordTests/Style/ParagraphTest.php
-
 		-
 			message: "#^Parameter \\#2 \\$value of method PhpOffice\\\\PhpWord\\\\Style\\\\AbstractStyle\\:\\:setStyleValue\\(\\) expects array\\|int\\|string, bool given\\.$#"
 			count: 1

src/PhpWord/Style/Paragraph.php

@@ -199,9 +199,9 @@ class Paragraph extends Border
     public function setStyleValue($key, $value)
     {
         $key = Text::removeUnderscorePrefix($key);
-        if ('indent' == $key || 'hanging' == $key) {
-            $value = $value * 720;  // 720 twips is 0.5 inch
-        }
+        //if ('indent' == $key || 'hanging' == $key) {
+        //    $value = $value * 720;  // 720 twips is 0.5 inch
+        //}
 
         return parent::setStyleValue($key, $value);
     }

src/PhpWord/Writer/HTML/Style/Paragraph.php

@@ -95,7 +95,7 @@ public function write()
         }
         $ind = $style->getIndentation();
         if ($ind != null) {
-            $tcpdf = $this->getParentWriter()->isTcpdf();
+            $tcpdf = ($this->getParentWriter() === null) ? false : $this->getParentWriter()->isTcpdf(); // @phpstan-ignore-line
             $left = $ind->getLeft();
             $inches = $left * 1.0 / \PhpOffice\PhpWord\Shared\Converter::INCH_TO_TWIP;
             $css[$tcpdf ? 'text-indent' : 'margin-left'] = ((string) $inches) . 'in';

tests/PhpWordTests/Style/ParagraphTest.php

@@ -91,13 +91,20 @@ public function testSetStyleValueNormal(): void
         foreach ($attributes as $key => $value) {
             $get = $this->findGetter($key, $value, $object);
             $object->setStyleValue("$key", $value);
-            if ('indent' == $key || 'hanging' == $key) {
-                $value = $value * 720;
-            }
+            //if ('indent' == $key || 'hanging' == $key) {
+            //    $value = $value * 720;
+            //}
             self::assertEquals($value, $object->$get());
         }
     }
 
+    /**
+     * @param string $key
+     * @param mixed $value
+     * @param object $object
+     *
+     * @return string
+     */
     private function findGetter($key, $value, $object)
     {
         if (is_bool($value)) {