File tree Expand file tree Collapse file tree 2 files changed +7
-1
lines changed Expand file tree Collapse file tree 2 files changed +7
-1
lines changed Original file line number Diff line number Diff line change @@ -34,6 +34,8 @@ http://pear.php.net/dtd/package-2.0.xsd">
34
34
- The Squiz standard now ensures underscores are not used to indicate visibility of private members vars and methods
35
35
-- Previously, this standard enforced the use of underscores
36
36
- Squiz.Commenting.FunctionComment no longer errors when trying to fix indents of multi-line param comments
37
+ - Fixed a problem where referencing a relative file path in a ruleset XML file could add unnecessary sniff exclusions
38
+ -- This didn't actually exclude anything, but caused verbose output to list strange exclusion rules
37
39
- Fixed bug #2110 : Squiz.WhiteSpace.FunctionSpacing is removing indents from the start of functions when fixing
38
40
-- Thanks to Juliette Reinders Folmer for the patch
39
41
- Fixed bug #2115 : Squiz.Commenting.VariableComment not checking var types when the @var line contains a comment
Original file line number Diff line number Diff line change @@ -390,7 +390,11 @@ public function processRuleset($rulesetPath, $depth=0)
390
390
$ includedSniffs = array_merge ($ includedSniffs , $ expandedSniffs );
391
391
392
392
$ parts = explode ('. ' , $ rule ['ref ' ]);
393
- if (count ($ parts ) === 4 ) {
393
+ if (count ($ parts ) === 4
394
+ && $ parts [0 ] !== ''
395
+ && $ parts [1 ] !== ''
396
+ && $ parts [2 ] !== ''
397
+ ) {
394
398
$ sniffCode = $ parts [0 ].'. ' .$ parts [1 ].'. ' .$ parts [2 ];
395
399
if (isset ($ this ->ruleset [$ sniffCode ]['severity ' ]) === true
396
400
&& $ this ->ruleset [$ sniffCode ]['severity ' ] === 0
You can’t perform that action at this time.
0 commit comments