Squiz/ForLoopDeclaration: bugfix with closures being used in expressions

When a closure would be used within an expression, the code within the closure would also contain semicolons.

The existing code did not take that into account and would throw false positives for spacing around semicolons in the closures (not the concern of this sniff) and would incorrectly neglect to throw errors for spacing around semicolons after the closure.

This is now fixed.

Author: jrfnl

src/Standards/Squiz/Sniffs/ControlStructures/ForLoopDeclarationSniff.php

@@ -176,15 +176,26 @@ public function process(File $phpcsFile, $stackPtr)
          * Check whitespace around each of the semicolon tokens.
          */
 
-        $semicolonCount = 0;
-        $semicolon      = $openingBracket;
+        $semicolonCount     = 0;
+        $semicolon          = $openingBracket;
+        $targetNestinglevel = 0;
+        if (isset($tokens[$openingBracket]['conditions']) === true) {
+            $targetNestinglevel += count($tokens[$openingBracket]['conditions']);
+        }
 
         do {
             $semicolon = $phpcsFile->findNext(T_SEMICOLON, ($semicolon + 1), $closingBracket);
             if ($semicolon === false) {
                 break;
             }
 
+            if (isset($tokens[$semicolon]['conditions']) === true
+                && count($tokens[$semicolon]['conditions']) > $targetNestinglevel
+            ) {
+                // Semicolon doesn't belong to the for().
+                continue;
+            }
+
             ++$semicolonCount;
 
             $humanReadableCount = 'first';