Squiz/EmbeddedPhp: efficiency fix - bow out early if there is nothing to do

No need to go through the rest of the logic for the multi-line PHP block handling if there is nothing to do for the sniff.

Author: jrfnl

src/Standards/Squiz/Sniffs/PHP/EmbeddedPhpSniff.php

@@ -79,6 +79,10 @@ private function validateMultilineEmbeddedPhp($phpcsFile, $stackPtr, $closingTag
         }
 
         $firstContent = $phpcsFile->findNext(T_WHITESPACE, ($stackPtr + 1), null, true);
+        if ($firstContent === false) {
+            // Unclosed PHP open tag at the end of a file. Nothing to do.
+            return;
+        }
 
         if ($closingTag !== false) {
             $firstContentAfterBlock = $phpcsFile->findNext(T_WHITESPACE, ($closingTag + 1), $phpcsFile->numTokens, true);

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.10.inc

@@ -0,0 +1,16 @@
+<?php
+// This test case file MUST always start with a long open PHP tag set (with this comment) to prevent
+// the tests running into the "first PHP open tag excepted" condition breaking the tests.
+// Tests related to that "first PHP open tag excepted" condition should go in separate files.
+?>
+<!--
+The below test safeguards that if there is just an unclosed PHP open tag at the end of a file,
+the sniff bows out as there is nothing to do, even when there are multiple new lines after the open tag.
+-->
+<?php
+
+
+
+
+
+

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.11.inc

@@ -0,0 +1,14 @@
+<?php
+// This test case file MUST always start with a long open PHP tag set (with this comment) to prevent
+// the tests running into the "first PHP open tag excepted" condition breaking the tests.
+// Tests related to that "first PHP open tag excepted" condition should go in separate files.
+?>
+<!--
+The below test safeguards that if there is just an unclosed PHP open tag at the end of a file,
+the sniff bows out as there is nothing to do, even when there are multiple new lines after the open tag.
+-->
+<?=
+
+
+
+

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.8.inc

@@ -0,0 +1,10 @@
+<?php
+// This test case file MUST always start with a long open PHP tag set (with this comment) to prevent
+// the tests running into the "first PHP open tag excepted" condition breaking the tests.
+// Tests related to that "first PHP open tag excepted" condition should go in separate files.
+?>
+<!--
+The below test safeguards that if there is just an unclosed PHP open tag at the end of a file,
+the sniff bows out as there is nothing to do.
+-->
+<?php

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.9.inc

@@ -0,0 +1,10 @@
+<?php
+// This test case file MUST always start with a long open PHP tag set (with this comment) to prevent
+// the tests running into the "first PHP open tag excepted" condition breaking the tests.
+// Tests related to that "first PHP open tag excepted" condition should go in separate files.
+?>
+<!--
+The below test safeguards that if there is just an unclosed PHP open tag at the end of a file,
+the sniff bows out as there is nothing to do.
+-->
+<?=