Fixed bug #2586 : Generic.WhiteSpace.ScopeIndent false positives when indenting open tags at a non tab-stop

Author: gsherwood

package.xml

@@ -39,6 +39,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - Generic.WhiteSpace.ScopeIndent now supports static arrow functions
   - PSR2.ControlStructures.ControlStructureSpacing now checks whitespace before the closing parenthesis of multi-line control structures
     -- Previously, it incorrectly applied the whitespace check for single-line definitions only
+  - Fixed bug #2586 : Generic.WhiteSpace.ScopeIndent false positives when indenting open tags at a non tab-stop
   - Fixed bug #2638 : Squiz.CSS.DuplicateClassDefinitionSniff sees comments as part of the class name
     -- Thanks to Raphael Horber for the patch
   - Fixed bug #2674 : Squiz.Functions.FunctionDeclarationArgumentSpacing prints wrong argument name in error message

src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php

@@ -894,8 +894,6 @@ public function process(File $phpcsFile, $stackPtr)
                         }
                     }
                 }
-
-                $checkIndent = (int) (ceil($checkIndent / $this->indent) * $this->indent);
             }//end if
 
             // Close tags needs to be indented to exact column positions.

src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.1.inc

@@ -1441,6 +1441,10 @@ $result = array_map(
 
 ?>
 
+     <?php if (true) : ?>
+         <span></span>
+     <?php endif ?>
+
 <?php
     if (true) {
     }

src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.1.inc.fixed

@@ -1441,6 +1441,10 @@ $result = array_map(
 
 ?>
 
+     <?php if (true) : ?>
+         <span></span>
+     <?php endif ?>
+
 <?php
 if (true) {
 }

src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.2.inc

@@ -1441,6 +1441,10 @@ $result = array_map(
 
 ?>
 
+	 <?php if (true) : ?>
+		 <span></span>
+	 <?php endif ?>
+
 <?php
 	if (true) {
 	}

src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.2.inc.fixed

@@ -1441,6 +1441,10 @@ $result = array_map(
 
 ?>
 
+	 <?php if (true) : ?>
+		 <span></span>
+	 <?php endif ?>
+
 <?php
 if (true) {
 }

src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.php

@@ -178,10 +178,10 @@ public function getErrorList($testFile='ScopeIndentUnitTest.inc')
             1340 => 1,
             1342 => 1,
             1345 => 1,
-            1445 => 1,
-            1446 => 1,
-            1447 => 1,
-            1448 => 1,
+            1449 => 1,
+            1450 => 1,
+            1451 => 1,
+            1452 => 1,
         ];
 
     }//end getErrorList()