Skip to content

Commit a3e9ecb

Browse files
authored
Merge pull request #130 from DannyvdSluijs/Correction-to-contributing
Correct spelling issues in contributing
2 parents 46d8b1c + 4941645 commit a3e9ecb

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/CONTRIBUTING.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,14 @@ To find issues which need triage, look for [issues without labels](https://githu
5050
* Ask for additional information if it is not.
5151
* If you find the issue is reported to the wrong repo, ask the reporter to report it to the correct external standard repo and suggest closing the issue.
5252

53-
Additionally for older issues:
53+
Additionally, for older issues:
5454
* Check whether an issue still exists or has been fixed in `master` since the issue was initially reported.
5555
* If it has been fixed, document (in a comment) which commit/PR was responsible for fixing the issue and suggest closing the ticket.
5656

5757

5858
### Testing Open Pull Requests
5959

60-
Testing pull requests to verify they fix the issue they are supposed to fix without side-effects is an important task.
60+
Testing pull requests to verify they fix the issue they are supposed to fix without side effects is an important task.
6161

6262
To get access to a PHPCS version which includes the patch from a pull request, you can:
6363
* Either use a git clone of the PHP_CodeSniffer repository and check out the PR.
@@ -69,7 +69,7 @@ To get access to a PHPCS version which includes the patch from a pull request, y
6969
* Verify that the patch solves the originally reported problem.
7070
* Verify that the tests added in the PR fail without the fix and pass with the fix.
7171
* For a fix for false negatives: verify that the correct error message(s) are thrown by the patched code.
72-
* Run the patched PHPCS version against real codebases to see if the fix creates any side-effects (new false positives/false negatives).
72+
* Run the patched PHPCS version against real codebases to see if the fix creates any side effects (new false positives/false negatives).
7373

7474

7575
### Writing sniff documentation
@@ -190,7 +190,7 @@ The `getErrorList()` and the `getWarningList()` methods will receive an optional
190190

191191
If a sniff contains errors/warnings which can be auto-fixed, these fixers should also be tested.
192192

193-
This is done by adding an additional test _case_ file with an extra `.fixed` extension for each test _case_ file which expects fixes.
193+
This is done by adding a test _case_ file with an extra `.fixed` extension for each test _case_ file which expects fixes.
194194

195195
For example, if the above `Generic.NamingConventions.ConstructorName` would contain an auto-fixer, there should be an additional `src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.inc.fixed` file containing the code as it is expected to be after the fixer has run.
196196

@@ -203,12 +203,12 @@ Some guidelines for submitting pull requests (PRs) and improving the chance that
203203
If your change is complex, make sure you add a proper commit message explaining what you have done and why.
204204
* Please clean up your branch before pulling your PR.
205205
Small PRs using atomic, descriptive commits are hugely appreciated as it will make reviewing your changes easier for the maintainers.
206-
* Only open your PR when you've finished work on it and you are confident that it is ready for review.
206+
* Only open your PR when you've finished work on it, and you are confident that it is ready for review.
207207
* Please make sure your pull request passes all continuous integration checks.
208208
PRs which are failing their CI checks will likely be ignored by the maintainers or closed.
209209
* Please respond to PR reviews in a timely manner.
210210

211-
Your time is valuable and we appreciate your willingness to spend it on this project.
211+
Your time is valuable, and we appreciate your willingness to spend it on this project.
212212
However, the maintainers time is also valuable and often, more scarce, so please be considerate of that.
213213

214214
## Licensing

0 commit comments

Comments
 (0)