Skip to content

Commit 8c9b10a

Browse files
committed
Excluded some messages as they were being reported twice
1 parent a10963b commit 8c9b10a

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

src/Standards/PSR12/ruleset.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,14 @@
274274

275275
<!-- 5.5 foreach -->
276276

277+
<!-- exclude these messages as they are already checked by PSR2.ControlStructures.ControlStructureSpacing -->
278+
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.SpaceAfterOpen">
279+
<severity>0</severity>
280+
</rule>
281+
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.SpaceBeforeClose">
282+
<severity>0</severity>
283+
</rule>
284+
277285
<!-- 5.6 try, catch, finally -->
278286

279287
<!-- 6. Operators -->

src/Standards/PSR2/ruleset.xml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@
146146
<!-- 4.6 Method and Function Calls -->
147147

148148
<!-- When making a method or function call, there MUST NOT be a space between the method or function name and the opening parenthesis, there MUST NOT be a space after the opening parenthesis, and there MUST NOT be a space before the closing parenthesis. In the argument list, there MUST NOT be a space before each comma, and there MUST be one space after each comma.
149-
Argument lists MAY be split across multiple lines, where each subsequent line is indented once. When doing so, the first item in the list MUST be on the next line, and there MUST be only one argument per line. -->
149+
Argument lists MAY be split across multiple lines, where each subsequent line is indented once. When doing so, the first item in the list MUST be on the next line, and there MUST be only one argument per line. -->
150150
<rule ref="Generic.Functions.FunctionCallArgumentSpacing"/>
151151
<rule ref="PSR2.Methods.FunctionCallSignature.SpaceAfterCloseBracket">
152152
<severity>0</severity>
@@ -179,11 +179,19 @@
179179
<rule ref="Squiz.ControlStructures.LowercaseDeclaration"/>
180180
<!-- checked by PSR2.ControlStructures.ControlStructureSpacing -->
181181

182-
<!-- exclude this message as it is already checked Generic.PHP.LowerCaseKeyword -->
182+
<!-- exclude this message as it is already checked by Generic.PHP.LowerCaseKeyword -->
183183
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.AsNotLower">
184184
<severity>0</severity>
185185
</rule>
186186

187+
<!-- exclude these messages as they are already checked by PSR2.ControlStructures.ControlStructureSpacing -->
188+
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.SpaceAfterOpen">
189+
<severity>0</severity>
190+
</rule>
191+
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.SpaceBeforeClose">
192+
<severity>0</severity>
193+
</rule>
194+
187195
<!-- The body of each structure MUST be enclosed by braces. This standardizes how the structures look, and reduces the likelihood of introducing errors as new lines get added to the body. -->
188196
<rule ref="Generic.ControlStructures.InlineControlStructure"/>
189197

0 commit comments

Comments
 (0)