Squiz/IncrementDecrementUsage: suggest pre-in/decrement

jrfnl · jrfnl · commit 80f953c9e4cc · 2019-02-05T18:08:28.000+01:00
... rather than post in/decrement.

Fixes 2354
diff --git a/src/Standards/Squiz/Sniffs/Operators/IncrementDecrementUsageSniff.php b/src/Standards/Squiz/Sniffs/Operators/IncrementDecrementUsageSniff.php
@@ -205,7 +205,7 @@ protected function processAssignment($phpcsFile, $stackPtr)
                 }
             }
 
-            $expected = $tokens[$assignedVar]['content'].$operator.$operator;
+            $expected = $operator.$operator.$tokens[$assignedVar]['content'];
             $found    = $phpcsFile->getTokensAsString($assignedVar, ($statementEnd - $assignedVar + 1));
 
             if ($operator === '+') {

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ protected function processAssignment($phpcsFile, $stackPtr)`
`205`	`205`	`}`
`206`	`206`	`}`
`207`	`207`
`208`		`- $expected = $tokens[$assignedVar]['content'].$operator.$operator;`
	`208`	`+ $expected = $operator.$operator.$tokens[$assignedVar]['content'];`
`209`	`209`	`$found = $phpcsFile->getTokensAsString($assignedVar, ($statementEnd - $assignedVar + 1));`
`210`	`210`
`211`	`211`	`if ($operator === '+') {`