Generic/ForLoopWithTestFunctionCall: improve test coverage

This commit adds more test cases related to the
Generic/ForLoopWithTestFunctionCall sniff including test cases for the
alternative for syntax, more types of function calls in the test part of
the for loop and a test case to check defensive code when the for loop
doesn't have a opening parenthesis.

Author: rodrigoprimo

src/Standards/Generic/Tests/CodeAnalysis/ForLoopWithTestFunctionCallUnitTest.1.inc

@@ -12,4 +12,84 @@ for ($i = 0, $c = sizeof($a); $i < $c; ++$i) {
 $it = new ArrayIterator($a);
 for ($it->rewind(); $it->valid(); $it->next()) {
     echo $it->current();
-}
+}
+
+for ($i = 0; MyClass::staticMethod($value); $i++) {
+    echo $i;
+}
+
+for ($i = 0; $countFunction($value); $i++) {
+    echo $i;
+}
+
+$a = array(1, 2, 3, 4);
+for ($i = 0; $i < count($a); $i++):
+    $a[$i] *= $i;
+endfor;
+
+for ($i = 0, $c = sizeof($a); $i < $c; ++$i):
+    $a[$i] *= $i;
+endfor;
+
+$it = new ArrayIterator($a);
+for ($it->rewind(); $it->valid(); $it->next()):
+    echo $it->current();
+endfor;
+
+for ($i = 0; MyClass::staticMethod($value); $i++) :
+    echo $i;
+endfor;
+
+for ($i = 0; $countFunction($value); $i++):
+    echo $i;
+endfor;
+
+for ($i = 0; (new MyClass)->method(); $i++) {
+}
+
+for (; $i < 10; ++$i) {}
+
+for (; count($a); ++$i) {}
+
+for ($i = 0;; ++$i) {}
+
+for ($i = 0; $i < 10;) {}
+
+for ($i = 0; count($a);) {}
+
+for (;; $i++) {}
+
+for ($i = 0;;) {}
+
+for (;;) {}
+
+for ($i = 0; (new MyClass)->method(); $i++):
+endfor;
+
+for (; $i < 10; ++$i) :
+endfor;
+
+for (; count($a); ++$i) :
+endfor;
+
+for ($i = 0;; ++$i) :
+endfor;
+
+for ($i = 0; $i < 10;) :
+endfor;
+
+for ($i = 0; count($a);) :
+endfor;
+
+for (;; $i++) :
+endfor;
+
+for ($i = 0;;) :
+endfor;
+
+for (;;) :
+endfor;
+
+for ($i = 0; $i < 10; $i = increment($i)) {}
+
+for ($i = initialValue(); $i < 10; $i = increment($i)) {}

src/Standards/Generic/Tests/CodeAnalysis/ForLoopWithTestFunctionCallUnitTest.2.inc

@@ -0,0 +1,5 @@
+<?php
+
+// Intentional parse error (missing open parenthesis). Testing that the sniff is *not* triggered
+// in this case.
+for

src/Standards/Generic/Tests/CodeAnalysis/ForLoopWithTestFunctionCallUnitTest.php

@@ -52,10 +52,22 @@ public function getWarningList($testFile='')
             return [
                 4  => 1,
                 13 => 1,
+                17 => 1,
+                21 => 1,
+                26 => 1,
+                35 => 1,
+                39 => 1,
+                43 => 1,
+                47 => 1,
+                52 => 1,
+                58 => 1,
+                66 => 1,
+                72 => 1,
+                81 => 1,
             ];
         default:
             return [];
-        }
+        }//end switch
 
     }//end getWarningList()