Fix some review comments

MasterOdin · MasterOdin · commit 6e172936d92b · 2019-08-11T18:55:41.000-04:00
diff --git a/src/Standards/Generic/Sniffs/Files/FilePermissionsSniff.php b/src/Standards/Generic/Sniffs/Files/FilePermissionsSniff.php
@@ -45,13 +45,12 @@ public function process(File $phpcsFile, $stackPtr)
             $perms = fileperms($phpcsFile->getFilename());
 
             if (($perms & 0x0040) !== 0 || ($perms & 0x0008) !== 0 || ($perms & 0x0001) !== 0) {
-                $error = "A PHP file must not be executable";
+                $error = "A PHP file should not be executable";
                 $phpcsFile->addError($error, $stackPtr, 'Executable');
             }
-
-            // Ignore the rest of the file.
         }
 
+        // Ignore the rest of the file.
         return ($phpcsFile->numTokens + 1);
 
     }//end process()

Original file line number	Diff line number	Diff line change
`@@ -45,13 +45,12 @@ public function process(File $phpcsFile, $stackPtr)`
`45`	`45`	`$perms = fileperms($phpcsFile->getFilename());`
`46`	`46`
`47`	`47`	`if (($perms & 0x0040) !== 0 \|\| ($perms & 0x0008) !== 0 \|\| ($perms & 0x0001) !== 0) {`
`48`		`- $error = "A PHP file must not be executable";`
	`48`	`+ $error = "A PHP file should not be executable";`
`49`	`49`	`$phpcsFile->addError($error, $stackPtr, 'Executable');`
`50`	`50`	`}`
`51`		`-`
`52`		`- // Ignore the rest of the file.`
`53`	`51`	`}`
`54`	`52`
	`53`	`+ // Ignore the rest of the file.`
`55`	`54`	`return ($phpcsFile->numTokens + 1);`
`56`	`55`
`57`	`56`	`}//end process()`